mbox series

[resend,v6,0/3] power: supply: mt6360_charger: add MT6360 charger support

Message ID 20210719033914.16990-1-gene.chen.richtek@gmail.com (mailing list archive)
Headers show
Series power: supply: mt6360_charger: add MT6360 charger support | expand

Message

Gene Chen July 19, 2021, 3:39 a.m. UTC
This patch series add MT6360 Charger support contains driver and binding
document

Gene Chen (3)
 lib: add linear range get selector within
 dt-bindings: power: Add bindings document for Charger support on MT6360 PMIC
 power: supply: mt6360_charger: add MT6360 charger support

 Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml |   48 
 drivers/power/supply/Kconfig                                       |   11 
 drivers/power/supply/Makefile                                      |    1 
 drivers/power/supply/mt6360_charger.c                              |  867 ++++++++++
 include/linux/linear_range.h                                       |    2 
 lib/linear_ranges.c                                                |   31 
 6 files changed, 960 insertions(+)

changelogs between v1 & v2
 - Add binding property with unit and custom name prefix
 - Remove extcon device, redundant brackets and interrupts
 - Fix power supply prop "charger type"

changelogs between v2 & v3
 - Add register selector to value mapping

changelogs between v3 & v4
 - move pdata vinovp to mt6360_chg_info
 - remove unuse sysfs attribute
 - refactor debug log and warning
 - add power supply prop input voltage limit

changelogs between v4 & v5
 - add linear range selector mapping
 - use linear range to map charger setting

changelogs between v5 & v6
 - use REGULATOR_LINEAR_RANGE
 - use devm_work_autocancel
 - fix Kconfig description

Comments

Sebastian Reichel Aug. 13, 2021, 3:54 p.m. UTC | #1
Hi,

On Mon, Jul 19, 2021 at 11:39:11AM +0800, Gene Chen wrote:
> This patch series add MT6360 Charger support contains driver and binding
> document

Thanks, queued.

-- Sebastian

> Gene Chen (3)
>  lib: add linear range get selector within
>  dt-bindings: power: Add bindings document for Charger support on MT6360 PMIC
>  power: supply: mt6360_charger: add MT6360 charger support
> 
>  Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml |   48 
>  drivers/power/supply/Kconfig                                       |   11 
>  drivers/power/supply/Makefile                                      |    1 
>  drivers/power/supply/mt6360_charger.c                              |  867 ++++++++++
>  include/linux/linear_range.h                                       |    2 
>  lib/linear_ranges.c                                                |   31 
>  6 files changed, 960 insertions(+)
> 
> changelogs between v1 & v2
>  - Add binding property with unit and custom name prefix
>  - Remove extcon device, redundant brackets and interrupts
>  - Fix power supply prop "charger type"
> 
> changelogs between v2 & v3
>  - Add register selector to value mapping
> 
> changelogs between v3 & v4
>  - move pdata vinovp to mt6360_chg_info
>  - remove unuse sysfs attribute
>  - refactor debug log and warning
>  - add power supply prop input voltage limit
> 
> changelogs between v4 & v5
>  - add linear range selector mapping
>  - use linear range to map charger setting
> 
> changelogs between v5 & v6
>  - use REGULATOR_LINEAR_RANGE
>  - use devm_work_autocancel
>  - fix Kconfig description
> 
>
Mark Brown Aug. 13, 2021, 3:58 p.m. UTC | #2
On Fri, Aug 13, 2021 at 05:54:38PM +0200, Sebastian Reichel wrote:
> On Mon, Jul 19, 2021 at 11:39:11AM +0800, Gene Chen wrote:
> > This patch series add MT6360 Charger support contains driver and binding
> > document

> Thanks, queued.

We're still waiting for review from Matti on the linear ranges bit -
normally that goes through the regulator tree, do you have a tag to pull
in case of merge conflicts?
Sebastian Reichel Aug. 13, 2021, 4:20 p.m. UTC | #3
Hi Mark,

On Fri, Aug 13, 2021 at 04:58:58PM +0100, Mark Brown wrote:
> On Fri, Aug 13, 2021 at 05:54:38PM +0200, Sebastian Reichel wrote:
> > On Mon, Jul 19, 2021 at 11:39:11AM +0800, Gene Chen wrote:
> > > This patch series add MT6360 Charger support contains driver and binding
> > > document
> 
> > Thanks, queued.
> 
> We're still waiting for review from Matti on the linear ranges bit -
> normally that goes through the regulator tree, do you have a tag to pull
> in case of merge conflicts?

He actually already provided his Rb in v5, Gene did not carry it
over properly (I added it) and the patch looks simple enough, that
Linus will know what to do in case of a conflict. But if you insist
I can unroll my tree and create a topic branch for this.

-- Sebastian
Mark Brown Aug. 13, 2021, 4:32 p.m. UTC | #4
On Fri, Aug 13, 2021 at 06:20:29PM +0200, Sebastian Reichel wrote:
> On Fri, Aug 13, 2021 at 04:58:58PM +0100, Mark Brown wrote:

> > We're still waiting for review from Matti on the linear ranges bit -
> > normally that goes through the regulator tree, do you have a tag to pull
> > in case of merge conflicts?

> He actually already provided his Rb in v5, Gene did not carry it
> over properly (I added it) and the patch looks simple enough, that
> Linus will know what to do in case of a conflict. But if you insist
> I can unroll my tree and create a topic branch for this.

It would be better, the issues I'm worrying about are more general
refactorings or whatever that create actual dependencies rather than
just trivial add/add type issues - it can make doing some kinds of work
really painful if things go via a different tree.
Sebastian Reichel Aug. 13, 2021, 5:11 p.m. UTC | #5
Hi,

On Fri, Aug 13, 2021 at 05:32:54PM +0100, Mark Brown wrote:
> On Fri, Aug 13, 2021 at 06:20:29PM +0200, Sebastian Reichel wrote:
> > On Fri, Aug 13, 2021 at 04:58:58PM +0100, Mark Brown wrote:
> 
> > > We're still waiting for review from Matti on the linear ranges bit -
> > > normally that goes through the regulator tree, do you have a tag to pull
> > > in case of merge conflicts?
> 
> > He actually already provided his Rb in v5, Gene did not carry it
> > over properly (I added it) and the patch looks simple enough, that
> > Linus will know what to do in case of a conflict. But if you insist
> > I can unroll my tree and create a topic branch for this.
> 
> It would be better, the issues I'm worrying about are more general
> refactorings or whatever that create actual dependencies rather than
> just trivial add/add type issues - it can make doing some kinds of work
> really painful if things go via a different tree.

There you go:

-- Sebastian

The following changes since commit e73f0f0ee7541171d89f2e2491130c7771ba58d3:

  Linux 5.14-rc1 (2021-07-11 15:07:40 -0700)

are available in the Git repository at:

  ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git tags/ib-mt6360-for-5.15-signed

for you to fetch changes up to 0402e8ebb8b869e375e8af7243044df21b5ff378:

  power: supply: mt6360_charger: add MT6360 charger support (2021-08-13 18:37:49 +0200)

----------------------------------------------------------------
Immutable branch between regulator and power-supply for for 5.15

This immutable branch introduces the MT6360 charger driver,
which requires a new linear range helper.

Signed-off-by: Sebastian Reichel <sre@kernel.org>

----------------------------------------------------------------
Gene Chen (3):
      lib: add linear range get selector within
      dt-bindings: power: Add bindings document for Charger support on MT6360 PMIC
      power: supply: mt6360_charger: add MT6360 charger support

 .../bindings/power/supply/mt6360_charger.yaml      |  48 ++
 drivers/power/supply/Kconfig                       |  11 +
 drivers/power/supply/Makefile                      |   1 +
 drivers/power/supply/mt6360_charger.c              | 867 +++++++++++++++++++++
 include/linux/linear_range.h                       |   2 +
 lib/linear_ranges.c                                |  31 +
 6 files changed, 960 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml
 create mode 100644 drivers/power/supply/mt6360_charger.c
Mark Brown Aug. 13, 2021, 5:25 p.m. UTC | #6
On Fri, Aug 13, 2021 at 07:11:06PM +0200, Sebastian Reichel wrote:
> On Fri, Aug 13, 2021 at 05:32:54PM +0100, Mark Brown wrote:

> > It would be better, the issues I'm worrying about are more general
> > refactorings or whatever that create actual dependencies rather than
> > just trivial add/add type issues - it can make doing some kinds of work
> > really painful if things go via a different tree.

> There you go:

Thanks!
Vaittinen, Matti Aug. 16, 2021, 5:12 a.m. UTC | #7
On Fri, 2021-08-13 at 19:11 +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Fri, Aug 13, 2021 at 05:32:54PM +0100, Mark Brown wrote:
> > On Fri, Aug 13, 2021 at 06:20:29PM +0200, Sebastian Reichel wrote:
> > > On Fri, Aug 13, 2021 at 04:58:58PM +0100, Mark Brown wrote:
> > > > We're still waiting for review from Matti on the linear ranges
> > > > bit -
> > > > normally that goes through the regulator tree, do you have a
> > > > tag to pull
> > > > in case of merge conflicts?
> > > He actually already provided his Rb in v5, Gene did not carry it
> > > over properly (I added it)

Thanks guys! I do _really_ appreciate you taking care of merging the
changes :)

Best Regards
	--Matti