[v3,0/8] ASoC: Intel: boards: use software node API

Message

Pierre-Louis Bossart Aug. 13, 2021, 3:11 p.m. UTC

This is an update on an earlier contribution from Heikki Krogerus

The function device_add_properties() is going to be removed.
Replacing it with software node API equivalents.

Thanks for Hans de Goede and Andy Shevchenko for their comments,
suggestions and Reviewed-by tags on GitHub. The review thread can be
found at https://github.com/thesofproject/linux/pull/3041)

v3 changes:
Fixed nit-picks from Andy: label, return value, missing commas/periods.
Added Andy's Reviewed-by tag

v2 changes: feedback from Andy and Hans
Better error handling
Codec reference is kept until the .remove callback
Remove bus search to find device

v1 changes from Heikki's patches:
Avoid the use of devm_ routines for Baytrail machine drivers.

Heikki Krogerus (1):
  ASoC: Intel: boards: use software node API in Atom boards

Pierre-Louis Bossart (7):
  ASoC: Intel: boards: harden codec property handling
  ASoC: Intel: boards: handle errors with acpi_dev_get_first_match_dev()
  ASoC: Intel: boards: get codec device with ACPI instead of bus search
  ASoC: Intel: sof_sdw: pass card information to init/exit functions
  ASoC: Intel: sof_sdw_rt711*: keep codec device reference until remove
  ASoC: Intel: use software node API in SoundWire machines
  ASoC: Intel: remove device_properties for Atom boards

 sound/soc/intel/boards/bytcht_es8316.c      | 31 ++++++++--
 sound/soc/intel/boards/bytcr_rt5640.c       | 60 +++++++++++++++-----
 sound/soc/intel/boards/bytcr_rt5651.c       | 63 ++++++++++++++-------
 sound/soc/intel/boards/sof_sdw.c            | 20 ++++---
 sound/soc/intel/boards/sof_sdw_common.h     | 37 +++++++-----
 sound/soc/intel/boards/sof_sdw_max98373.c   |  3 +-
 sound/soc/intel/boards/sof_sdw_rt1308.c     |  3 +-
 sound/soc/intel/boards/sof_sdw_rt1316.c     |  3 +-
 sound/soc/intel/boards/sof_sdw_rt5682.c     |  3 +-
 sound/soc/intel/boards/sof_sdw_rt700.c      |  3 +-
 sound/soc/intel/boards/sof_sdw_rt711.c      | 51 +++++++++--------
 sound/soc/intel/boards/sof_sdw_rt711_sdca.c | 52 +++++++++--------
 sound/soc/intel/boards/sof_sdw_rt715.c      |  3 +-
 sound/soc/intel/boards/sof_sdw_rt715_sdca.c |  3 +-
 14 files changed, 223 insertions(+), 112 deletions(-)

Comments

Mark Brown Aug. 13, 2021, 5:26 p.m. UTC | #1

On Fri, 13 Aug 2021 10:11:08 -0500, Pierre-Louis Bossart wrote:
> This is an update on an earlier contribution from Heikki Krogerus
> 
> The function device_add_properties() is going to be removed.
> Replacing it with software node API equivalents.
> 
> Thanks for Hans de Goede and Andy Shevchenko for their comments,
> suggestions and Reviewed-by tags on GitHub. The review thread can be
> found at https://github.com/thesofproject/linux/pull/3041)
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/8] ASoC: Intel: boards: harden codec property handling
      commit: c50f126b3c9ebb77585838726a3a490ad33b92cd
[2/8] ASoC: Intel: boards: handle errors with acpi_dev_get_first_match_dev()
      commit: 69efe3b834c0803d170ec8957021543963868e63
[3/8] ASoC: Intel: boards: get codec device with ACPI instead of bus search
      commit: d3409eb20d3ed7d9e021cd13243e9e63255a315f
[4/8] ASoC: Intel: sof_sdw: pass card information to init/exit functions
      commit: cdf99c9ab72161885d8670723a21699a384a5dbe
[5/8] ASoC: Intel: sof_sdw_rt711*: keep codec device reference until remove
      commit: 82027585fce0c5e78e666cfbd0066fe3c80070dd
[6/8] ASoC: Intel: use software node API in SoundWire machines
      commit: e5a292d39466ca1f45e185be713616f9389e6a4e
[7/8] ASoC: Intel: remove device_properties for Atom boards
      commit: f1f8a9615451ec3762a45b6985e072c44a995a45
[8/8] ASoC: Intel: boards: use software node API in Atom boards
      commit: 0bd3c071e6e7e140c8b39caab99b3b6f05cb5290

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Cezary Rojewski Aug. 16, 2021, 3:08 p.m. UTC | #2

On 2021-08-13 5:11 PM, Pierre-Louis Bossart wrote:
> This is an update on an earlier contribution from Heikki Krogerus
> 
> The function device_add_properties() is going to be removed.
> Replacing it with software node API equivalents.
> 
> Thanks for Hans de Goede and Andy Shevchenko for their comments,
> suggestions and Reviewed-by tags on GitHub. The review thread can be
> found at https://github.com/thesofproject/linux/pull/3041)
> 
> v3 changes:
> Fixed nit-picks from Andy: label, return value, missing commas/periods.
> Added Andy's Reviewed-by tag
> 
> v2 changes: feedback from Andy and Hans
> Better error handling
> Codec reference is kept until the .remove callback
> Remove bus search to find device
> 
> v1 changes from Heikki's patches:
> Avoid the use of devm_ routines for Baytrail machine drivers.

While sof_sdw_* machine boards history shows these have been updated 
concurrently, the same cannot be said for other, older Intel boards. And 
thus, I'd advise to separate changes for each older board, here: 
bytcht_es8316, bytcr_rt5640 and bytcr_rt5651. You could even squash 
smaller changes so the number of patches isn't getting out of control.

If regression occurs in just one of them - even due to spelling error or 
unintended code line - revert will impact all the boards. In the past 
having separate patches for kbl_*, bdw_* and such saved a lot of 
trouble, especially given their history.

This is more of an suggestion than a blocker. Haven't found any code issues:

Reviewed-by: Cezary Rojewski <[e-mail]>

Regards,
Czarek