| Message ID | 20210814181107.138992-1-mail@david-bauer.net (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/2] dt-bindings: net: add RTL8152 binding documentation | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On 14.08.2021 20:11, David Bauer wrote: > Add binding documentation for the Realtek RTL8152 / RTL8153 USB ethernet > adapters. > > Signed-off-by: David Bauer <mail@david-bauer.net> > --- > .../bindings/net/realtek,rtl8152.yaml | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl8152.yaml > > diff --git a/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml b/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml > new file mode 100644 > index 000000000000..ab760000b3a6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/realtek,rtl8152.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Realtek RTL8152/RTL8153 series USB ethernet > + > +maintainers: > + - David Bauer <mail@david-bauer.net> > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - realtek,rtl8152 > + - realtek,rtl8153 > + > + reg: > + description: The device number on the USB bus > + > + realtek,led-data: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Value to be written to the LED configuration register. > + +Pavel as LED subsystem maintainer There's an ongoing discussion (with certain decisions taken already) about how to configure network device LEDs. > +required: > + - compatible > + - reg > + > +examples: > + - | > + usb@100 { > + reg = <0x100 0x100>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + usb-eth@2 { > + compatible = "realtek,rtl8153"; > + reg = <0x2>; > + realtek,led-data = <0x87>; > + }; > + }; >
Hi Heiner, On 8/14/21 8:33 PM, Heiner Kallweit wrote: > On 14.08.2021 20:11, David Bauer wrote: >> Add binding documentation for the Realtek RTL8152 / RTL8153 USB ethernet >> adapters. >> >> Signed-off-by: David Bauer <mail@david-bauer.net> >> --- >> .../bindings/net/realtek,rtl8152.yaml | 43 +++++++++++++++++++ >> 1 file changed, 43 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl8152.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml b/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml >> new file mode 100644 >> index 000000000000..ab760000b3a6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml >> @@ -0,0 +1,43 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/realtek,rtl8152.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Realtek RTL8152/RTL8153 series USB ethernet >> + >> +maintainers: >> + - David Bauer <mail@david-bauer.net> >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - enum: >> + - realtek,rtl8152 >> + - realtek,rtl8153 >> + >> + reg: >> + description: The device number on the USB bus >> + >> + realtek,led-data: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: Value to be written to the LED configuration register. >> + > > +Pavel as LED subsystem maintainer > > There's an ongoing discussion (with certain decisions taken already) about > how to configure network device LEDs. Thanks, I didn't knew about this. Is there any place where i can read up specifics about this topic? Best David > >> +required: >> + - compatible >> + - reg >> + >> +examples: >> + - | >> + usb@100 { >> + reg = <0x100 0x100>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + usb-eth@2 { >> + compatible = "realtek,rtl8153"; >> + reg = <0x2>; >> + realtek,led-data = <0x87>; >> + }; >> + }; >> >
On 15.08.2021 00:26, David Bauer wrote: > Hi Heiner, > > On 8/14/21 8:33 PM, Heiner Kallweit wrote: >> On 14.08.2021 20:11, David Bauer wrote: >>> Add binding documentation for the Realtek RTL8152 / RTL8153 USB ethernet >>> adapters. >>> >>> Signed-off-by: David Bauer <mail@david-bauer.net> >>> --- >>> .../bindings/net/realtek,rtl8152.yaml | 43 +++++++++++++++++++ >>> 1 file changed, 43 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl8152.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml b/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml >>> new file mode 100644 >>> index 000000000000..ab760000b3a6 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml >>> @@ -0,0 +1,43 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/net/realtek,rtl8152.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Realtek RTL8152/RTL8153 series USB ethernet >>> + >>> +maintainers: >>> + - David Bauer <mail@david-bauer.net> >>> + >>> +properties: >>> + compatible: >>> + oneOf: >>> + - items: >>> + - enum: >>> + - realtek,rtl8152 >>> + - realtek,rtl8153 >>> + >>> + reg: >>> + description: The device number on the USB bus >>> + >>> + realtek,led-data: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + description: Value to be written to the LED configuration register. >>> + >> >> +Pavel as LED subsystem maintainer >> >> There's an ongoing discussion (with certain decisions taken already) about >> how to configure network device LEDs. > > Thanks, I didn't knew about this. > > Is there any place where i can read up specifics about > this topic? > A recent mail thread about network device LEDs is here: https://lore.kernel.org/netdev/20210716212427.821834-6-anthony.l.nguyen@intel.com/ To cut a long story short: LED subsystem maintainer has ideas how a unified solution could like, and he has some work-in-progress patches. And some statements exist how not to do it and what to avoid. But there's still some open issues, therefore no solution is available yet. It's not really clear how to go on with network device LED support in the meantime. > Best > David > Heiner >> >>> +required: >>> + - compatible >>> + - reg >>> + >>> +examples: >>> + - | >>> + usb@100 { >>> + reg = <0x100 0x100>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + usb-eth@2 { >>> + compatible = "realtek,rtl8153"; >>> + reg = <0x2>; >>> + realtek,led-data = <0x87>; >>> + }; >>> + }; >>> >>
On Sat, 14 Aug 2021 20:11:06 +0200, David Bauer wrote: > Add binding documentation for the Realtek RTL8152 / RTL8153 USB ethernet > adapters. > > Signed-off-by: David Bauer <mail@david-bauer.net> > --- > .../bindings/net/realtek,rtl8152.yaml | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl8152.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml: 'additionalProperties' is a required property hint: A schema without a "$ref" to another schema must define all properties and use "additionalProperties" from schema $id: http://devicetree.org/meta-schemas/base.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/net/realtek,rtl8152.yaml Documentation/devicetree/bindings/net/realtek,rtl8152.example.dt.yaml:0:0: /example-0/usb@100/usb-eth@2: failed to match any schema with compatible: ['realtek,rtl8153'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1516862 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml b/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml new file mode 100644 index 000000000000..ab760000b3a6 --- /dev/null +++ b/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml @@ -0,0 +1,43 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/realtek,rtl8152.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Realtek RTL8152/RTL8153 series USB ethernet + +maintainers: + - David Bauer <mail@david-bauer.net> + +properties: + compatible: + oneOf: + - items: + - enum: + - realtek,rtl8152 + - realtek,rtl8153 + + reg: + description: The device number on the USB bus + + realtek,led-data: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Value to be written to the LED configuration register. + +required: + - compatible + - reg + +examples: + - | + usb@100 { + reg = <0x100 0x100>; + #address-cells = <1>; + #size-cells = <0>; + + usb-eth@2 { + compatible = "realtek,rtl8153"; + reg = <0x2>; + realtek,led-data = <0x87>; + }; + };
Add binding documentation for the Realtek RTL8152 / RTL8153 USB ethernet adapters. Signed-off-by: David Bauer <mail@david-bauer.net> --- .../bindings/net/realtek,rtl8152.yaml | 43 +++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl8152.yaml