| Message ID | 44f3b21198dd1e40e1e5e783db2b3dd76505b562.1628972198.git.aakashhemadri123@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: ti: Use of_device_get_match_data | expand |
On 14/08/2021 23:19, Aakash Hemadri wrote: > Prefer `of_device_get_match_data` over `of_match_device` > > Retrieve OF match data using `of_device_get_match_data`, this is cleaner > and better expresses intent. > > Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com> > --- > sound/soc/ti/omap-mcbsp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/ti/omap-mcbsp.c b/sound/soc/ti/omap-mcbsp.c > index 4479d74f0a45..fcb651487854 100644 > --- a/sound/soc/ti/omap-mcbsp.c > +++ b/sound/soc/ti/omap-mcbsp.c > @@ -1373,7 +1373,7 @@ static int asoc_mcbsp_probe(struct platform_device *pdev) > const struct of_device_id *match; > int ret; > > - match = of_match_device(omap_mcbsp_of_match, &pdev->dev); > + match = of_device_get_match_data(&pdev->dev); Similarly incorrect, of_device_get_match_data() is retrieving the match->data > if (match) { > struct device_node *node = pdev->dev.of_node; > struct omap_mcbsp_platform_data *pdata_quirk = pdata; >
diff --git a/sound/soc/ti/omap-mcbsp.c b/sound/soc/ti/omap-mcbsp.c index 4479d74f0a45..fcb651487854 100644 --- a/sound/soc/ti/omap-mcbsp.c +++ b/sound/soc/ti/omap-mcbsp.c @@ -1373,7 +1373,7 @@ static int asoc_mcbsp_probe(struct platform_device *pdev) const struct of_device_id *match; int ret; - match = of_match_device(omap_mcbsp_of_match, &pdev->dev); + match = of_device_get_match_data(&pdev->dev); if (match) { struct device_node *node = pdev->dev.of_node; struct omap_mcbsp_platform_data *pdata_quirk = pdata;
Prefer `of_device_get_match_data` over `of_match_device` Retrieve OF match data using `of_device_get_match_data`, this is cleaner and better expresses intent. Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com> --- sound/soc/ti/omap-mcbsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)