mbox series

[0/2] mpt3sas: Use Firmware Recommended Queue Depth.

Message ID 20210809072639.21228-1-suganath-prabu.subramani@broadcom.com (mailing list archive)
Headers show
Series mpt3sas: Use Firmware Recommended Queue Depth. | expand

Message

Suganath Prabu S Aug. 9, 2021, 7:26 a.m. UTC 
Currently mpt3sas driver sets below predefined queue depth for the
SAS/SATA/NVMe drives. 
SAS	-  254
SATA	-  32
NVME	-  128
IOC Firmware provides the queue depth for each device types through SAS
IO Unit Page1 for SAS/SATA and PCIe IO Unit Page1 for NVMe devices. If
the host sets the queue depth greater than the firmware recommended
queue depth, then IOC places the IO’s above the recommended queue depth
in an internal pending queue (consuming outstanding
host-credit/resources and thereby leading to potential starvation to
other devices) and sends them to the device once IO count drops below
the recommended queue depth. So, it is better for the driver to set
the device queue depth provided by the IOC firmware.

Suganath Prabu S (2):
  mpt3sas: Use FW recommended device QD
  mpt3sas: Update driver version to 39.100.00.00

 drivers/scsi/mpt3sas/mpt3sas_base.c   | 70 +++++++++++++++++++++++++++
 drivers/scsi/mpt3sas/mpt3sas_base.h   | 12 ++++-
 drivers/scsi/mpt3sas/mpt3sas_config.c | 37 ++++++++++++++
 drivers/scsi/mpt3sas/mpt3sas_ctl.c    |  5 +-
 drivers/scsi/mpt3sas/mpt3sas_scsih.c  | 51 +++++++++++++++++--
 5 files changed, 167 insertions(+), 8 deletions(-)

Comments

Martin K. Petersen Aug. 10, 2021, 3:12 a.m. UTC | #1 
Suganath,

> Currently mpt3sas driver sets below predefined queue depth for the
> SAS/SATA/NVMe drives. 
> SAS	-  254
> SATA	-  32
> NVME	-  128

Applied to 5.15/scsi-staging, thanks!
Martin K. Petersen Aug. 17, 2021, 3:20 a.m. UTC | #2 
On Mon, 9 Aug 2021 12:56:37 +0530, Suganath Prabu S wrote:

> Currently mpt3sas driver sets below predefined queue depth for the
> SAS/SATA/NVMe drives.
> SAS	-  254
> SATA	-  32
> NVME	-  128
> IOC Firmware provides the queue depth for each device types through SAS
> IO Unit Page1 for SAS/SATA and PCIe IO Unit Page1 for NVMe devices. If
> the host sets the queue depth greater than the firmware recommended
> queue depth, then IOC places the IO’s above the recommended queue depth
> in an internal pending queue (consuming outstanding
> host-credit/resources and thereby leading to potential starvation to
> other devices) and sends them to the device once IO count drops below
> the recommended queue depth. So, it is better for the driver to set
> the device queue depth provided by the IOC firmware.
> 
> [...]

Applied to 5.15/scsi-queue, thanks!

[1/2] mpt3sas: Use FW recommended device QD
      https://git.kernel.org/mkp/scsi/c/787f2448c236
[2/2] mpt3sas: Update driver version to 39.100.00.00
      https://git.kernel.org/mkp/scsi/c/cdc1767698a2