diff mbox series

[v2,1/2] dt-bindings: add bindings for the Sharp LS060T1SX01 panel

Message ID 20210809184712.203791-2-dmitry.baryshkov@linaro.org (mailing list archive)
State Superseded
Headers show
Series Add support for Sharp LS060T1SX01 panel | expand

Commit Message

Dmitry Baryshkov Aug. 9, 2021, 6:47 p.m. UTC
Add devicetree bindings for the Sharp LS060T1SX01 6.0" FullHD panel
using NT35695 driver. This panel can be found i.e. in the Dragonboard
Display Adapter bundle.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../display/panel/sharp,ls060t1sx01.yaml      | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml

Comments

Rob Herring Aug. 17, 2021, 6:53 p.m. UTC | #1
On Mon, Aug 09, 2021 at 09:47:11PM +0300, Dmitry Baryshkov wrote:
> Add devicetree bindings for the Sharp LS060T1SX01 6.0" FullHD panel
> using NT35695 driver. This panel can be found i.e. in the Dragonboard
> Display Adapter bundle.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../display/panel/sharp,ls060t1sx01.yaml      | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml b/Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml
> new file mode 100644
> index 000000000000..c4af5e7f6f39
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/sharp,ls060t1sx01.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sharp Microelectronics 6.0" FullHD TFT LCD panel
> +
> +maintainers:
> +  - Dmitry Baryskov <dmitry.baryshkov@linaro.org>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: sharp,ls060t1sx01
> +
> +  reg: true
> +  backlight: true
> +  reset-gpios: true
> +  port: true
> +
> +  avdd-supply:
> +    description: handle of the regulator that provides the supply voltage

Single supply? Use simple-panel binding. Or are your supplies 
incomplete?

> +
> +required:
> +  - compatible
> +  - reg
> +  - avdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "sharp,ls060t1sx01";
> +            reg = <0>;
> +            avdd-supply = <&pm8941_l22>;
> +            backlight = <&backlight>;
> +            reset-gpios = <&pm8916_gpios 25 GPIO_ACTIVE_LOW>;
> +        };
> +    };
> +
> +...
> -- 
> 2.30.2
> 
>
Dmitry Baryshkov Aug. 18, 2021, 4:35 p.m. UTC | #2
Hi,

On Tue, 17 Aug 2021 at 21:53, Rob Herring <robh@kernel.org> wrote:
>
> On Mon, Aug 09, 2021 at 09:47:11PM +0300, Dmitry Baryshkov wrote:
> > Add devicetree bindings for the Sharp LS060T1SX01 6.0" FullHD panel
> > using NT35695 driver. This panel can be found i.e. in the Dragonboard
> > Display Adapter bundle.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> >  .../display/panel/sharp,ls060t1sx01.yaml      | 51 +++++++++++++++++++
> >  1 file changed, 51 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml b/Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml
> > new file mode 100644
> > index 000000000000..c4af5e7f6f39
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml
> > @@ -0,0 +1,51 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/sharp,ls060t1sx01.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sharp Microelectronics 6.0" FullHD TFT LCD panel
> > +
> > +maintainers:
> > +  - Dmitry Baryskov <dmitry.baryshkov@linaro.org>
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: sharp,ls060t1sx01
> > +
> > +  reg: true
> > +  backlight: true
> > +  reset-gpios: true
> > +  port: true
> > +
> > +  avdd-supply:
> > +    description: handle of the regulator that provides the supply voltage
>
> Single supply? Use simple-panel binding. Or are your supplies
> incomplete?

True. I'll extend them in v2 according to the datasheet.

>
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - avdd-supply
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    dsi {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        panel@0 {
> > +            compatible = "sharp,ls060t1sx01";
> > +            reg = <0>;
> > +            avdd-supply = <&pm8941_l22>;
> > +            backlight = <&backlight>;
> > +            reset-gpios = <&pm8916_gpios 25 GPIO_ACTIVE_LOW>;
> > +        };
> > +    };
> > +
> > +...
> > --
> > 2.30.2
> >
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml b/Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml
new file mode 100644
index 000000000000..c4af5e7f6f39
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml
@@ -0,0 +1,51 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/sharp,ls060t1sx01.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sharp Microelectronics 6.0" FullHD TFT LCD panel
+
+maintainers:
+  - Dmitry Baryskov <dmitry.baryshkov@linaro.org>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: sharp,ls060t1sx01
+
+  reg: true
+  backlight: true
+  reset-gpios: true
+  port: true
+
+  avdd-supply:
+    description: handle of the regulator that provides the supply voltage
+
+required:
+  - compatible
+  - reg
+  - avdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        panel@0 {
+            compatible = "sharp,ls060t1sx01";
+            reg = <0>;
+            avdd-supply = <&pm8941_l22>;
+            backlight = <&backlight>;
+            reset-gpios = <&pm8916_gpios 25 GPIO_ACTIVE_LOW>;
+        };
+    };
+
+...