| Message ID | 20210818111139.330636-7-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Bring software triggers support to MAX1027-like ADCs | expand |
> -----Original Message----- > From: Miquel Raynal <miquel.raynal@bootlin.com> > Sent: Wednesday, August 18, 2021 1:11 PM > To: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen > <lars@metafoo.de> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>; linux- > iio@vger.kernel.org; linux-kernel@vger.kernel.org; Miquel Raynal > <miquel.raynal@bootlin.com> > Subject: [PATCH 06/16] iio: adc: max1027: Rename a helper > > [External] > > Make it clear that the *_set_trigger_state() hook is responsible for > cnvst based conversions by renaming the helper. This may avoid > confusions with software trigger support that is going to be > introduced. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/iio/adc/max1027.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c > index ac603b4ca787..a6ebc951c09a 100644 > --- a/drivers/iio/adc/max1027.c > +++ b/drivers/iio/adc/max1027.c > @@ -354,7 +354,7 @@ static int max1027_validate_trigger(struct > iio_dev *indio_dev, > return 0; > } > > -static int max1027_set_trigger_state(struct iio_trigger *trig, bool > state) > +static int max1027_set_cnvst_trigger_state(struct iio_trigger *trig, > bool state) > { > struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig); > struct max1027_state *st = iio_priv(indio_dev); > @@ -423,7 +423,7 @@ static irqreturn_t max1027_trigger_handler(int > irq, void *private) > > static const struct iio_trigger_ops max1027_trigger_ops = { > .validate_device = &iio_trigger_validate_own_device, > - .set_trigger_state = &max1027_set_trigger_state, > + .set_trigger_state = &max1027_set_cnvst_trigger_state, > }; > > static const struct iio_info max1027_info = { > -- > 2.27.0 Reviewed-by: Nuno Sá <nuno.sa@analog.com>
diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c index ac603b4ca787..a6ebc951c09a 100644 --- a/drivers/iio/adc/max1027.c +++ b/drivers/iio/adc/max1027.c @@ -354,7 +354,7 @@ static int max1027_validate_trigger(struct iio_dev *indio_dev, return 0; } -static int max1027_set_trigger_state(struct iio_trigger *trig, bool state) +static int max1027_set_cnvst_trigger_state(struct iio_trigger *trig, bool state) { struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig); struct max1027_state *st = iio_priv(indio_dev); @@ -423,7 +423,7 @@ static irqreturn_t max1027_trigger_handler(int irq, void *private) static const struct iio_trigger_ops max1027_trigger_ops = { .validate_device = &iio_trigger_validate_own_device, - .set_trigger_state = &max1027_set_trigger_state, + .set_trigger_state = &max1027_set_cnvst_trigger_state, }; static const struct iio_info max1027_info = {
Make it clear that the *_set_trigger_state() hook is responsible for cnvst based conversions by renaming the helper. This may avoid confusions with software trigger support that is going to be introduced. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/iio/adc/max1027.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)