| Message ID | 20210820070113.45191-3-yangcong5@huaqin.corp-partner.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail | expand |
Hi, On Fri, Aug 20, 2021 at 12:01 AM yangcong <yangcong5@huaqin.corp-partner.google.com> wrote: > > The auo,b101uan08.3 panel (already supported by this driver) has > a 3.3V rail that needs to be turned on. For previous users of > this panel this voltage was directly output by pmic. On a new > user (the not-yet-upstream sc7180-trogdor-mrbland board) we need > to turn the 3.3V rail on. > > Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com> > --- > .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 3 +++ > 1 file changed, 3 insertions(+) However you're sending your patches is really confusing my email client. I think part of the problem is that you sent "v2" as "In-Reply-To" your "v1". You shouldn't do that. You also seem to be sending duplicates. :( Might I suggest using "patman" to simplify things for you? https://source.denx.de/u-boot/u-boot/blob/master/tools/patman/README > diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml > index 38bc1d1b511e..a7091ae0f791 100644 > --- a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml > +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml > @@ -36,6 +36,9 @@ properties: > pp1800-supply: > description: core voltage supply > > + pp3300-supply: > + description: core voltage supply This would probably be slightly better if it said "3.3 V supply" instead of "core voltage supply", but it doesn't matter a ton to me. Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Fri, 20 Aug 2021 15:01:13 +0800, yangcong wrote: > The auo,b101uan08.3 panel (already supported by this driver) has > a 3.3V rail that needs to be turned on. For previous users of > this panel this voltage was directly output by pmic. On a new > user (the not-yet-upstream sc7180-trogdor-mrbland board) we need > to turn the 3.3V rail on. > > Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com> > --- > .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml index 38bc1d1b511e..a7091ae0f791 100644 --- a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml @@ -36,6 +36,9 @@ properties: pp1800-supply: description: core voltage supply + pp3300-supply: + description: core voltage supply + avdd-supply: description: phandle of the regulator that provides positive voltage
The auo,b101uan08.3 panel (already supported by this driver) has a 3.3V rail that needs to be turned on. For previous users of this panel this voltage was directly output by pmic. On a new user (the not-yet-upstream sc7180-trogdor-mrbland board) we need to turn the 3.3V rail on. Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com> --- .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 3 +++ 1 file changed, 3 insertions(+)