| Message ID | 20210819173831.23515-1-niteesh.gs@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | AQMP TUI Draft | expand |
On Thu, Aug 19, 2021 at 1:39 PM G S Niteesh Babu <niteesh.gs@gmail.com> wrote: > Hello all, > > Gitlab: https://gitlab.com/niteesh.gs/qemu/-/commits/aqmp-tui-prototype-v4 > CI: https://gitlab.com/niteesh.gs/qemu/-/pipelines/356024270 > > Revision since v3: > 1) Added docstrings > 2) Minor changes in AQMP TUI Draft > 3) Switched to constant retry delay in QMP connection manager and other > minor changes. > > G S Niteesh Babu (7): > python: disable pylint errors for aqmp-tui > python: Add dependencies for AQMP TUI > python/aqmp-tui: Add AQMP TUI draft > python: Add entry point for aqmp-tui > python: add optional pygments dependency > python/aqmp-tui: Add syntax highlighting > python/aqmp-tui: Add QMP connection manager > > python/Pipfile.lock | 20 + > python/qemu/aqmp/aqmp_tui.py | 681 +++++++++++++++++++++++++++++++++++ > python/setup.cfg | 29 +- > 3 files changed, 729 insertions(+), 1 deletion(-) > create mode 100644 python/qemu/aqmp/aqmp_tui.py > > -- > 2.17.1 > > Hiya, please specify what your branch is based on when you submit your patchsets using the Based-On tag. - It's time to drop patch #1 entirely. - We can drop the word 'draft' from the commit messages now, let's try to make this solid. - If you want to keep the TODO comments in the code, add a pylint configuration item that allows "todo" but disallows "fixme" and "xxx" comments. Detailed review to follow tomorrow, but you can start working on these items right away. I might also squash patch #7 directly into patch #3, but haven't looked too closely yet. (Note that due to an update to pylint that happened just today, check-tox is going to fail now -- that's fine, it's not your fault. As long as check-pipenv works, you're in good shape. I'll have a fix in my python branch tomorrow for these problems.)
On Sat, Aug 21, 2021 at 9:39 AM John Snow <jsnow@redhat.com> wrote: > > > On Thu, Aug 19, 2021 at 1:39 PM G S Niteesh Babu <niteesh.gs@gmail.com> > wrote: > >> Hello all, >> >> Gitlab: >> https://gitlab.com/niteesh.gs/qemu/-/commits/aqmp-tui-prototype-v4 >> CI: https://gitlab.com/niteesh.gs/qemu/-/pipelines/356024270 >> >> Revision since v3: >> 1) Added docstrings >> 2) Minor changes in AQMP TUI Draft >> 3) Switched to constant retry delay in QMP connection manager and other >> minor changes. >> >> G S Niteesh Babu (7): >> python: disable pylint errors for aqmp-tui >> python: Add dependencies for AQMP TUI >> python/aqmp-tui: Add AQMP TUI draft >> python: Add entry point for aqmp-tui >> python: add optional pygments dependency >> python/aqmp-tui: Add syntax highlighting >> python/aqmp-tui: Add QMP connection manager >> >> python/Pipfile.lock | 20 + >> python/qemu/aqmp/aqmp_tui.py | 681 +++++++++++++++++++++++++++++++++++ >> python/setup.cfg | 29 +- >> 3 files changed, 729 insertions(+), 1 deletion(-) >> create mode 100644 python/qemu/aqmp/aqmp_tui.py >> >> -- >> 2.17.1 >> >> > Hiya, please specify what your branch is based on when you submit your > patchsets using the Based-On tag. > Oops sorry, I'll make sure to add it in the next revision. > > - It's time to drop patch #1 entirely. > - We can drop the word 'draft' from the commit messages now, let's try to > make this solid. > - If you want to keep the TODO comments in the code, add a pylint > configuration item that allows "todo" but disallows "fixme" and "xxx" > comments. > > Detailed review to follow tomorrow, but you can start working on these > items right away. I might also squash patch #7 directly into patch #3, but > haven't looked too closely yet. > I have addressed all your above comments in this branch https://gitlab.com/niteesh.gs/qemu/-/commits/aqmp-tui-prototype-v5 except squashing of patches #3 and #7. Will do it once you review patch #7. > > (Note that due to an update to pylint that happened just today, check-tox > is going to fail now -- that's fine, it's not your fault. As long as > check-pipenv works, you're in good shape. I'll have a fix in my python > branch tomorrow for these problems.) >