| Message ID | 20210823141033.17876-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | can: mscan: mpc5xxx_can: Remove useless BUG_ON() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Series ignored based on subject |
On 23.08.2021 22:10:33, Tang Bin wrote: > In the function mpc5xxx_can_probe(), the variale 'data' ^b Fixed typo while applying. > has already been determined in the above code, so the > BUG_ON() in this place is useless, remove it. > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > --- > drivers/net/can/mscan/mpc5xxx_can.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c > index 3b7465acd..35892c1ef 100644 > --- a/drivers/net/can/mscan/mpc5xxx_can.c > +++ b/drivers/net/can/mscan/mpc5xxx_can.c > @@ -317,7 +317,6 @@ static int mpc5xxx_can_probe(struct platform_device *ofdev) > > clock_name = of_get_property(np, "fsl,mscan-clock-source", NULL); > > - BUG_ON(!data); > priv->type = data->type; > priv->can.clock.freq = data->get_clock(ofdev, clock_name, > &mscan_clksrc); Thanks, Marc
diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c index 3b7465acd..35892c1ef 100644 --- a/drivers/net/can/mscan/mpc5xxx_can.c +++ b/drivers/net/can/mscan/mpc5xxx_can.c @@ -317,7 +317,6 @@ static int mpc5xxx_can_probe(struct platform_device *ofdev) clock_name = of_get_property(np, "fsl,mscan-clock-source", NULL); - BUG_ON(!data); priv->type = data->type; priv->can.clock.freq = data->get_clock(ofdev, clock_name, &mscan_clksrc);
In the function mpc5xxx_can_probe(), the variale 'data' has already been determined in the above code, so the BUG_ON() in this place is useless, remove it. Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- drivers/net/can/mscan/mpc5xxx_can.c | 1 - 1 file changed, 1 deletion(-)