| Message ID | 20210818111139.330636-5-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Bring software triggers support to MAX1027-like ADCs | expand |
> -----Original Message----- > From: Miquel Raynal <miquel.raynal@bootlin.com> > Sent: Wednesday, August 18, 2021 1:11 PM > To: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen > <lars@metafoo.de> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>; linux- > iio@vger.kernel.org; linux-kernel@vger.kernel.org; Miquel Raynal > <miquel.raynal@bootlin.com> > Subject: [PATCH 04/16] iio: adc: max1027: Lower conversion time > > [External] > > When only a few channels are requested, the core will request all of > them as long as ->available_scan_masks is present, thus reducing the > impact of any driver side optimization to avoid converting the > unneeded > channels. > > Do not share this bitmap with the core, which is optional anyway. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/iio/adc/max1027.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c > index 8ab660f596b5..d79dabf20567 100644 > --- a/drivers/iio/adc/max1027.c > +++ b/drivers/iio/adc/max1027.c > @@ -457,7 +457,6 @@ static int max1027_probe(struct spi_device > *spi) > indio_dev->modes = INDIO_DIRECT_MODE; > indio_dev->channels = st->info->channels; > indio_dev->num_channels = st->info->num_channels; > - indio_dev->available_scan_masks = st->info- > >available_scan_masks; > > st->buffer = devm_kmalloc_array(&indio_dev->dev, > indio_dev->num_channels, 2, > -- > 2.27.0 Reviewed-by: Nuno Sá <nuno.sa@analog.com>
On Wed, 18 Aug 2021 13:11:27 +0200 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > When only a few channels are requested, the core will request all of > them as long as ->available_scan_masks is present, thus reducing the > impact of any driver side optimization to avoid converting the unneeded > channels. > > Do not share this bitmap with the core, which is optional anyway. As mentioned in previous patch - do share it with the core, but update it to include the masks you now support. As a side note, you should have done this in previous patch anyway given that patch is effectively a noop with out it. (assuming it was a good thing to do at all which I'm not sure it is!) Jonathan > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/iio/adc/max1027.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c > index 8ab660f596b5..d79dabf20567 100644 > --- a/drivers/iio/adc/max1027.c > +++ b/drivers/iio/adc/max1027.c > @@ -457,7 +457,6 @@ static int max1027_probe(struct spi_device *spi) > indio_dev->modes = INDIO_DIRECT_MODE; > indio_dev->channels = st->info->channels; > indio_dev->num_channels = st->info->num_channels; > - indio_dev->available_scan_masks = st->info->available_scan_masks; > > st->buffer = devm_kmalloc_array(&indio_dev->dev, > indio_dev->num_channels, 2,
diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c index 8ab660f596b5..d79dabf20567 100644 --- a/drivers/iio/adc/max1027.c +++ b/drivers/iio/adc/max1027.c @@ -457,7 +457,6 @@ static int max1027_probe(struct spi_device *spi) indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->channels = st->info->channels; indio_dev->num_channels = st->info->num_channels; - indio_dev->available_scan_masks = st->info->available_scan_masks; st->buffer = devm_kmalloc_array(&indio_dev->dev, indio_dev->num_channels, 2,
When only a few channels are requested, the core will request all of them as long as ->available_scan_masks is present, thus reducing the impact of any driver side optimization to avoid converting the unneeded channels. Do not share this bitmap with the core, which is optional anyway. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/iio/adc/max1027.c | 1 - 1 file changed, 1 deletion(-)