mbox series

[rdma-next,v4,0/3] SG fix together with update to RDMA umem

Message ID 20210824142531.3877007-1-maorg@nvidia.com (mailing list archive)
Headers show
Series SG fix together with update to RDMA umem | expand

Message

Maor Gottlieb Aug. 24, 2021, 2:25 p.m. UTC
From: Maor Gottlieb <maorg@nvidia.com>

Changelog:
v4:
 * Unify sg_free_table_entries with __sg_free_table
v3: https://lore.kernel.org/lkml/cover.1627551226.git.leonro@nvidia.com/
 * Rewrote to new API suggestion
 * Split for more patches
v2: https://lore.kernel.org/lkml/cover.1626605893.git.leonro@nvidia.com
 * Changed implementation of first patch, based on our discussion with
 * Christoph.
   https://lore.kernel.org/lkml/YNwaVTT0qmQdxaZz@infradead.org/
v1: https://lore.kernel.org/lkml/cover.1624955710.git.leonro@nvidia.com/
 * Fixed sg_page with a _dma_ API in the umem.c
v0: https://lore.kernel.org/lkml/cover.1624361199.git.leonro@nvidia.com

Maor Gottlieb (3):
  lib/scatterlist: Provide a dedicated function to support table append
  lib/scatterlist: Fix wrong update of orig_nents
  RDMA: Use the sg_table directly and remove the opencoded version from
    umem

 drivers/gpu/drm/drm_prime.c                 |  13 +-
 drivers/gpu/drm/i915/gem/i915_gem_userptr.c |  11 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c  |  14 +-
 drivers/infiniband/core/umem.c              |  56 ++++---
 drivers/infiniband/core/umem_dmabuf.c       |   5 +-
 drivers/infiniband/hw/hns/hns_roce_db.c     |   4 +-
 drivers/infiniband/hw/irdma/verbs.c         |   2 +-
 drivers/infiniband/hw/mlx4/doorbell.c       |   3 +-
 drivers/infiniband/hw/mlx4/mr.c             |   4 +-
 drivers/infiniband/hw/mlx5/doorbell.c       |   3 +-
 drivers/infiniband/hw/mlx5/mr.c             |   3 +-
 drivers/infiniband/hw/qedr/verbs.c          |   2 +-
 drivers/infiniband/sw/rdmavt/mr.c           |   2 +-
 drivers/infiniband/sw/rxe/rxe_mr.c          |   2 +-
 include/linux/scatterlist.h                 |  56 +++++--
 include/rdma/ib_umem.h                      |  11 +-
 include/rdma/ib_verbs.h                     |  28 ++++
 lib/scatterlist.c                           | 155 ++++++++++++--------
 lib/sg_pool.c                               |   3 +-
 tools/testing/scatterlist/main.c            |  38 +++--
 20 files changed, 258 insertions(+), 157 deletions(-)

Comments

Leon Romanovsky Aug. 30, 2021, 8:21 a.m. UTC | #1
On Tue, Aug 24, 2021 at 05:25:28PM +0300, Maor Gottlieb wrote:
> From: Maor Gottlieb <maorg@nvidia.com>
> 
> Changelog:
> v4:
>  * Unify sg_free_table_entries with __sg_free_table
> v3: https://lore.kernel.org/lkml/cover.1627551226.git.leonro@nvidia.com/
>  * Rewrote to new API suggestion
>  * Split for more patches
> v2: https://lore.kernel.org/lkml/cover.1626605893.git.leonro@nvidia.com
>  * Changed implementation of first patch, based on our discussion with
>  * Christoph.
>    https://lore.kernel.org/lkml/YNwaVTT0qmQdxaZz@infradead.org/
> v1: https://lore.kernel.org/lkml/cover.1624955710.git.leonro@nvidia.com/
>  * Fixed sg_page with a _dma_ API in the umem.c
> v0: https://lore.kernel.org/lkml/cover.1624361199.git.leonro@nvidia.com
> 
> Maor Gottlieb (3):
>   lib/scatterlist: Provide a dedicated function to support table append
>   lib/scatterlist: Fix wrong update of orig_nents
>   RDMA: Use the sg_table directly and remove the opencoded version from
>     umem
> 
>  drivers/gpu/drm/drm_prime.c                 |  13 +-
>  drivers/gpu/drm/i915/gem/i915_gem_userptr.c |  11 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c  |  14 +-
>  drivers/infiniband/core/umem.c              |  56 ++++---
>  drivers/infiniband/core/umem_dmabuf.c       |   5 +-
>  drivers/infiniband/hw/hns/hns_roce_db.c     |   4 +-
>  drivers/infiniband/hw/irdma/verbs.c         |   2 +-
>  drivers/infiniband/hw/mlx4/doorbell.c       |   3 +-
>  drivers/infiniband/hw/mlx4/mr.c             |   4 +-
>  drivers/infiniband/hw/mlx5/doorbell.c       |   3 +-
>  drivers/infiniband/hw/mlx5/mr.c             |   3 +-
>  drivers/infiniband/hw/qedr/verbs.c          |   2 +-
>  drivers/infiniband/sw/rdmavt/mr.c           |   2 +-
>  drivers/infiniband/sw/rxe/rxe_mr.c          |   2 +-
>  include/linux/scatterlist.h                 |  56 +++++--
>  include/rdma/ib_umem.h                      |  11 +-
>  include/rdma/ib_verbs.h                     |  28 ++++
>  lib/scatterlist.c                           | 155 ++++++++++++--------
>  lib/sg_pool.c                               |   3 +-
>  tools/testing/scatterlist/main.c            |  38 +++--
>  20 files changed, 258 insertions(+), 157 deletions(-)

Jason,

Did you add these patches to the -next? I can't find them.

Thanks

> 
> -- 
> 2.25.4
>
Jason Gunthorpe Aug. 30, 2021, 1:31 p.m. UTC | #2
On Mon, Aug 30, 2021 at 11:21:00AM +0300, Leon Romanovsky wrote:
> On Tue, Aug 24, 2021 at 05:25:28PM +0300, Maor Gottlieb wrote:
> > From: Maor Gottlieb <maorg@nvidia.com>
> > 
> > Changelog:
> > v4:
> >  * Unify sg_free_table_entries with __sg_free_table
> > v3: https://lore.kernel.org/lkml/cover.1627551226.git.leonro@nvidia.com/
> >  * Rewrote to new API suggestion
> >  * Split for more patches
> > v2: https://lore.kernel.org/lkml/cover.1626605893.git.leonro@nvidia.com
> >  * Changed implementation of first patch, based on our discussion with
> >  * Christoph.
> >    https://lore.kernel.org/lkml/YNwaVTT0qmQdxaZz@infradead.org/
> > v1: https://lore.kernel.org/lkml/cover.1624955710.git.leonro@nvidia.com/
> >  * Fixed sg_page with a _dma_ API in the umem.c
> > v0: https://lore.kernel.org/lkml/cover.1624361199.git.leonro@nvidia.com
> > 
> > Maor Gottlieb (3):
> >   lib/scatterlist: Provide a dedicated function to support table append
> >   lib/scatterlist: Fix wrong update of orig_nents
> >   RDMA: Use the sg_table directly and remove the opencoded version from
> >     umem
> > 
> >  drivers/gpu/drm/drm_prime.c                 |  13 +-
> >  drivers/gpu/drm/i915/gem/i915_gem_userptr.c |  11 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c  |  14 +-
> >  drivers/infiniband/core/umem.c              |  56 ++++---
> >  drivers/infiniband/core/umem_dmabuf.c       |   5 +-
> >  drivers/infiniband/hw/hns/hns_roce_db.c     |   4 +-
> >  drivers/infiniband/hw/irdma/verbs.c         |   2 +-
> >  drivers/infiniband/hw/mlx4/doorbell.c       |   3 +-
> >  drivers/infiniband/hw/mlx4/mr.c             |   4 +-
> >  drivers/infiniband/hw/mlx5/doorbell.c       |   3 +-
> >  drivers/infiniband/hw/mlx5/mr.c             |   3 +-
> >  drivers/infiniband/hw/qedr/verbs.c          |   2 +-
> >  drivers/infiniband/sw/rdmavt/mr.c           |   2 +-
> >  drivers/infiniband/sw/rxe/rxe_mr.c          |   2 +-
> >  include/linux/scatterlist.h                 |  56 +++++--
> >  include/rdma/ib_umem.h                      |  11 +-
> >  include/rdma/ib_verbs.h                     |  28 ++++
> >  lib/scatterlist.c                           | 155 ++++++++++++--------
> >  lib/sg_pool.c                               |   3 +-
> >  tools/testing/scatterlist/main.c            |  38 +++--
> >  20 files changed, 258 insertions(+), 157 deletions(-)
> 
> Jason,
> 
> Did you add these patches to the -next? I can't find them.

They sat in linux-next for awhile outside the rdma-next tree

All synced up now

Jason
Leon Romanovsky Aug. 30, 2021, 1:42 p.m. UTC | #3
On Mon, Aug 30, 2021 at 10:31:28AM -0300, Jason Gunthorpe wrote:
> On Mon, Aug 30, 2021 at 11:21:00AM +0300, Leon Romanovsky wrote:
> > On Tue, Aug 24, 2021 at 05:25:28PM +0300, Maor Gottlieb wrote:
> > > From: Maor Gottlieb <maorg@nvidia.com>
> > > 
> > > Changelog:
> > > v4:
> > >  * Unify sg_free_table_entries with __sg_free_table
> > > v3: https://lore.kernel.org/lkml/cover.1627551226.git.leonro@nvidia.com/
> > >  * Rewrote to new API suggestion
> > >  * Split for more patches
> > > v2: https://lore.kernel.org/lkml/cover.1626605893.git.leonro@nvidia.com
> > >  * Changed implementation of first patch, based on our discussion with
> > >  * Christoph.
> > >    https://lore.kernel.org/lkml/YNwaVTT0qmQdxaZz@infradead.org/
> > > v1: https://lore.kernel.org/lkml/cover.1624955710.git.leonro@nvidia.com/
> > >  * Fixed sg_page with a _dma_ API in the umem.c
> > > v0: https://lore.kernel.org/lkml/cover.1624361199.git.leonro@nvidia.com
> > > 
> > > Maor Gottlieb (3):
> > >   lib/scatterlist: Provide a dedicated function to support table append
> > >   lib/scatterlist: Fix wrong update of orig_nents
> > >   RDMA: Use the sg_table directly and remove the opencoded version from
> > >     umem
> > > 
> > >  drivers/gpu/drm/drm_prime.c                 |  13 +-
> > >  drivers/gpu/drm/i915/gem/i915_gem_userptr.c |  11 +-
> > >  drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c  |  14 +-
> > >  drivers/infiniband/core/umem.c              |  56 ++++---
> > >  drivers/infiniband/core/umem_dmabuf.c       |   5 +-
> > >  drivers/infiniband/hw/hns/hns_roce_db.c     |   4 +-
> > >  drivers/infiniband/hw/irdma/verbs.c         |   2 +-
> > >  drivers/infiniband/hw/mlx4/doorbell.c       |   3 +-
> > >  drivers/infiniband/hw/mlx4/mr.c             |   4 +-
> > >  drivers/infiniband/hw/mlx5/doorbell.c       |   3 +-
> > >  drivers/infiniband/hw/mlx5/mr.c             |   3 +-
> > >  drivers/infiniband/hw/qedr/verbs.c          |   2 +-
> > >  drivers/infiniband/sw/rdmavt/mr.c           |   2 +-
> > >  drivers/infiniband/sw/rxe/rxe_mr.c          |   2 +-
> > >  include/linux/scatterlist.h                 |  56 +++++--
> > >  include/rdma/ib_umem.h                      |  11 +-
> > >  include/rdma/ib_verbs.h                     |  28 ++++
> > >  lib/scatterlist.c                           | 155 ++++++++++++--------
> > >  lib/sg_pool.c                               |   3 +-
> > >  tools/testing/scatterlist/main.c            |  38 +++--
> > >  20 files changed, 258 insertions(+), 157 deletions(-)
> > 
> > Jason,
> > 
> > Did you add these patches to the -next? I can't find them.
> 
> They sat in linux-next for awhile outside the rdma-next tree
> 
> All synced up now

Thanks

> 
> Jason