| Message ID | 20210831125843.1233488-2-nsaenzju@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] ARM: dts: bcm2711-rpi-4-b: Fix pcie0's unit address formatting | expand |
On Tue, Aug 31, 2021 at 7:59 AM Nicolas Saenz Julienne <nsaenzju@redhat.com> wrote: > > The unit address is supposed to represent '<device>,<function>'. Which > are both 0 for RPi4b's XHCI controller. On top of that although > OpenFirmware states bus number goes in the high part of the last reg > parameter, FDT doesn't seem to care for it[1], so remove it. > > [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210830103909.323356-1-nsaenzju@redhat.com/#24414633 > Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node") > Suggested-by: Rob Herring <robh@kernel.org> > Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com> > --- > > Chages since v1: > - Add patch as per robh suggestion > > arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts index 8377dc14b7b5..50530cc91876 100644 --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts @@ -225,8 +225,8 @@ pci@0,0 { reg = <0 0 0 0 0>; - usb@1,0 { - reg = <0x10000 0 0 0 0>; + usb@0,0 { + reg = <0 0 0 0 0>; resets = <&reset RASPBERRYPI_FIRMWARE_RESET_ID_USB>; }; };
The unit address is supposed to represent '<device>,<function>'. Which are both 0 for RPi4b's XHCI controller. On top of that although OpenFirmware states bus number goes in the high part of the last reg parameter, FDT doesn't seem to care for it[1], so remove it. [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210830103909.323356-1-nsaenzju@redhat.com/#24414633 Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node") Suggested-by: Rob Herring <robh@kernel.org> Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com> --- Chages since v1: - Add patch as per robh suggestion arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)