| Message ID | 20210830003603.31864-3-zhiyong.tao@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Mediatek pinctrl patch on mt8195 | expand |
On Mon, Aug 30, 2021 at 08:36:01AM +0800, Zhiyong Tao wrote: > Change pull up/down description Every commit is a 'change'. Your commit msg should explain 'why', not what the diff is. > > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> > --- > .../bindings/pinctrl/pinctrl-mt8195.yaml | 32 +++++++++++++++++-- > 1 file changed, 29 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > index 2f12ec59eee5..a341ed9f0095 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > @@ -85,9 +85,35 @@ patternProperties: > 2/4/6/8/10/12/14/16mA in mt8195. > enum: [0, 1, 2, 3, 4, 5, 6, 7] > > - bias-pull-down: true > - > - bias-pull-up: true > + bias-pull-down: > + description: | > + For pull down type is normal, it don't need add RSEL & R1R0 define > + and resistance value. > + For pull down type is PUPD/R0/R1 type, it can add R1R0 define to > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" > + define in mt8195. > + For pull down type is RSEL, it can add RSEL define & resistance value(ohm) > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) > + "75000" & "5000" in mt8195. Sounds like constraints on the values. Please write a schema. > + > + bias-pull-up: > + description: | > + For pull up type is normal, it don't need add RSEL & R1R0 define > + and resistance value. > + For pull up type is PUPD/R0/R1 type, it can add R1R0 define to > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" > + define in mt8195. > + For pull up type is RSEL, it can add RSEL define & resistance value(ohm) > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) > + "1000" & "1500" & "2000" & "3000" & "4000" & "5000" & "10000" & "75000" in mt8195. > > bias-disable: true > > -- > 2.18.0 > >
On Tue, 2021-08-31 at 17:13 -0500, Rob Herring wrote: > On Mon, Aug 30, 2021 at 08:36:01AM +0800, Zhiyong Tao wrote: > > Change pull up/down description > > Every commit is a 'change'. Your commit msg should explain 'why', not > what the diff is. > Hi robh, we will add 'why' explanation in the commit msg in v12. > > > > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> > > --- > > .../bindings/pinctrl/pinctrl-mt8195.yaml | 32 +++++++++++++++++-- > > 1 file changed, 29 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > index 2f12ec59eee5..a341ed9f0095 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > @@ -85,9 +85,35 @@ patternProperties: > > 2/4/6/8/10/12/14/16mA in mt8195. > > enum: [0, 1, 2, 3, 4, 5, 6, 7] > > > > - bias-pull-down: true > > - > > - bias-pull-up: true > > + bias-pull-down: > > + description: | > > + For pull down type is normal, it don't need add RSEL & R1R0 define > > + and resistance value. > > + For pull down type is PUPD/R0/R1 type, it can add R1R0 define to > > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & > > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" > > + define in mt8195. > > + For pull down type is RSEL, it can add RSEL define & resistance value(ohm) > > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & > > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & > > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & > > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) > > + "75000" & "5000" in mt8195. > > Sounds like constraints on the values. Please write a schema. > we will add a schema here in v12. Thanks > > + > > + bias-pull-up: > > + description: | > > + For pull up type is normal, it don't need add RSEL & R1R0 define > > + and resistance value. > > + For pull up type is PUPD/R0/R1 type, it can add R1R0 define to > > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & > > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" > > + define in mt8195. > > + For pull up type is RSEL, it can add RSEL define & resistance value(ohm) > > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & > > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & > > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & > > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) > > + "1000" & "1500" & "2000" & "3000" & "4000" & "5000" & "10000" & "75000" in mt8195. > > > > bias-disable: true > > > > -- > > 2.18.0 > > > >
On Wed, Sep 1, 2021 at 10:01 AM zhiyong.tao <zhiyong.tao@mediatek.com> wrote: > > On Tue, 2021-08-31 at 17:13 -0500, Rob Herring wrote: > > On Mon, Aug 30, 2021 at 08:36:01AM +0800, Zhiyong Tao wrote: > > > Change pull up/down description > > > > Every commit is a 'change'. Your commit msg should explain 'why', not > > what the diff is. > > > Hi robh, > we will add 'why' explanation in the commit msg in v12. > > > > > > > > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> > > > --- > > > .../bindings/pinctrl/pinctrl-mt8195.yaml | 32 +++++++++++++++++-- > > > 1 file changed, 29 insertions(+), 3 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > > index 2f12ec59eee5..a341ed9f0095 100644 > > > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > > @@ -85,9 +85,35 @@ patternProperties: > > > 2/4/6/8/10/12/14/16mA in mt8195. > > > enum: [0, 1, 2, 3, 4, 5, 6, 7] > > > > > > - bias-pull-down: true > > > - > > > - bias-pull-up: true > > > + bias-pull-down: > > > + description: | > > > + For pull down type is normal, it don't need add RSEL & R1R0 define > > > + and resistance value. > > > + For pull down type is PUPD/R0/R1 type, it can add R1R0 define to > > > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & > > > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" > > > + define in mt8195. > > > + For pull down type is RSEL, it can add RSEL define & resistance value(ohm) > > > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & > > > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & > > > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & > > > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) > > > + "75000" & "5000" in mt8195. > > > > Sounds like constraints on the values. Please write a schema. > > > we will add a schema here in v12. Could the description be written to encourage device tree authors to use SI units instead of the macros? Thanks ChenYu > > Thanks > > > + > > > + bias-pull-up: > > > + description: | > > > + For pull up type is normal, it don't need add RSEL & R1R0 define > > > + and resistance value. > > > + For pull up type is PUPD/R0/R1 type, it can add R1R0 define to > > > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & > > > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" > > > + define in mt8195. > > > + For pull up type is RSEL, it can add RSEL define & resistance value(ohm) > > > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & > > > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & > > > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & > > > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) > > > + "1000" & "1500" & "2000" & "3000" & "4000" & "5000" & "10000" & "75000" in mt8195. > > > > > > bias-disable: true > > > > > > -- > > > 2.18.0 > > > > > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
On Wed, 2021-09-01 at 18:21 +0800, Chen-Yu Tsai wrote: > On Wed, Sep 1, 2021 at 10:01 AM zhiyong.tao <zhiyong.tao@mediatek.com> wrote: > > > > On Tue, 2021-08-31 at 17:13 -0500, Rob Herring wrote: > > > On Mon, Aug 30, 2021 at 08:36:01AM +0800, Zhiyong Tao wrote: > > > > Change pull up/down description > > > > > > Every commit is a 'change'. Your commit msg should explain 'why', not > > > what the diff is. > > > > > Hi robh, > > we will add 'why' explanation in the commit msg in v12. > > > > > > > > > > > > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> > > > > --- > > > > .../bindings/pinctrl/pinctrl-mt8195.yaml | 32 +++++++++++++++++-- > > > > 1 file changed, 29 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > > > index 2f12ec59eee5..a341ed9f0095 100644 > > > > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > > > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > > > @@ -85,9 +85,35 @@ patternProperties: > > > > 2/4/6/8/10/12/14/16mA in mt8195. > > > > enum: [0, 1, 2, 3, 4, 5, 6, 7] > > > > > > > > - bias-pull-down: true > > > > - > > > > - bias-pull-up: true > > > > + bias-pull-down: > > > > + description: | > > > > + For pull down type is normal, it don't need add RSEL & R1R0 define > > > > + and resistance value. > > > > + For pull down type is PUPD/R0/R1 type, it can add R1R0 define to > > > > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & > > > > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" > > > > + define in mt8195. > > > > + For pull down type is RSEL, it can add RSEL define & resistance value(ohm) > > > > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & > > > > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & > > > > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & > > > > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) > > > > + "75000" & "5000" in mt8195. > > > > > > Sounds like constraints on the values. Please write a schema. > > > > > we will add a schema here in v12. > > Could the description be written to encourage device tree authors to > use SI units instead of the macros? > > Thanks > ChenYu In mt8195, SI units is used. we will change the description. If user dont want to use SI units, We also provide the solution of the macros for the solution. > > > > > Thanks > > > > + > > > > + bias-pull-up: > > > > + description: | > > > > + For pull up type is normal, it don't need add RSEL & R1R0 define > > > > + and resistance value. > > > > + For pull up type is PUPD/R0/R1 type, it can add R1R0 define to > > > > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & > > > > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" > > > > + define in mt8195. > > > > + For pull up type is RSEL, it can add RSEL define & resistance value(ohm) > > > > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & > > > > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & > > > > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & > > > > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) > > > > + "1000" & "1500" & "2000" & "3000" & "4000" & "5000" & "10000" & "75000" in mt8195. > > > > > > > > bias-disable: true > > > > > > > > -- > > > > 2.18.0 > > > > > > > > > > > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-mediatek
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml index 2f12ec59eee5..a341ed9f0095 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml @@ -85,9 +85,35 @@ patternProperties: 2/4/6/8/10/12/14/16mA in mt8195. enum: [0, 1, 2, 3, 4, 5, 6, 7] - bias-pull-down: true - - bias-pull-up: true + bias-pull-down: + description: | + For pull down type is normal, it don't need add RSEL & R1R0 define + and resistance value. + For pull down type is PUPD/R0/R1 type, it can add R1R0 define to + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" + define in mt8195. + For pull down type is RSEL, it can add RSEL define & resistance value(ohm) + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) + "75000" & "5000" in mt8195. + + bias-pull-up: + description: | + For pull up type is normal, it don't need add RSEL & R1R0 define + and resistance value. + For pull up type is PUPD/R0/R1 type, it can add R1R0 define to + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" & + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11" + define in mt8195. + For pull up type is RSEL, it can add RSEL define & resistance value(ohm) + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" & + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm) + "1000" & "1500" & "2000" & "3000" & "4000" & "5000" & "10000" & "75000" in mt8195. bias-disable: true
Change pull up/down description Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> --- .../bindings/pinctrl/pinctrl-mt8195.yaml | 32 +++++++++++++++++-- 1 file changed, 29 insertions(+), 3 deletions(-)