| Message ID | 20210901055709.8079-1-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | a24973a60551dab8a4b6cbbe02d64719dc2858a1 |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: vsp1: Make use of the helper function devm_platform_ioremap_resource() | expand |
On 01/09/2021 06:57, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > --- > drivers/media/platform/vsp1/vsp1_drv.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c > index de442d6c9926..8acd6d45d8d0 100644 > --- a/drivers/media/platform/vsp1/vsp1_drv.c > +++ b/drivers/media/platform/vsp1/vsp1_drv.c > @@ -785,7 +785,6 @@ static int vsp1_probe(struct platform_device *pdev) > struct vsp1_device *vsp1; > struct device_node *fcp_node; > struct resource *irq; > - struct resource *io; > unsigned int i; > int ret; > > @@ -800,8 +799,7 @@ static int vsp1_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, vsp1); > > /* I/O and IRQ resources (clock managed by the clock PM domain). */ > - io = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - vsp1->mmio = devm_ioremap_resource(&pdev->dev, io); > + vsp1->mmio = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(vsp1->mmio)) > return PTR_ERR(vsp1->mmio); > >
Hi Cai, Thank you for the patch. On Wed, Sep 01, 2021 at 01:57:08PM +0800, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/platform/vsp1/vsp1_drv.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c > index de442d6c9926..8acd6d45d8d0 100644 > --- a/drivers/media/platform/vsp1/vsp1_drv.c > +++ b/drivers/media/platform/vsp1/vsp1_drv.c > @@ -785,7 +785,6 @@ static int vsp1_probe(struct platform_device *pdev) > struct vsp1_device *vsp1; > struct device_node *fcp_node; > struct resource *irq; > - struct resource *io; > unsigned int i; > int ret; > > @@ -800,8 +799,7 @@ static int vsp1_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, vsp1); > > /* I/O and IRQ resources (clock managed by the clock PM domain). */ > - io = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - vsp1->mmio = devm_ioremap_resource(&pdev->dev, io); > + vsp1->mmio = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(vsp1->mmio)) > return PTR_ERR(vsp1->mmio); >
diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c index de442d6c9926..8acd6d45d8d0 100644 --- a/drivers/media/platform/vsp1/vsp1_drv.c +++ b/drivers/media/platform/vsp1/vsp1_drv.c @@ -785,7 +785,6 @@ static int vsp1_probe(struct platform_device *pdev) struct vsp1_device *vsp1; struct device_node *fcp_node; struct resource *irq; - struct resource *io; unsigned int i; int ret; @@ -800,8 +799,7 @@ static int vsp1_probe(struct platform_device *pdev) platform_set_drvdata(pdev, vsp1); /* I/O and IRQ resources (clock managed by the clock PM domain). */ - io = platform_get_resource(pdev, IORESOURCE_MEM, 0); - vsp1->mmio = devm_ioremap_resource(&pdev->dev, io); + vsp1->mmio = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(vsp1->mmio)) return PTR_ERR(vsp1->mmio);
Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/media/platform/vsp1/vsp1_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)