| Message ID | 20210901055455.7179-1-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: rc: st_rc: Make use of the helper function devm_platform_ioremap_resource() | expand |
Hi Cai On 9/1/21 7:54 AM, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > --- > drivers/media/rc/st_rc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c > index d79d1e3996b2..4e419dbbacd3 100644 > --- a/drivers/media/rc/st_rc.c > +++ b/drivers/media/rc/st_rc.c > @@ -231,7 +231,6 @@ static int st_rc_probe(struct platform_device *pdev) > int ret = -EINVAL; > struct rc_dev *rdev; > struct device *dev = &pdev->dev; > - struct resource *res; > struct st_rc_device *rc_dev; > struct device_node *np = pdev->dev.of_node; > const char *rx_mode; > @@ -274,9 +273,7 @@ static int st_rc_probe(struct platform_device *pdev) > goto err; > } > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - > - rc_dev->base = devm_ioremap_resource(dev, res); > + rc_dev->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(rc_dev->base)) { > ret = PTR_ERR(rc_dev->base); > goto err; > Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Thanks Patrice
diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c index d79d1e3996b2..4e419dbbacd3 100644 --- a/drivers/media/rc/st_rc.c +++ b/drivers/media/rc/st_rc.c @@ -231,7 +231,6 @@ static int st_rc_probe(struct platform_device *pdev) int ret = -EINVAL; struct rc_dev *rdev; struct device *dev = &pdev->dev; - struct resource *res; struct st_rc_device *rc_dev; struct device_node *np = pdev->dev.of_node; const char *rx_mode; @@ -274,9 +273,7 @@ static int st_rc_probe(struct platform_device *pdev) goto err; } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - - rc_dev->base = devm_ioremap_resource(dev, res); + rc_dev->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(rc_dev->base)) { ret = PTR_ERR(rc_dev->base); goto err;
Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/media/rc/st_rc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)