[v2,01/52] ASoC: dt-bindings: Add WM8978 Binding

Commit Message

Maxime Ripard Sept. 1, 2021, 9:18 a.m. UTC

Even though we had the wm8978 driver for some time and a number of
boards using it already, we never had a binding for it. Let's add it
based on what the driver expects and the boards are providing.

Cc: [e-mail]
Cc: [e-mail]
Cc: Liam Girdwood <[e-mail]>
Cc: Mark Brown <[e-mail]>
Cc: [e-mail]
Reviewed-by: Rob Herring <[e-mail]>
Signed-off-by: Maxime Ripard <[e-mail]>

---

Changes from v1:
  - Changed the maintainers of the bindings
---
 .../devicetree/bindings/sound/wlf,wm8978.yaml | 58 +++++++++++++++++++
 1 file changed, 58 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8978.yaml

Comments

Charles Keepax Sept. 1, 2021, 10:11 a.m. UTC | #1

On Wed, Sep 01, 2021 at 11:18:01AM +0200, Maxime Ripard wrote:
> Even though we had the wm8978 driver for some time and a number of
> boards using it already, we never had a binding for it. Let's add it
> based on what the driver expects and the boards are providing.
> 
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: Liam Girdwood <[e-mail]>
> Cc: Mark Brown <[e-mail]>
> Cc: [e-mail]
> Reviewed-by: Rob Herring <[e-mail]>
> Signed-off-by: Maxime Ripard <[e-mail]>
> 
> ---

Acked-by: Charles Keepax <[e-mail]>

Thanks,
Charles

Mark Brown Sept. 1, 2021, 2:39 p.m. UTC | #2

On Wed, Sep 01, 2021 at 11:18:01AM +0200, Maxime Ripard wrote:
> Even though we had the wm8978 driver for some time and a number of
> boards using it already, we never had a binding for it. Let's add it
> based on what the driver expects and the boards are providing.

What's the story with dependencies here?  I don't have a cover letter or
anything and there seem to be a bunch of tangentially related patches in
a series here.

Maxime Ripard Sept. 3, 2021, 10:37 a.m. UTC | #3

Hi Mark,

On Wed, Sep 01, 2021 at 03:39:50PM +0100, Mark Brown wrote:
> On Wed, Sep 01, 2021 at 11:18:01AM +0200, Maxime Ripard wrote:
> > Even though we had the wm8978 driver for some time and a number of
> > boards using it already, we never had a binding for it. Let's add it
> > based on what the driver expects and the boards are providing.
> 
> What's the story with dependencies here?  I don't have a cover letter or
> anything and there seem to be a bunch of tangentially related patches in
> a series here.

There's no dependency, you can pick the ASoC patches safely

Maxime

Mark Brown Sept. 3, 2021, 11:36 a.m. UTC | #4

On Fri, Sep 03, 2021 at 12:37:06PM +0200, Maxime Ripard wrote:
> On Wed, Sep 01, 2021 at 03:39:50PM +0100, Mark Brown wrote:

> > What's the story with dependencies here?  I don't have a cover letter or
> > anything and there seem to be a bunch of tangentially related patches in
> > a series here.

> There's no dependency, you can pick the ASoC patches safely

Oh, OK.  In cases like this it's generally better to not combine random
unrelated stuff into one series - as well as making it look like there
are dependencies it can also cause problems for tooling (eg, b4 is going
to want to fetch the whole series and my personal tooling doesn't like
the same series going to more than one of the subsystems I maintain.

Patch

diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
new file mode 100644
index 000000000000..944e5859c962
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
@@ -0,0 +1,58 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/wlf,wm8978.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Wolfson WM8978 Codec Device Tree Bindings
+
+maintainers:
+  - [e-mail]
+
+properties:
+  '#sound-dai-cells':
+    const: 0
+
+  compatible:
+    const: wlf,wm8978
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 526000
+
+required:
+  - '#sound-dai-cells'
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@0 {
+            #sound-dai-cells = <0>;
+            compatible = "wlf,wm8978";
+            reg = <0>;
+            spi-max-frequency = <500000>;
+        };
+    };
+
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@0 {
+            #sound-dai-cells = <0>;
+            compatible = "wlf,wm8978";
+            reg = <0>;
+        };
+    };
+
+...