| Message ID | 20210902100851.GD2151@kadam (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d2cabd2dc8da78faf9b690ea521d03776686c9fe |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: qrtr: revert check in qrtr_endpoint_post() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: mani@kernel.org linux-arm-msm@vger.kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 3 this patch: 3 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 3 this patch: 3 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 2 Sep 2021 13:08:51 +0300 you wrote: > I tried to make this check stricter as a hardenning measure but it broke > audo and wifi on these devices so revert it. > > Fixes: aaa8e4922c88 ("net: qrtr: make checks in qrtr_endpoint_post() stricter") > Reported-by: John Stultz <john.stultz@linaro.org> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > [...] Here is the summary with links: - [net] net: qrtr: revert check in qrtr_endpoint_post() https://git.kernel.org/netdev/net/c/d2cabd2dc8da You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index 525e3ea063b1..ec2322529727 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -493,7 +493,7 @@ int qrtr_endpoint_post(struct qrtr_endpoint *ep, const void *data, size_t len) goto err; } - if (!size || size & 3 || len != size + hdrlen) + if (!size || len != ALIGN(size, 4) + hdrlen) goto err; if (cb->dst_port != QRTR_PORT_CTRL && cb->type != QRTR_TYPE_DATA &&
I tried to make this check stricter as a hardenning measure but it broke audo and wifi on these devices so revert it. Fixes: aaa8e4922c88 ("net: qrtr: make checks in qrtr_endpoint_post() stricter") Reported-by: John Stultz <john.stultz@linaro.org> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- net/qrtr/qrtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)