| Message ID | 20210902002801.32618-1-justin.he@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] KVM: arm64: vgic: Add memcg accounting to vgic allocations | expand |
Jia, Once again: please add a cover letter when you have a patch series. It isn't rocket science, and Git will do it for you. On Thu, 02 Sep 2021 01:28:00 +0100, Jia He <justin.he@arm.com> wrote: > > Inspired by commit 254272ce6505 ("kvm: x86: Add memcg accounting to KVM > allocations"), it would be better to make arm64 vgic consistent with > common kvm codes. > > The memory allocations of VM scope should be charged into VM process > cgroup, hence change GFP_KERNEL to GFP_KERNEL_ACCOUNT. > > There remained a case in vgic_set_kvm_info() since this allocation is > global, not in VM scope. > > Signed-off-by: Jia He <justin.he@arm.com> > --- > arch/arm64/kvm/vgic/vgic-debug.c | 2 +- > arch/arm64/kvm/vgic/vgic-init.c | 2 +- > arch/arm64/kvm/vgic/vgic-irqfd.c | 2 +- > arch/arm64/kvm/vgic/vgic-its.c | 14 +++++++------- > arch/arm64/kvm/vgic/vgic-mmio-v3.c | 2 +- > arch/arm64/kvm/vgic/vgic-v4.c | 2 +- > 6 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic-debug.c > index f38c40a76251..e6a01f210df9 100644 > --- a/arch/arm64/kvm/vgic/vgic-debug.c > +++ b/arch/arm64/kvm/vgic/vgic-debug.c > @@ -92,7 +92,7 @@ static void *vgic_debug_start(struct seq_file *s, loff_t *pos) > goto out; > } > > - iter = kmalloc(sizeof(*iter), GFP_KERNEL); > + iter = kmalloc(sizeof(*iter), GFP_KERNEL_ACCOUNT); This really isn't an allocation made in the context of a VM. I don't think this hunk belongs here. Thanks, M.
Hi Marc > -----Original Message----- > From: Marc Zyngier <maz@kernel.org> > Sent: Friday, September 3, 2021 2:04 AM > To: Justin He <Justin.He@arm.com> > Cc: James Morse <James.Morse@arm.com>; Alexandru Elisei > <Alexandru.Elisei@arm.com>; Suzuki Poulose <Suzuki.Poulose@arm.com>; > Catalin Marinas <Catalin.Marinas@arm.com>; Will Deacon <will@kernel.org>; > Liu Shixin <liushixin2@huawei.com>; Eric Auger <eric.auger@redhat.com>; > Kees Cook <keescook@chromium.org>; Nick Desaulniers > <ndesaulniers@google.com>; Shenming Lu <lushenming@huawei.com>; Sami > Tolvanen <samitolvanen@google.com>; Lorenzo Pieralisi > <Lorenzo.Pieralisi@arm.com>; Xiaoming Ni <nixiaoming@huawei.com>; Zenghui > Yu <yuzenghui@huawei.com>; linux-arm-kernel@lists.infradead.org; > kvmarm@lists.cs.columbia.edu; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/2] KVM: arm64: vgic: Add memcg accounting to vgic > allocations > > Jia, > > Once again: please add a cover letter when you have a patch > series. It isn't rocket science, and Git will do it for you. > Okay > On Thu, 02 Sep 2021 01:28:00 +0100, > Jia He <justin.he@arm.com> wrote: > > > > Inspired by commit 254272ce6505 ("kvm: x86: Add memcg accounting to KVM > > allocations"), it would be better to make arm64 vgic consistent with > > common kvm codes. > > > > The memory allocations of VM scope should be charged into VM process > > cgroup, hence change GFP_KERNEL to GFP_KERNEL_ACCOUNT. > > > > There remained a case in vgic_set_kvm_info() since this allocation is > > global, not in VM scope. > > > > Signed-off-by: Jia He <justin.he@arm.com> > > --- > > arch/arm64/kvm/vgic/vgic-debug.c | 2 +- > > arch/arm64/kvm/vgic/vgic-init.c | 2 +- > > arch/arm64/kvm/vgic/vgic-irqfd.c | 2 +- > > arch/arm64/kvm/vgic/vgic-its.c | 14 +++++++------- > > arch/arm64/kvm/vgic/vgic-mmio-v3.c | 2 +- > > arch/arm64/kvm/vgic/vgic-v4.c | 2 +- > > 6 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic- > debug.c > > index f38c40a76251..e6a01f210df9 100644 > > --- a/arch/arm64/kvm/vgic/vgic-debug.c > > +++ b/arch/arm64/kvm/vgic/vgic-debug.c > > @@ -92,7 +92,7 @@ static void *vgic_debug_start(struct seq_file *s, > loff_t *pos) > > goto out; > > } > > > > - iter = kmalloc(sizeof(*iter), GFP_KERNEL); > > + iter = kmalloc(sizeof(*iter), GFP_KERNEL_ACCOUNT); > > This really isn't an allocation made in the context of a VM. I don't > think this hunk belongs here. Yes, indeed -- Cheers, Justin (Jia He)
diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic-debug.c index f38c40a76251..e6a01f210df9 100644 --- a/arch/arm64/kvm/vgic/vgic-debug.c +++ b/arch/arm64/kvm/vgic/vgic-debug.c @@ -92,7 +92,7 @@ static void *vgic_debug_start(struct seq_file *s, loff_t *pos) goto out; } - iter = kmalloc(sizeof(*iter), GFP_KERNEL); + iter = kmalloc(sizeof(*iter), GFP_KERNEL_ACCOUNT); if (!iter) { iter = ERR_PTR(-ENOMEM); goto out; diff --git a/arch/arm64/kvm/vgic/vgic-init.c b/arch/arm64/kvm/vgic/vgic-init.c index 340c51d87677..0a06d0648970 100644 --- a/arch/arm64/kvm/vgic/vgic-init.c +++ b/arch/arm64/kvm/vgic/vgic-init.c @@ -134,7 +134,7 @@ static int kvm_vgic_dist_init(struct kvm *kvm, unsigned int nr_spis) struct kvm_vcpu *vcpu0 = kvm_get_vcpu(kvm, 0); int i; - dist->spis = kcalloc(nr_spis, sizeof(struct vgic_irq), GFP_KERNEL); + dist->spis = kcalloc(nr_spis, sizeof(struct vgic_irq), GFP_KERNEL_ACCOUNT); if (!dist->spis) return -ENOMEM; diff --git a/arch/arm64/kvm/vgic/vgic-irqfd.c b/arch/arm64/kvm/vgic/vgic-irqfd.c index 79f8899b234c..475059bacedf 100644 --- a/arch/arm64/kvm/vgic/vgic-irqfd.c +++ b/arch/arm64/kvm/vgic/vgic-irqfd.c @@ -139,7 +139,7 @@ int kvm_vgic_setup_default_irq_routing(struct kvm *kvm) u32 nr = dist->nr_spis; int i, ret; - entries = kcalloc(nr, sizeof(*entries), GFP_KERNEL); + entries = kcalloc(nr, sizeof(*entries), GFP_KERNEL_ACCOUNT); if (!entries) return -ENOMEM; diff --git a/arch/arm64/kvm/vgic/vgic-its.c b/arch/arm64/kvm/vgic/vgic-its.c index 61728c543eb9..b99f47103056 100644 --- a/arch/arm64/kvm/vgic/vgic-its.c +++ b/arch/arm64/kvm/vgic/vgic-its.c @@ -48,7 +48,7 @@ static struct vgic_irq *vgic_add_lpi(struct kvm *kvm, u32 intid, if (irq) return irq; - irq = kzalloc(sizeof(struct vgic_irq), GFP_KERNEL); + irq = kzalloc(sizeof(struct vgic_irq), GFP_KERNEL_ACCOUNT); if (!irq) return ERR_PTR(-ENOMEM); @@ -332,7 +332,7 @@ int vgic_copy_lpi_list(struct kvm *kvm, struct kvm_vcpu *vcpu, u32 **intid_ptr) * we must be careful not to overrun the array. */ irq_count = READ_ONCE(dist->lpi_list_count); - intids = kmalloc_array(irq_count, sizeof(intids[0]), GFP_KERNEL); + intids = kmalloc_array(irq_count, sizeof(intids[0]), GFP_KERNEL_ACCOUNT); if (!intids) return -ENOMEM; @@ -985,7 +985,7 @@ static int vgic_its_alloc_collection(struct vgic_its *its, if (!vgic_its_check_id(its, its->baser_coll_table, coll_id, NULL)) return E_ITS_MAPC_COLLECTION_OOR; - collection = kzalloc(sizeof(*collection), GFP_KERNEL); + collection = kzalloc(sizeof(*collection), GFP_KERNEL_ACCOUNT); if (!collection) return -ENOMEM; @@ -1029,7 +1029,7 @@ static struct its_ite *vgic_its_alloc_ite(struct its_device *device, { struct its_ite *ite; - ite = kzalloc(sizeof(*ite), GFP_KERNEL); + ite = kzalloc(sizeof(*ite), GFP_KERNEL_ACCOUNT); if (!ite) return ERR_PTR(-ENOMEM); @@ -1150,7 +1150,7 @@ static struct its_device *vgic_its_alloc_device(struct vgic_its *its, { struct its_device *device; - device = kzalloc(sizeof(*device), GFP_KERNEL); + device = kzalloc(sizeof(*device), GFP_KERNEL_ACCOUNT); if (!device) return ERR_PTR(-ENOMEM); @@ -1847,7 +1847,7 @@ void vgic_lpi_translation_cache_init(struct kvm *kvm) struct vgic_translation_cache_entry *cte; /* An allocation failure is not fatal */ - cte = kzalloc(sizeof(*cte), GFP_KERNEL); + cte = kzalloc(sizeof(*cte), GFP_KERNEL_ACCOUNT); if (WARN_ON(!cte)) break; @@ -1888,7 +1888,7 @@ static int vgic_its_create(struct kvm_device *dev, u32 type) if (type != KVM_DEV_TYPE_ARM_VGIC_ITS) return -ENODEV; - its = kzalloc(sizeof(struct vgic_its), GFP_KERNEL); + its = kzalloc(sizeof(struct vgic_its), GFP_KERNEL_ACCOUNT); if (!its) return -ENOMEM; diff --git a/arch/arm64/kvm/vgic/vgic-mmio-v3.c b/arch/arm64/kvm/vgic/vgic-mmio-v3.c index a09cdc0b953c..d3fd8a6c0c9a 100644 --- a/arch/arm64/kvm/vgic/vgic-mmio-v3.c +++ b/arch/arm64/kvm/vgic/vgic-mmio-v3.c @@ -834,7 +834,7 @@ static int vgic_v3_alloc_redist_region(struct kvm *kvm, uint32_t index, if (vgic_v3_rdist_overlap(kvm, base, size)) return -EINVAL; - rdreg = kzalloc(sizeof(*rdreg), GFP_KERNEL); + rdreg = kzalloc(sizeof(*rdreg), GFP_KERNEL_ACCOUNT); if (!rdreg) return -ENOMEM; diff --git a/arch/arm64/kvm/vgic/vgic-v4.c b/arch/arm64/kvm/vgic/vgic-v4.c index c1845d8f5f7e..772dd15a22c7 100644 --- a/arch/arm64/kvm/vgic/vgic-v4.c +++ b/arch/arm64/kvm/vgic/vgic-v4.c @@ -246,7 +246,7 @@ int vgic_v4_init(struct kvm *kvm) nr_vcpus = atomic_read(&kvm->online_vcpus); dist->its_vm.vpes = kcalloc(nr_vcpus, sizeof(*dist->its_vm.vpes), - GFP_KERNEL); + GFP_KERNEL_ACCOUNT); if (!dist->its_vm.vpes) return -ENOMEM;
Inspired by commit 254272ce6505 ("kvm: x86: Add memcg accounting to KVM allocations"), it would be better to make arm64 vgic consistent with common kvm codes. The memory allocations of VM scope should be charged into VM process cgroup, hence change GFP_KERNEL to GFP_KERNEL_ACCOUNT. There remained a case in vgic_set_kvm_info() since this allocation is global, not in VM scope. Signed-off-by: Jia He <justin.he@arm.com> --- arch/arm64/kvm/vgic/vgic-debug.c | 2 +- arch/arm64/kvm/vgic/vgic-init.c | 2 +- arch/arm64/kvm/vgic/vgic-irqfd.c | 2 +- arch/arm64/kvm/vgic/vgic-its.c | 14 +++++++------- arch/arm64/kvm/vgic/vgic-mmio-v3.c | 2 +- arch/arm64/kvm/vgic/vgic-v4.c | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-)