| Message ID | 20210901055540.7479-1-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | a7cba8c9d0a49e6a2ba69a95970d208d8bfc3503 |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: renesas-ceu: Make use of the helper function devm_platform_ioremap_resource() | expand |
On 01/09/2021 06:55, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/platform/renesas-ceu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c > index 9376eb363748..2e8dbacc414e 100644 > --- a/drivers/media/platform/renesas-ceu.c > +++ b/drivers/media/platform/renesas-ceu.c > @@ -1628,7 +1628,6 @@ static int ceu_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > const struct ceu_data *ceu_data; > struct ceu_device *ceudev; > - struct resource *res; > unsigned int irq; > int num_subdevs; > int ret; > @@ -1644,8 +1643,7 @@ static int ceu_probe(struct platform_device *pdev) > spin_lock_init(&ceudev->lock); > mutex_init(&ceudev->mlock); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - ceudev->base = devm_ioremap_resource(dev, res); > + ceudev->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(ceudev->base)) { > ret = PTR_ERR(ceudev->base); > goto error_free_ceudev; >
Hello Cai, On Wed, Sep 01, 2021 at 01:55:39PM +0800, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> Acked-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Thanks j > --- > drivers/media/platform/renesas-ceu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c > index 9376eb363748..2e8dbacc414e 100644 > --- a/drivers/media/platform/renesas-ceu.c > +++ b/drivers/media/platform/renesas-ceu.c > @@ -1628,7 +1628,6 @@ static int ceu_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > const struct ceu_data *ceu_data; > struct ceu_device *ceudev; > - struct resource *res; > unsigned int irq; > int num_subdevs; > int ret; > @@ -1644,8 +1643,7 @@ static int ceu_probe(struct platform_device *pdev) > spin_lock_init(&ceudev->lock); > mutex_init(&ceudev->mlock); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - ceudev->base = devm_ioremap_resource(dev, res); > + ceudev->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(ceudev->base)) { > ret = PTR_ERR(ceudev->base); > goto error_free_ceudev; > -- > 2.25.1 >
diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c index 9376eb363748..2e8dbacc414e 100644 --- a/drivers/media/platform/renesas-ceu.c +++ b/drivers/media/platform/renesas-ceu.c @@ -1628,7 +1628,6 @@ static int ceu_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; const struct ceu_data *ceu_data; struct ceu_device *ceudev; - struct resource *res; unsigned int irq; int num_subdevs; int ret; @@ -1644,8 +1643,7 @@ static int ceu_probe(struct platform_device *pdev) spin_lock_init(&ceudev->lock); mutex_init(&ceudev->mlock); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - ceudev->base = devm_ioremap_resource(dev, res); + ceudev->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(ceudev->base)) { ret = PTR_ERR(ceudev->base); goto error_free_ceudev;
Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/media/platform/renesas-ceu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)