| Message ID | 20210902185543.18875-5-p.yadav@ti.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Rx mode support for Cadence DPHY | expand |
On Fri, 03 Sep 2021 00:25:41 +0530, Pratyush Yadav wrote: > The clocks are not used by the DPHY when used in Rx mode so make them > optional for it by using a conditional based on compatible. > > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> > > --- > > Changes in v5: > - Make clocks a required property based on the compatible. > > Changes in v3: > - Add Rob's Ack. > > Changes in v2: > - Re-order subject prefixes. > > .../devicetree/bindings/phy/cdns,dphy.yaml | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Pratyush, Thank you for the patch. On Fri, Sep 03, 2021 at 12:25:41AM +0530, Pratyush Yadav wrote: > The clocks are not used by the DPHY when used in Rx mode so make them > optional for it by using a conditional based on compatible. > > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > > Changes in v5: > - Make clocks a required property based on the compatible. > > Changes in v3: > - Add Rob's Ack. > > Changes in v2: > - Re-order subject prefixes. > > .../devicetree/bindings/phy/cdns,dphy.yaml | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml > index b90a58773bf2..558f110fda9e 100644 > --- a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml > +++ b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml > @@ -33,10 +33,19 @@ properties: > required: > - compatible > - reg > - - clocks > - - clock-names > - "#phy-cells" > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: cdns,dphy > + then: > + required: > + - clocks > + - clock-names > + > additionalProperties: false > > examples:
diff --git a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml index b90a58773bf2..558f110fda9e 100644 --- a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml +++ b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml @@ -33,10 +33,19 @@ properties: required: - compatible - reg - - clocks - - clock-names - "#phy-cells" +allOf: + - if: + properties: + compatible: + contains: + const: cdns,dphy + then: + required: + - clocks + - clock-names + additionalProperties: false examples:
The clocks are not used by the DPHY when used in Rx mode so make them optional for it by using a conditional based on compatible. Signed-off-by: Pratyush Yadav <p.yadav@ti.com> --- Changes in v5: - Make clocks a required property based on the compatible. Changes in v3: - Add Rob's Ack. Changes in v2: - Re-order subject prefixes. .../devicetree/bindings/phy/cdns,dphy.yaml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)