| Message ID | 20210829095614.50021-1-kari.argillander@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | fs/ntfs3: Use new mount api and change some opts | expand |
On Sun, Aug 29, 2021 at 12:56:05PM +0300, Kari Argillander wrote: > See V2 if you want: > lore.kernel.org/ntfs3/20210819002633.689831-1-kari.argillander@gmail.com > > NLS change is now blocked when remounting. Christoph also suggest that > we block all other mount options, but I have tested a couple and they > seem to work. I wish that we do not block any other than NLS because > in theory they should work. Also Konstantin can comment about this. > > I have not include reviewed/acked to patch "Use new api for mounting" > because it change so much. I have also included three new patch to this > series: > - Convert mount options to pointer in sbi > So that we do not need to initiliaze whole spi in > remount. > - Init spi more in init_fs_context than fill_super > This is just refactoring. (Series does not depend on this) > - Show uid/gid always in show_options() > Christian Brauner kinda ask this. (Series does not depend > on this) > > Series is ones again tested with kvm-xfstests. Every commit is build > tested. I will send v4 within couple of days. It will address issues what Pali says in patch 8/9. Everything else should be same at least for now. Is everything else looking ok? > > v3: > - Add patch "Convert mount options to pointer in sbi" > - Add patch "Init spi more in init_fs_context than fill_super" > - Add patch "Show uid/gid always in show_options" > - Patch "Use new api for mounting" has make over > - NLS loading is not anymore possible when remounting > - show_options() iocharset printing is fixed > - Delete comment that testing should be done with other > mount options. > - Add reviewed/acked-tags to 1,2,6,8 > - Rewrite this cover > v2: > - Rewrite this cover leter > - Reorder noatime to first patch > - NLS loading with string > - Delete default_options function > - Remove remount flags > - Rename no_acl_rules mount option > - Making code cleaner > - Add comment that mount options should be tested > > Kari Argillander (9): > fs/ntfs3: Remove unnecesarry mount option noatime > fs/ntfs3: Remove unnecesarry remount flag handling > fs/ntfs3: Convert mount options to pointer in sbi > fs/ntfs3: Use new api for mounting > fs/ntfs3: Init spi more in init_fs_context than fill_super > fs/ntfs3: Make mount option nohidden more universal > fs/ntfs3: Add iocharset= mount option as alias for nls= > fs/ntfs3: Rename mount option no_acl_rules > (no)acl_rules > fs/ntfs3: Show uid/gid always in show_options() > > Documentation/filesystems/ntfs3.rst | 10 +- > fs/ntfs3/attrib.c | 2 +- > fs/ntfs3/dir.c | 8 +- > fs/ntfs3/file.c | 4 +- > fs/ntfs3/inode.c | 12 +- > fs/ntfs3/ntfs_fs.h | 26 +- > fs/ntfs3/super.c | 486 +++++++++++++++------------- > fs/ntfs3/xattr.c | 2 +- > 8 files changed, 284 insertions(+), 266 deletions(-) > > -- > 2.25.1 > >
On 07.09.2021 10:36, Kari Argillander wrote: > On Sun, Aug 29, 2021 at 12:56:05PM +0300, Kari Argillander wrote: >> See V2 if you want: >> lore.kernel.org/ntfs3/20210819002633.689831-1-kari.argillander@gmail.com >> >> NLS change is now blocked when remounting. Christoph also suggest that >> we block all other mount options, but I have tested a couple and they >> seem to work. I wish that we do not block any other than NLS because >> in theory they should work. Also Konstantin can comment about this. >> >> I have not include reviewed/acked to patch "Use new api for mounting" >> because it change so much. I have also included three new patch to this >> series: >> - Convert mount options to pointer in sbi >> So that we do not need to initiliaze whole spi in >> remount. >> - Init spi more in init_fs_context than fill_super >> This is just refactoring. (Series does not depend on this) >> - Show uid/gid always in show_options() >> Christian Brauner kinda ask this. (Series does not depend >> on this) >> >> Series is ones again tested with kvm-xfstests. Every commit is build >> tested. > > I will send v4 within couple of days. It will address issues what Pali > says in patch 8/9. Everything else should be same at least for now. Is > everything else looking ok? > Yes, everything else seems good. We tested patches locally - no regression was found. >> >> v3: >> - Add patch "Convert mount options to pointer in sbi" >> - Add patch "Init spi more in init_fs_context than fill_super" >> - Add patch "Show uid/gid always in show_options" >> - Patch "Use new api for mounting" has make over >> - NLS loading is not anymore possible when remounting >> - show_options() iocharset printing is fixed >> - Delete comment that testing should be done with other >> mount options. >> - Add reviewed/acked-tags to 1,2,6,8 >> - Rewrite this cover >> v2: >> - Rewrite this cover leter >> - Reorder noatime to first patch >> - NLS loading with string >> - Delete default_options function >> - Remove remount flags >> - Rename no_acl_rules mount option >> - Making code cleaner >> - Add comment that mount options should be tested >> >> Kari Argillander (9): >> fs/ntfs3: Remove unnecesarry mount option noatime >> fs/ntfs3: Remove unnecesarry remount flag handling >> fs/ntfs3: Convert mount options to pointer in sbi >> fs/ntfs3: Use new api for mounting >> fs/ntfs3: Init spi more in init_fs_context than fill_super >> fs/ntfs3: Make mount option nohidden more universal >> fs/ntfs3: Add iocharset= mount option as alias for nls= >> fs/ntfs3: Rename mount option no_acl_rules > (no)acl_rules >> fs/ntfs3: Show uid/gid always in show_options() >> >> Documentation/filesystems/ntfs3.rst | 10 +- >> fs/ntfs3/attrib.c | 2 +- >> fs/ntfs3/dir.c | 8 +- >> fs/ntfs3/file.c | 4 +- >> fs/ntfs3/inode.c | 12 +- >> fs/ntfs3/ntfs_fs.h | 26 +- >> fs/ntfs3/super.c | 486 +++++++++++++++------------- >> fs/ntfs3/xattr.c | 2 +- >> 8 files changed, 284 insertions(+), 266 deletions(-) >> >> -- >> 2.25.1 >> >>
On Tuesday, September 7, 2021, Andy Shevchenko (andy.shevchenko@gmail.com) wrote: > On Tuesday, September 7, 2021, Konstantin Komarov <almaz.alexandrovich@paragon-software.com> wrote: >> On 07.09.2021 10:36, Kari Argillander wrote: >> > On Sun, Aug 29, 2021 at 12:56:05PM +0300, Kari Argillander wrote: >> >> See V2 if you want: >> >> lore.kernel.org/ntfs3/20210819002633.689831-1-kari.argillander@gmail.com >> >> >> >> NLS change is now blocked when remounting. Christoph also suggest that >> >> we block all other mount options, but I have tested a couple and they >> >> seem to work. I wish that we do not block any other than NLS because >> >> in theory they should work. Also Konstantin can comment about this. >> >> >> >> I have not include reviewed/acked to patch "Use new api for mounting" >> >> because it change so much. I have also included three new patch to this >> >> series: >> >> - Convert mount options to pointer in sbi >> >> So that we do not need to initiliaze whole spi in >> >> remount. >> >> - Init spi more in init_fs_context than fill_super >> >> This is just refactoring. (Series does not depend on this) >> >> - Show uid/gid always in show_options() >> >> Christian Brauner kinda ask this. (Series does not depend >> >> on this) >> >> >> >> Series is ones again tested with kvm-xfstests. Every commit is build >> >> tested. >> > >> > I will send v4 within couple of days. It will address issues what Pali >> > says in patch 8/9. Everything else should be same at least for now. Is >> > everything else looking ok? >> > >> >> Yes, everything else seems good. >> We tested patches locally - no regression was > > The formal answer in such case should also contain the Tested-by tag. I would suggest you to read the Submitting Patches document (available in the Linux kernel source tree). He is a maintainer so he can add tags when he picks this up. This is not really relevant here. Yes it should be good to include that but I have already sended v4 which he has not tested. So I really cannot put this tag for him. So at the end he really should not even put it here. Also usually the maintainers will always make their own tests and usually they will not even bother with a tested-by tag. Or do you say to me that I should go read Submitting Patches document as I'm the one who submit this? Argillander >> >> >> >> v3: >> >> - Add patch "Convert mount options to pointer in sbi" >> >> - Add patch "Init spi more in init_fs_context than fill_super" >> >> - Add patch "Show uid/gid always in show_options" >> >> - Patch "Use new api for mounting" has make over >> >> - NLS loading is not anymore possible when remounting >> >> - show_options() iocharset printing is fixed >> >> - Delete comment that testing should be done with other >> >> mount options. >> >> - Add reviewed/acked-tags to 1,2,6,8 >> >> - Rewrite this cover >> >> v2: >> >> - Rewrite this cover leter >> >> - Reorder noatime to first patch >> >> - NLS loading with string >> >> - Delete default_options function >> >> - Remove remount flags >> >> - Rename no_acl_rules mount option >> >> - Making code cleaner >> >> - Add comment that mount options should be tested >> >> >> >> Kari Argillander (9): >> >> fs/ntfs3: Remove unnecesarry mount option noatime >> >> fs/ntfs3: Remove unnecesarry remount flag handling >> >> fs/ntfs3: Convert mount options to pointer in sbi >> >> fs/ntfs3: Use new api for mounting >> >> fs/ntfs3: Init spi more in init_fs_context than fill_super >> >> fs/ntfs3: Make mount option nohidden more universal >> >> fs/ntfs3: Add iocharset= mount option as alias for nls= >> >> fs/ntfs3: Rename mount option no_acl_rules > (no)acl_rules >> >> fs/ntfs3: Show uid/gid always in show_options() >> >> >> >> Documentation/filesystems/ntfs3.rst | 10 +- >> >> fs/ntfs3/attrib.c | 2 +- >> >> fs/ntfs3/dir.c | 8 +- >> >> fs/ntfs3/file.c | 4 +- >> >> fs/ntfs3/inode.c | 12 +- >> >> fs/ntfs3/ntfs_fs.h | 26 +- >> >> fs/ntfs3/super.c | 486 +++++++++++++++------------- >> >> fs/ntfs3/xattr.c | 2 +- >> >> 8 files changed, 284 insertions(+), 266 deletions(-) >> >> >> >> -- >> >> 2.25.1 >> >> >> >> > > > > -- > With Best Regards, > Andy Shevchenko > >
On Tue, Sep 7, 2021 at 11:47 PM Kari Argillander <kari.argillander@gmail.com> wrote: > On Tuesday, September 7, 2021, Andy Shevchenko > (andy.shevchenko@gmail.com) wrote: > > On Tuesday, September 7, 2021, Konstantin Komarov <almaz.alexandrovich@paragon-software.com> wrote: > >> On 07.09.2021 10:36, Kari Argillander wrote: ... > >> Yes, everything else seems good. > >> We tested patches locally - no regression was > > > > The formal answer in such case should also contain the Tested-by tag. I would suggest you to read the Submitting Patches document (available in the Linux kernel source tree). > > He is a maintainer so he can add tags when he picks this up. It's a good practice to do so. Moreover, it's better to do it patch-by-patch, so tools like `b4` can cope with tags for *anybody* who will use it in automated way. > This is not > really relevant here. Why not? > Yes it should be good to include that but I have already > sended v4 which he has not tested. So I really cannot put this tag for him. > So at the end he really should not even put it here. For v4 I agree with you. > Also usually the maintainers will always make their own tests and usually > they will not even bother with a tested-by tag. If it's their own code, yes, if it's others', why not? See above as well. > Or do you say to me that I > should go read Submitting Patches document as I'm the one who submit > this? It's always good to refresh memory, so why not? :-)
On 08.09.2021 12:00, Andy Shevchenko wrote: > On Tue, Sep 7, 2021 at 11:47 PM Kari Argillander > <kari.argillander@gmail.com> wrote: >> On Tuesday, September 7, 2021, Andy Shevchenko >> (andy.shevchenko@gmail.com) wrote: >>> On Tuesday, September 7, 2021, Konstantin Komarov <almaz.alexandrovich@paragon-software.com> wrote: >>>> On 07.09.2021 10:36, Kari Argillander wrote: > > ... > >>>> Yes, everything else seems good. >>>> We tested patches locally - no regression was >>> >>> The formal answer in such case should also contain the Tested-by tag. I would suggest you to read the Submitting Patches document (available in the Linux kernel source tree). >> >> He is a maintainer so he can add tags when he picks this up. > > It's a good practice to do so. Moreover, it's better to do it > patch-by-patch, so tools like `b4` can cope with tags for *anybody* > who will use it in automated way. > >> This is not >> really relevant here. > > Why not? > >> Yes it should be good to include that but I have already >> sended v4 which he has not tested. So I really cannot put this tag for him. >> So at the end he really should not even put it here. > > For v4 I agree with you. My answer doesn't contain Tested-by tag because author of patch already said that there will be next version of patch. Thanks for Submitting Patches document suggestion. > >> Also usually the maintainers will always make their own tests and usually >> they will not even bother with a tested-by tag. > > If it's their own code, yes, if it's others', why not? See above as well. > >> Or do you say to me that I >> should go read Submitting Patches document as I'm the one who submit >> this? > > It's always good to refresh memory, so why not? :-) >