| Message ID | 20210908092826.67765-1-cuibixuan@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ee5c6f0ca219b65f5085043d481d9b6f045693d5 |
| Headers | show |
| Series | [-next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail | expand |
On 9/8/2021 2:28 AM, Bixuan Cui wrote: > Using list_move_tail() instead of list_del() + list_add_tail() > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> Thanks! Acked-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/dma/idxd/irq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c > index ca88fa7a328e..79fcfc4883e4 100644 > --- a/drivers/dma/idxd/irq.c > +++ b/drivers/dma/idxd/irq.c > @@ -221,8 +221,7 @@ static void irq_process_work_list(struct idxd_irq_entry *irq_entry) > > list_for_each_entry_safe(desc, n, &irq_entry->work_list, list) { > if (desc->completion->status) { > - list_del(&desc->list); > - list_add_tail(&desc->list, &flist); > + list_move_tail(&desc->list, &flist); > } > } >
On 08-09-21, 17:28, Bixuan Cui wrote:
> Using list_move_tail() instead of list_del() + list_add_tail()
Applied, thanks
diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c index ca88fa7a328e..79fcfc4883e4 100644 --- a/drivers/dma/idxd/irq.c +++ b/drivers/dma/idxd/irq.c @@ -221,8 +221,7 @@ static void irq_process_work_list(struct idxd_irq_entry *irq_entry) list_for_each_entry_safe(desc, n, &irq_entry->work_list, list) { if (desc->completion->status) { - list_del(&desc->list); - list_add_tail(&desc->list, &flist); + list_move_tail(&desc->list, &flist); } }
Using list_move_tail() instead of list_del() + list_add_tail() Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> --- drivers/dma/idxd/irq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)