| Message ID | 20210907153557.144391-7-kari.argillander@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fs/ntfs3: Use new mount api and change some opts | expand |
On Tuesday 07 September 2021 18:35:54 Kari Argillander wrote: > If we call Opt_nohidden with just keyword hidden, then we can use > hidden/nohidden when mounting. We already use this method for almoust > all other parameters so it is just logical that this will use same > method. > > Acked-by: Christian Brauner <christian.brauner@ubuntu.com> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Kari Argillander <kari.argillander@gmail.com> Reviewed-by: Pali Rohár <pali@kernel.org> > --- > fs/ntfs3/super.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c > index 420cd1409170..729ead6f2fac 100644 > --- a/fs/ntfs3/super.c > +++ b/fs/ntfs3/super.c > @@ -242,7 +242,7 @@ static const struct fs_parameter_spec ntfs_fs_parameters[] = { > fsparam_flag_no("discard", Opt_discard), > fsparam_flag_no("force", Opt_force), > fsparam_flag_no("sparse", Opt_sparse), > - fsparam_flag("nohidden", Opt_nohidden), > + fsparam_flag_no("hidden", Opt_nohidden), > fsparam_flag_no("acl", Opt_acl), > fsparam_flag_no("showmeta", Opt_showmeta), > fsparam_string("nls", Opt_nls), > @@ -331,7 +331,7 @@ static int ntfs_fs_parse_param(struct fs_context *fc, > opts->sparse = result.negated ? 0 : 1; > break; > case Opt_nohidden: > - opts->nohidden = 1; > + opts->nohidden = result.negated ? 1 : 0; > break; > case Opt_acl: > if (!result.negated) > -- > 2.25.1 >
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index 420cd1409170..729ead6f2fac 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -242,7 +242,7 @@ static const struct fs_parameter_spec ntfs_fs_parameters[] = { fsparam_flag_no("discard", Opt_discard), fsparam_flag_no("force", Opt_force), fsparam_flag_no("sparse", Opt_sparse), - fsparam_flag("nohidden", Opt_nohidden), + fsparam_flag_no("hidden", Opt_nohidden), fsparam_flag_no("acl", Opt_acl), fsparam_flag_no("showmeta", Opt_showmeta), fsparam_string("nls", Opt_nls), @@ -331,7 +331,7 @@ static int ntfs_fs_parse_param(struct fs_context *fc, opts->sparse = result.negated ? 0 : 1; break; case Opt_nohidden: - opts->nohidden = 1; + opts->nohidden = result.negated ? 1 : 0; break; case Opt_acl: if (!result.negated)