| Message ID | 20210903190629.11917-9-dpsmith@apertussolutions.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xsm: refactoring xsm hooks | expand |
On 03.09.2021 21:06, Daniel P. Smith wrote: > The internal define flag is not used by any XSM module, removing the #ifdef > leaving the generic event channel labeling as always present. Already on v2 I did ask "I'm not fully convinced of this removal: Does it get in the way of anything?" I have no record of getting reply, so I'm still wondering. > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -122,13 +122,11 @@ struct evtchn > > #ifdef CONFIG_XSM > union { > -#ifdef XSM_NEED_GENERIC_EVTCHN_SSID > /* > * If an XSM module needs more space for its event channel context, > * this pointer stores the necessary data for the security server. > */ > void *generic; > -#endif I don't consider this any better than what you had originally: Then you've removed everything inside the #ifdef as well. Now you keep it and drop just the #ifdef, exposing the field universally (as long as XSM is set) despite Flask's 32-bit only field being enough for all practical purposes. What is there demonstrates what the original intentions were. It's easy enough to put back if needed in the future, but I think it's even easier to simply leave as is. Jan
On 9/9/21 11:35 AM, Jan Beulich wrote: > On 03.09.2021 21:06, Daniel P. Smith wrote: >> The internal define flag is not used by any XSM module, removing the #ifdef >> leaving the generic event channel labeling as always present. > > Already on v2 I did ask > > "I'm not fully convinced of this removal: Does it get in the way of > anything?" > > I have no record of getting reply, so I'm still wondering. I can't find any email record of it but I know I made this change because of a request to drop XSM_NEED_GENERIC_EVTCHN_SSID since it is completely unused. Honestly I am not concerned on whether this completely unused field is kept or not that is behind a flag that is never set but it clearly is concerning for you, so I will just drop this for now. v/r, dps
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 28146ee404..e56690cd2b 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -122,13 +122,11 @@ struct evtchn #ifdef CONFIG_XSM union { -#ifdef XSM_NEED_GENERIC_EVTCHN_SSID /* * If an XSM module needs more space for its event channel context, * this pointer stores the necessary data for the security server. */ void *generic; -#endif #ifdef CONFIG_XSM_FLASK /* * Inlining the contents of the structure for FLASK avoids unneeded
The internal define flag is not used by any XSM module, removing the #ifdef leaving the generic event channel labeling as always present. Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com> --- xen/include/xen/sched.h | 2 -- 1 file changed, 2 deletions(-)