| Message ID | 20210909013818.1191270-19-rananta@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: arm64: selftests: Introduce arch_timer selftest | expand |
On Thu, Sep 09, 2021 at 01:38:18AM +0000, Raghavendra Rao Ananta wrote: > Pull the definition of REDIST_REGION_ATTR_ADDR from vgic.h. > > Signed-off-by: Raghavendra Rao Ananta <rananta@google.com> > --- > tools/testing/selftests/kvm/aarch64/vgic_init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Just squash this into the commit where you hoist it into vgic.h. It is fine to glob it together with the other vgic changes since you're dropping it into a completely new header file. -- Thanks, Oliver
On Wed, Sep 8, 2021 at 10:36 PM Oliver Upton <oupton@google.com> wrote: > > On Thu, Sep 09, 2021 at 01:38:18AM +0000, Raghavendra Rao Ananta wrote: > > Pull the definition of REDIST_REGION_ATTR_ADDR from vgic.h. > > > > Signed-off-by: Raghavendra Rao Ananta <rananta@google.com> > > --- > > tools/testing/selftests/kvm/aarch64/vgic_init.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Just squash this into the commit where you hoist it into vgic.h. It is > fine to glob it together with the other vgic changes since you're > dropping it into a completely new header file. > Sure, I'll squash it. Regards, Raghavendra > -- > Thanks, > Oliver
diff --git a/tools/testing/selftests/kvm/aarch64/vgic_init.c b/tools/testing/selftests/kvm/aarch64/vgic_init.c index 623f31a14326..157fc24f39c5 100644 --- a/tools/testing/selftests/kvm/aarch64/vgic_init.c +++ b/tools/testing/selftests/kvm/aarch64/vgic_init.c @@ -13,11 +13,10 @@ #include "test_util.h" #include "kvm_util.h" #include "processor.h" +#include "vgic.h" #define NR_VCPUS 4 -#define REDIST_REGION_ATTR_ADDR(count, base, flags, index) (((uint64_t)(count) << 52) | \ - ((uint64_t)((base) >> 16) << 16) | ((uint64_t)(flags) << 12) | index) #define REG_OFFSET(vcpu, offset) (((uint64_t)vcpu << 32) | offset) #define GICR_TYPER 0x8
Pull the definition of REDIST_REGION_ATTR_ADDR from vgic.h. Signed-off-by: Raghavendra Rao Ananta <rananta@google.com> --- tools/testing/selftests/kvm/aarch64/vgic_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)