| Message ID | patch-v2-2.8-4b653cee2d3-20210910T105523Z-avarab@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | post-v2.33 "drop support for ancient curl" follow-up | expand |
On Fri, Sep 10, 2021 at 01:04:27PM +0200, Ævar Arnfjörð Bjarmason wrote: > Without NO_CURL=Y we require at least version "7.19.4" of libcurl, see > 644de29e220 (http: drop support for curl < 7.19.4, 2021-07-30). Let's > document this in the "INSTALL" document. Makes sense. > diff --git a/INSTALL b/INSTALL > index 5c6ecf03c27..81f3a6cf018 100644 > --- a/INSTALL > +++ b/INSTALL > @@ -141,6 +141,9 @@ Issues of note: > - "libcurl" library is used by git-http-fetch, git-fetch, and, if > the curl version >= 7.34.0, for git-imap-send. > > + Git version "7.19.4" of "libcurl" or later to build. This > + version requirement may be bumped in the future. > + s/to build/is needed &/ or similar? -Peff
Jeff King <peff@peff.net> writes: > On Fri, Sep 10, 2021 at 01:04:27PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> Without NO_CURL=Y we require at least version "7.19.4" of libcurl, see >> 644de29e220 (http: drop support for curl < 7.19.4, 2021-07-30). Let's >> document this in the "INSTALL" document. > > Makes sense. > >> diff --git a/INSTALL b/INSTALL >> index 5c6ecf03c27..81f3a6cf018 100644 >> --- a/INSTALL >> +++ b/INSTALL >> @@ -141,6 +141,9 @@ Issues of note: >> - "libcurl" library is used by git-http-fetch, git-fetch, and, if >> the curl version >= 7.34.0, for git-imap-send. >> >> + Git version "7.19.4" of "libcurl" or later to build. This >> + version requirement may be bumped in the future. >> + > > s/to build/is needed &/ or similar? "Get version X of "libcurl" or later to build." probably.
On Fri, Sep 10, 2021 at 09:56:19AM -0700, Junio C Hamano wrote: > Jeff King <peff@peff.net> writes: > > > On Fri, Sep 10, 2021 at 01:04:27PM +0200, Ævar Arnfjörð Bjarmason wrote: > > > >> Without NO_CURL=Y we require at least version "7.19.4" of libcurl, see > >> 644de29e220 (http: drop support for curl < 7.19.4, 2021-07-30). Let's > >> document this in the "INSTALL" document. > > > > Makes sense. > > > >> diff --git a/INSTALL b/INSTALL > >> index 5c6ecf03c27..81f3a6cf018 100644 > >> --- a/INSTALL > >> +++ b/INSTALL > >> @@ -141,6 +141,9 @@ Issues of note: > >> - "libcurl" library is used by git-http-fetch, git-fetch, and, if > >> the curl version >= 7.34.0, for git-imap-send. > >> > >> + Git version "7.19.4" of "libcurl" or later to build. This > >> + version requirement may be bumped in the future. > >> + > > > > s/to build/is needed &/ or similar? > > "Get version X of "libcurl" or later to build." probably. Oh, heh. I do not even see s/Git/Get/ anymore. My mind has been irrecoverably polluted. -Peff
diff --git a/INSTALL b/INSTALL index 5c6ecf03c27..81f3a6cf018 100644 --- a/INSTALL +++ b/INSTALL @@ -141,6 +141,9 @@ Issues of note: - "libcurl" library is used by git-http-fetch, git-fetch, and, if the curl version >= 7.34.0, for git-imap-send. + Git version "7.19.4" of "libcurl" or later to build. This + version requirement may be bumped in the future. + If you do not use http:// or https:// repositories, and do not want to put patches into an IMAP mailbox, you do not have to have them (use NO_CURL).
Without NO_CURL=Y we require at least version "7.19.4" of libcurl, see 644de29e220 (http: drop support for curl < 7.19.4, 2021-07-30). Let's document this in the "INSTALL" document. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- INSTALL | 3 +++ 1 file changed, 3 insertions(+)