diff mbox series

[2/3] xfstests: Rename _test_inject_logprint to _test_remount_dump_log

Message ID 20210909174142.357719-3-catherine.hoang@oracle.com (mailing list archive)
State Superseded, archived
Headers show
Series Dump log cleanups | expand

Commit Message

Catherine Hoang Sept. 9, 2021, 5:41 p.m. UTC 
Rename _test_inject_logprint to _test_remount_dump_log to better
describe what this function does. _test_remount_dump_log unmounts
and remounts the test device, dumping the log.

Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>
---
 common/inject | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Allison Henderson Sept. 11, 2021, 2:11 p.m. UTC | #1 
On 9/9/21 10:41 AM, Catherine Hoang wrote:
> Rename _test_inject_logprint to _test_remount_dump_log to better
> describe what this function does. _test_remount_dump_log unmounts
> and remounts the test device, dumping the log.
> 
> Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>

I notice this function has no callers, but I think it's a good utility 
function to keep around.  I think it looks ok.

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>

> ---
>   common/inject | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/inject b/common/inject
> index 3b731df7..b5334d4a 100644
> --- a/common/inject
> +++ b/common/inject
> @@ -126,7 +126,7 @@ _scratch_remount_dump_log()
>   }
>   
>   # Unmount and remount the test device, dumping the log
> -_test_inject_logprint()
> +_test_remount_dump_log()
>   {
>   	local opts="$1"
>   
>
diff mbox series

Patch

diff --git a/common/inject b/common/inject
index 3b731df7..b5334d4a 100644
--- a/common/inject
+++ b/common/inject
@@ -126,7 +126,7 @@  _scratch_remount_dump_log()
 }
 
 # Unmount and remount the test device, dumping the log
-_test_inject_logprint()
+_test_remount_dump_log()
 {
 	local opts="$1"