| Message ID | 20210912213212.12169-1-kilobyte@angband.pl (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/3] scsi: aic7xxx: fix building with -Werror (missing include) | expand |
On Sun, 2021-09-12 at 23:32 +0200, Adam Borowski wrote: > This is an userland helper tool to generate data rather than > something compiled into the kernel, thus it wants regular POSIX > functions. > > Signed-off-by: Adam Borowski <kilobyte@angband.pl> > --- > drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c > b/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c > index 975fcfcc0d8f..2cd87ea86dfc 100644 > --- a/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c > +++ b/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c > @@ -45,6 +45,7 @@ > #include <sys/types.h> > > #include "aicdb.h" > +#include <ctype.h> I'm really dubious about trying to get aicasm to compile with -Werror ... the driver is dying and we have prebuilt firmware headers in the tree so it's not like it's required. I'm also curious: if you compiled with -Werror how did you get around the missing function declarations induced by the -p mm in the bison command line? James
On Sun, Sep 12, 2021 at 03:09:58PM -0700, James Bottomley wrote: > On Sun, 2021-09-12 at 23:32 +0200, Adam Borowski wrote: > > This is an userland helper tool to generate data rather than > > something compiled into the kernel, thus it wants regular POSIX > > functions. > > --- a/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c > > +++ b/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c > > @@ -45,6 +45,7 @@ > > #include <sys/types.h> > > > > #include "aicdb.h" > > +#include <ctype.h> > > I'm really dubious about trying to get aicasm to compile with -Werror > ... the driver is dying and we have prebuilt firmware headers in the > tree so it's not like it's required. To be honest, I don't care much about this driver, but when it fails here, it stops build tests. > I'm also curious: if you compiled with -Werror how did you get around > the missing function declarations induced by the -p mm in the bison > command line? The Makefile passes -Werror from external flags to some but not other invocations of the compiler; those spew warnings but don't cause the build to fail. Obviously, if we wanted to polish the driver it'd be nice to fix those warnings, but as I mentioned above that's currently not my itch to scratch. Meow!
diff --git a/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c b/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c index 975fcfcc0d8f..2cd87ea86dfc 100644 --- a/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c +++ b/drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c @@ -45,6 +45,7 @@ #include <sys/types.h> #include "aicdb.h" +#include <ctype.h> #include <fcntl.h> #include <inttypes.h> #include <regex.h>
This is an userland helper tool to generate data rather than something compiled into the kernel, thus it wants regular POSIX functions. Signed-off-by: Adam Borowski <kilobyte@angband.pl> --- drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c | 1 + 1 file changed, 1 insertion(+)