diff mbox series

[RESEND,1/1] multi-process: fix usage information

Message ID 20210713004718.20381-1-dongli.zhang@oracle.com (mailing list archive)
State New, archived
Headers show
Series [RESEND,1/1] multi-process: fix usage information | expand

Commit Message

Dongli Zhang July 13, 2021, 12:47 a.m. UTC
From source code, the 'devid' of x-remote-object should be one of devices
in remote QEMU process.

Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>
---
Resend to be applied as trivial patch.

I have verified by reading the code and playing with below orchestrator.
https://github.com/finallyjustice/sample/blob/master/kvm/multiprocess/orchestrator.py

 docs/system/multi-process.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Vivier Sept. 16, 2021, 10:06 a.m. UTC | #1
Le 13/07/2021 à 02:47, Dongli Zhang a écrit :
> From source code, the 'devid' of x-remote-object should be one of devices
> in remote QEMU process.
> 
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>
> ---
> Resend to be applied as trivial patch.
> 
> I have verified by reading the code and playing with below orchestrator.
> https://github.com/finallyjustice/sample/blob/master/kvm/multiprocess/orchestrator.py
> 
>  docs/system/multi-process.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/system/multi-process.rst b/docs/system/multi-process.rst
> index 46bb0cafc2..210531ee17 100644
> --- a/docs/system/multi-process.rst
> +++ b/docs/system/multi-process.rst
> @@ -45,7 +45,7 @@ Following is a description of command-line used to launch mpqemu.
>        -device lsi53c895a,id=lsi0                                         \
>        -drive id=drive_image2,file=/build/ol7-nvme-test-1.qcow2           \
>        -device scsi-hd,id=drive2,drive=drive_image2,bus=lsi0.0,scsi-id=0  \
> -      -object x-remote-object,id=robj1,devid=lsi1,fd=4,
> +      -object x-remote-object,id=robj1,devid=lsi0,fd=4,
>  
>  * QEMU:
>  
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Laurent Vivier Sept. 23, 2021, 3:16 p.m. UTC | #2
Le 13/07/2021 à 02:47, Dongli Zhang a écrit :
> From source code, the 'devid' of x-remote-object should be one of devices
> in remote QEMU process.
> 
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>
> ---
> Resend to be applied as trivial patch.
> 
> I have verified by reading the code and playing with below orchestrator.
> https://github.com/finallyjustice/sample/blob/master/kvm/multiprocess/orchestrator.py
> 
>  docs/system/multi-process.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/system/multi-process.rst b/docs/system/multi-process.rst
> index 46bb0cafc2..210531ee17 100644
> --- a/docs/system/multi-process.rst
> +++ b/docs/system/multi-process.rst
> @@ -45,7 +45,7 @@ Following is a description of command-line used to launch mpqemu.
>        -device lsi53c895a,id=lsi0                                         \
>        -drive id=drive_image2,file=/build/ol7-nvme-test-1.qcow2           \
>        -device scsi-hd,id=drive2,drive=drive_image2,bus=lsi0.0,scsi-id=0  \
> -      -object x-remote-object,id=robj1,devid=lsi1,fd=4,
> +      -object x-remote-object,id=robj1,devid=lsi0,fd=4,
>  
>  * QEMU:
>  
> 


Applied to my trivial-patches branch.

Thanks,
Laurent
diff mbox series

Patch

diff --git a/docs/system/multi-process.rst b/docs/system/multi-process.rst
index 46bb0cafc2..210531ee17 100644
--- a/docs/system/multi-process.rst
+++ b/docs/system/multi-process.rst
@@ -45,7 +45,7 @@  Following is a description of command-line used to launch mpqemu.
       -device lsi53c895a,id=lsi0                                         \
       -drive id=drive_image2,file=/build/ol7-nvme-test-1.qcow2           \
       -device scsi-hd,id=drive2,drive=drive_image2,bus=lsi0.0,scsi-id=0  \
-      -object x-remote-object,id=robj1,devid=lsi1,fd=4,
+      -object x-remote-object,id=robj1,devid=lsi0,fd=4,
 
 * QEMU: