mbox series

[v2,0/3] KVM: selftests: Small fixes for dirty_log_perf_test

Message ID 20210917173657.44011-1-dmatlack@google.com (mailing list archive)
Headers show
Series KVM: selftests: Small fixes for dirty_log_perf_test | expand

Message

David Matlack Sept. 17, 2021, 5:36 p.m. UTC
This series fixes 2 bugs in dirty_log_perf_test:
 - Incorrect interleaving of help messages for -s and -x (patch 2)
 - Buffer overflow when using multiple slots (patch 3)

Both bugs were introduced by commit 609e6202ea5f ("KVM: selftests:
Support multiple slots in dirty_log_perf_test").

Patch 1 is a small tangentially related cleanup to use a consistent
flag for the backing source across all selftests.

v2:
 - Add Ben and Andrew's SOB to patches 1 and 2
 - Delete stray newline in patch 2 [Andrew]
 - Make print_available_backing_src_types static [Andrew]
 - Create a separate dirty bitmap per slot [Andrew, Ben]

v1: https://lore.kernel.org/kvm/20210915213034.1613552-1-dmatlack@google.com/

David Matlack (3):
  KVM: selftests: Change backing_src flag to -s in demand_paging_test
  KVM: selftests: Refactor help message for -s backing_src
  KVM: selftests: Create a separate dirty bitmap per slot

 .../selftests/kvm/access_tracking_perf_test.c |  6 +-
 .../selftests/kvm/demand_paging_test.c        | 13 ++--
 .../selftests/kvm/dirty_log_perf_test.c       | 63 +++++++++++++------
 .../testing/selftests/kvm/include/test_util.h |  4 +-
 .../selftests/kvm/kvm_page_table_test.c       |  7 +--
 tools/testing/selftests/kvm/lib/test_util.c   | 17 +++--
 6 files changed, 69 insertions(+), 41 deletions(-)

Comments

Paolo Bonzini Sept. 22, 2021, 1:10 p.m. UTC | #1
On 17/09/21 19:36, David Matlack wrote:
> This series fixes 2 bugs in dirty_log_perf_test:
>   - Incorrect interleaving of help messages for -s and -x (patch 2)
>   - Buffer overflow when using multiple slots (patch 3)
> 
> Both bugs were introduced by commit 609e6202ea5f ("KVM: selftests:
> Support multiple slots in dirty_log_perf_test").
> 
> Patch 1 is a small tangentially related cleanup to use a consistent
> flag for the backing source across all selftests.
> 
> v2:
>   - Add Ben and Andrew's SOB to patches 1 and 2
>   - Delete stray newline in patch 2 [Andrew]
>   - Make print_available_backing_src_types static [Andrew]
>   - Create a separate dirty bitmap per slot [Andrew, Ben]
> 
> v1: https://lore.kernel.org/kvm/20210915213034.1613552-1-dmatlack@google.com/
> 
> David Matlack (3):
>    KVM: selftests: Change backing_src flag to -s in demand_paging_test
>    KVM: selftests: Refactor help message for -s backing_src
>    KVM: selftests: Create a separate dirty bitmap per slot
> 
>   .../selftests/kvm/access_tracking_perf_test.c |  6 +-
>   .../selftests/kvm/demand_paging_test.c        | 13 ++--
>   .../selftests/kvm/dirty_log_perf_test.c       | 63 +++++++++++++------
>   .../testing/selftests/kvm/include/test_util.h |  4 +-
>   .../selftests/kvm/kvm_page_table_test.c       |  7 +--
>   tools/testing/selftests/kvm/lib/test_util.c   | 17 +++--
>   6 files changed, 69 insertions(+), 41 deletions(-)
> 

Queued these now, thanks.

Paolo