mbox series

[v1,net,0/1] net: mscc: ocelot: broadcast storm fixup

Message ID 20210923020338.1945812-1-colin.foster@in-advantage.com (mailing list archive)
Headers show
Series net: mscc: ocelot: broadcast storm fixup | expand

Message

Colin Foster Sept. 23, 2021, 2:03 a.m. UTC 
Ocelot ports would still forward out ethernet broadcasts when they were
in the LEARNING or BLOCKING state. This is due to the
ocelot_get_bridge_fwd_mask, which would tell disabled ports to forward
packets out all FORWARDING ports. Broadcast storms would insue.

This patch restores the functionality of disabling forwarding for ports 
that aren't in the FORWARDING state. No more broadcast storms.

Tested and verified on an in-development driver, and Vladimir has done
independent testing and verification on supported hardware.


Vladimir Oltean (1):
  net: mscc: ocelot: fix forwarding from BLOCKING ports remaining
    enabled

 drivers/net/ethernet/mscc/ocelot.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 23, 2021, 12:20 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 22 Sep 2021 19:03:37 -0700 you wrote:
> Ocelot ports would still forward out ethernet broadcasts when they were
> in the LEARNING or BLOCKING state. This is due to the
> ocelot_get_bridge_fwd_mask, which would tell disabled ports to forward
> packets out all FORWARDING ports. Broadcast storms would insue.
> 
> This patch restores the functionality of disabling forwarding for ports
> that aren't in the FORWARDING state. No more broadcast storms.
> 
> [...]

Here is the summary with links:
  - [v1,net,1/1] net: mscc: ocelot: fix forwarding from BLOCKING ports remaining enabled
    https://git.kernel.org/netdev/net/c/acc64f52afac

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html