| Message ID | c52733a1cd9a7bd16aea0b6e056fad9dd1cc5aed.1632240523.git.cdleonard@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | tcp: Initial support for RFC5925 auth option | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | fail | Series longer than 15 patches |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | fail | Errors and warnings before: 5 this patch: 5 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 24 lines checked |
| netdev/build_allmodconfig_warn | fail | Errors and warnings before: 5 this patch: 5 |
| netdev/header_inline | success | Link |
On 9/21/21 10:15 AM, Leonard Crestez wrote: > This script is otherwise very slow to run! there are a lot of permutations to cover. > > Signed-off-by: Leonard Crestez <cdleonard@gmail.com> > --- > tools/testing/selftests/net/fcnal-test.sh | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh > index 74a7580b6bde..484734db708f 100755 > --- a/tools/testing/selftests/net/fcnal-test.sh > +++ b/tools/testing/selftests/net/fcnal-test.sh > @@ -1331,10 +1331,21 @@ ipv4_tcp() > log_subsection "With VRF" > setup "yes" > ipv4_tcp_vrf > } > > + > +only_tcp_authopt() > +{ > + log_section "TCP Authentication" > + setup > + set_sysctl net.ipv4.tcp_l3mdev_accept=0 > + log_subsection "IPv4 no VRF" > + ipv4_tcp_authopt This feature needs to work with VRF from the beginning. v4, v6, with and without VRF. > +} > + > + > ################################################################################ > # IPv4 UDP > > ipv4_udp_novrf() > { > @@ -4021,10 +4032,11 @@ do > ipv6_bind|bind6) ipv6_addr_bind;; > ipv6_runtime) ipv6_runtime;; > ipv6_netfilter) ipv6_netfilter;; > > use_cases) use_cases;; > + tcp_authopt) only_tcp_authopt;; > > # setup namespaces and config, but do not run any tests > setup) setup; exit 0;; > vrf_setup) setup "yes"; exit 0;; > > This patch can be folded into the previous one, and the drop the only_tcp_authopt function. The script has always allowed a single test to be run by name (-t arg), so '-t tcp_authopt' runs tcp_authopt which covers v4 and v6 with and without vrf.
On 9/25/21 4:52 AM, David Ahern wrote: > On 9/21/21 10:15 AM, Leonard Crestez wrote: >> This script is otherwise very slow to run! > > there are a lot of permutations to cover. I believe that some of the sleeps are not necessary and could be replaced with waits. >> >> Signed-off-by: Leonard Crestez <cdleonard@gmail.com> >> --- >> tools/testing/selftests/net/fcnal-test.sh | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh >> index 74a7580b6bde..484734db708f 100755 >> --- a/tools/testing/selftests/net/fcnal-test.sh >> +++ b/tools/testing/selftests/net/fcnal-test.sh >> @@ -1331,10 +1331,21 @@ ipv4_tcp() >> log_subsection "With VRF" >> setup "yes" >> ipv4_tcp_vrf >> } >> >> + >> +only_tcp_authopt() >> +{ >> + log_section "TCP Authentication" >> + setup >> + set_sysctl net.ipv4.tcp_l3mdev_accept=0 >> + log_subsection "IPv4 no VRF" >> + ipv4_tcp_authopt > > This feature needs to work with VRF from the beginning. v4, v6, with and > without VRF. I ignored the l3mdev feature because I'm not familiar with it but I'll go through it. -- Regards, Leonard
diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh index 74a7580b6bde..484734db708f 100755 --- a/tools/testing/selftests/net/fcnal-test.sh +++ b/tools/testing/selftests/net/fcnal-test.sh @@ -1331,10 +1331,21 @@ ipv4_tcp() log_subsection "With VRF" setup "yes" ipv4_tcp_vrf } + +only_tcp_authopt() +{ + log_section "TCP Authentication" + setup + set_sysctl net.ipv4.tcp_l3mdev_accept=0 + log_subsection "IPv4 no VRF" + ipv4_tcp_authopt +} + + ################################################################################ # IPv4 UDP ipv4_udp_novrf() { @@ -4021,10 +4032,11 @@ do ipv6_bind|bind6) ipv6_addr_bind;; ipv6_runtime) ipv6_runtime;; ipv6_netfilter) ipv6_netfilter;; use_cases) use_cases;; + tcp_authopt) only_tcp_authopt;; # setup namespaces and config, but do not run any tests setup) setup; exit 0;; vrf_setup) setup "yes"; exit 0;;
This script is otherwise very slow to run! Signed-off-by: Leonard Crestez <cdleonard@gmail.com> --- tools/testing/selftests/net/fcnal-test.sh | 12 ++++++++++++ 1 file changed, 12 insertions(+)