| Message ID | 20210901083215.25984-1-yunfei.dong@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Using component framework to support multi hardware decode | expand |
On Wed, 1 Sept 2021 at 05:32, Yunfei Dong <yunfei.dong@mediatek.com> wrote: > > This series adds support for multi hardware decode into mtk-vcodec, by first > adding component framework to manage each hardware information: interrupt, > clock, register bases and power. Secondly add core thread to deal with core > hardware message, at the same time, add msg queue for different hardware > share messages. Lastly, the architecture of different specs are not the same, > using specs type to separate them. > > This series has been tested with both MT8183 and MT8173. Decoding was working > for both chips. > > Patches 1~3 rewrite get register bases and power on/off interface. > > Patch 4 add component framework to support multi hardware. > > Patch 5 separate video encoder and decoder document > > Patches 6-15 add interfaces to support core hardware. > ---- > This patch dependents on : "media: mtk-vcodec: support for MT8183 decoder"[1] and > "Mediatek MT8192 clock support"[2]. > > 1: Multi hardware decode is based on stateless decoder, MT8183 is the first time > to add stateless decoder. Otherwise it will cause conflict. This patch will be > accepted in 5.15[1]. > > 2: The definition of decoder clocks are in mt8192-clk.h, this patch already in clk tree[2]. > > [1]https://patchwork.linuxtv.org/project/linux-media/list/?series=5826 > [2]https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=f35f1a23e0e12e3173e9e9dedbc150d139027189 > ---- > Changes compared with v5: > -Add decoder hardware block diagram for patch 13/15 > The discussion on v5 was still on-going, so sending this v6 is not helpful. The context for v5's discussion is now harder to find. Please avoid sending a new version without properly discussing all the feedback, and without reaching consensus. This is very important, please keep it in mind. Specifically, the feedback on v5 was NAK, with the request to avoid using any async framework, and instead try to find a simpler solution. For instance, you can model things with a bus-like pattern, which ties all the devices together, under a parent node. This pattern is common in the kernel, the parent node can use of_platform_populate or similar (git grep of_platform_populate, you will see plenty of examples). You will still have to do some work to have the proper regs resources, but this is doable. Each child is a device, so it can have its own resources (clocks, interrupts, iommus). You don't need any async framework. vcodec_dec: vcodec_dec@16000000 { compatible = "mediatek,mt8192-vcodec-dec"; reg = <something>; mediatek,scp = <&scp>; iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>; dma-ranges = <0x1 0x0 0x0 0x40000000 0x0 0xfff00000>; vcodec_lat@0x10000 { compatible = "mediatek,mtk-vcodec-lat"; reg = <0x10000 0x800>; /* VDEC_MISC */ interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH 0>; // etc }; vcodec_core@0x25000 { compatible = "mediatek,mtk-vcodec-core"; reg = <0x25000 0x1000>; /* VDEC_CORE_MISC */ interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH 0>; // etc }; }; Thanks, Ezequiel
Hi Ezequiel, Thanks for your suggestion. On Thu, 2021-09-02 at 13:30 -0300, Ezequiel Garcia wrote: > On Wed, 1 Sept 2021 at 05:32, Yunfei Dong <yunfei.dong@mediatek.com> > wrote: > > > > This series adds support for multi hardware decode into mtk-vcodec, > > by first > > adding component framework to manage each hardware information: > > interrupt, > > clock, register bases and power. Secondly add core thread to deal > > with core > > hardware message, at the same time, add msg queue for different > > hardware > > share messages. Lastly, the architecture of different specs are not > > the same, > > using specs type to separate them. > > > > This series has been tested with both MT8183 and MT8173. Decoding > > was working > > for both chips. > > > > Patches 1~3 rewrite get register bases and power on/off interface. > > > > Patch 4 add component framework to support multi hardware. > > > > Patch 5 separate video encoder and decoder document > > > > Patches 6-15 add interfaces to support core hardware. > > ---- > > This patch dependents on : "media: mtk-vcodec: support for MT8183 > > decoder"[1] and > > "Mediatek MT8192 clock support"[2]. > > > > 1: Multi hardware decode is based on stateless decoder, MT8183 is > > the first time > > to add stateless decoder. Otherwise it will cause conflict. This > > patch will be > > accepted in 5.15[1]. > > > > 2: The definition of decoder clocks are in mt8192-clk.h, this patch > > already in clk tree[2]. > > > > [1] > > https://patchwork.linuxtv.org/project/linux-media/list/?series=5826 > > [2] > > https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=f35f1a23e0e12e3173e9e9dedbc150d139027189 > > ---- > > Changes compared with v5: > > -Add decoder hardware block diagram for patch 13/15 > > > > > The discussion on v5 was still on-going, so sending this v6 > is not helpful. The context for v5's discussion is now harder to > find. > > Please avoid sending a new version without properly > discussing all the feedback, and without reaching consensus. > This is very important, please keep it in mind. > Thanks for your remind, I will keep this patch until get the solution. > Specifically, the feedback on v5 was NAK, with the request to avoid > using any async framework, and instead try to find a simpler > solution. > > For instance, you can model things with a bus-like pattern, > which ties all the devices together, under a parent node. > This pattern is common in the kernel, the parent > node can use of_platform_populate or similar > (git grep of_platform_populate, you will see plenty of examples). > > You will still have to do some work to have the proper > regs resources, but this is doable. Each child is a device, > so it can have its own resources (clocks, interrupts, iommus). > > You don't need any async framework. > If put the lat and core node in the parent node, need to check the below things after discussed with iommu owner. If putting the iommus property in the child node, then is the child device a standard platform device? The iommu registe like this: ret = bus_set_iommu(&platform_bus_type, &mtk_iommu_ops); It expect the consumer is a standard platform device. otherwise it could not enter to the iommu of_xlate.) Thanks Yunfei Dong > vcodec_dec: vcodec_dec@16000000 { > compatible = "mediatek,mt8192-vcodec-dec"; > reg = <something>; > mediatek,scp = <&scp>; > iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>; > dma-ranges = <0x1 0x0 0x0 0x40000000 0x0 0xfff00000>; > > vcodec_lat@0x10000 { > compatible = "mediatek,mtk-vcodec-lat"; > reg = <0x10000 0x800>; /* VDEC_MISC */ > interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH 0>; > // etc > }; > > vcodec_core@0x25000 { > compatible = "mediatek,mtk-vcodec-core"; > reg = <0x25000 0x1000>; /* VDEC_CORE_MISC */ > interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH 0>; > // etc > }; > }; > > Thanks, > Ezequiel
On Fri, Sep 3, 2021 at 12:31 AM Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote: > > On Wed, 1 Sept 2021 at 05:32, Yunfei Dong <yunfei.dong@mediatek.com> wrote: > > > > This series adds support for multi hardware decode into mtk-vcodec, by first > > adding component framework to manage each hardware information: interrupt, > > clock, register bases and power. Secondly add core thread to deal with core > > hardware message, at the same time, add msg queue for different hardware > > share messages. Lastly, the architecture of different specs are not the same, > > using specs type to separate them. > > > > This series has been tested with both MT8183 and MT8173. Decoding was working > > for both chips. > > > > Patches 1~3 rewrite get register bases and power on/off interface. > > > > Patch 4 add component framework to support multi hardware. > > > > Patch 5 separate video encoder and decoder document > > > > Patches 6-15 add interfaces to support core hardware. > > ---- > > This patch dependents on : "media: mtk-vcodec: support for MT8183 decoder"[1] and > > "Mediatek MT8192 clock support"[2]. > > > > 1: Multi hardware decode is based on stateless decoder, MT8183 is the first time > > to add stateless decoder. Otherwise it will cause conflict. This patch will be > > accepted in 5.15[1]. > > > > 2: The definition of decoder clocks are in mt8192-clk.h, this patch already in clk tree[2]. > > > > [1]https://patchwork.linuxtv.org/project/linux-media/list/?series=5826 > > [2]https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=f35f1a23e0e12e3173e9e9dedbc150d139027189 > > ---- > > Changes compared with v5: > > -Add decoder hardware block diagram for patch 13/15 > > > > > The discussion on v5 was still on-going, so sending this v6 > is not helpful. The context for v5's discussion is now harder to find. > > Please avoid sending a new version without properly > discussing all the feedback, and without reaching consensus. > This is very important, please keep it in mind. > > Specifically, the feedback on v5 was NAK, with the request to avoid > using any async framework, and instead try to find a simpler solution. > > For instance, you can model things with a bus-like pattern, > which ties all the devices together, under a parent node. > This pattern is common in the kernel, the parent > node can use of_platform_populate or similar > (git grep of_platform_populate, you will see plenty of examples). > > You will still have to do some work to have the proper > regs resources, but this is doable. Each child is a device, > so it can have its own resources (clocks, interrupts, iommus). AFAIK of_platform_populate doesn't guarantee the drivers actually probed (modules loaded late, missing modules, deferred probe, etc.), only that the devices are created, so you still need some sort of (async) mechanism to wait for the subdevices to be in operational state. Most of the examples using of_platform_populate are there to ensure that the parent device is operational before creating the sub-devices, not the other way around. ChenYu > You don't need any async framework. > > vcodec_dec: vcodec_dec@16000000 { > compatible = "mediatek,mt8192-vcodec-dec"; > reg = <something>; > mediatek,scp = <&scp>; > iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>; > dma-ranges = <0x1 0x0 0x0 0x40000000 0x0 0xfff00000>; > > vcodec_lat@0x10000 { > compatible = "mediatek,mtk-vcodec-lat"; > reg = <0x10000 0x800>; /* VDEC_MISC */ > interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH 0>; > // etc > }; > > vcodec_core@0x25000 { > compatible = "mediatek,mtk-vcodec-core"; > reg = <0x25000 0x1000>; /* VDEC_CORE_MISC */ > interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH 0>; > // etc > }; > }; > > Thanks, > Ezequiel > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
Hi Ezequiel, On Fri, 2021-09-03 at 11:08 +0800, yunfei.dong@mediatek.com wrote: > Hi Ezequiel, > > Thanks for your suggestion. > On Thu, 2021-09-02 at 13:30 -0300, Ezequiel Garcia wrote: > > On Wed, 1 Sept 2021 at 05:32, Yunfei Dong <yunfei.dong@mediatek.com > > > > > wrote: > > > > > > This series adds support for multi hardware decode into mtk- > > > vcodec, > > > by first > > > adding component framework to manage each hardware information: > > > interrupt, > > > clock, register bases and power. Secondly add core thread to deal > > > with core > > > hardware message, at the same time, add msg queue for different > > > hardware > > > share messages. Lastly, the architecture of different specs are > > > not > > > the same, > > > using specs type to separate them. > > > > > > This series has been tested with both MT8183 and MT8173. Decoding > > > was working > > > for both chips. > > > > > > Patches 1~3 rewrite get register bases and power on/off > > > interface. > > > > > > Patch 4 add component framework to support multi hardware. > > > > > > Patch 5 separate video encoder and decoder document > > > > > > Patches 6-15 add interfaces to support core hardware. > > > ---- > > > This patch dependents on : "media: mtk-vcodec: support for MT8183 > > > decoder"[1] and > > > "Mediatek MT8192 clock support"[2]. > > > > > > 1: Multi hardware decode is based on stateless decoder, MT8183 is > > > the first time > > > to add stateless decoder. Otherwise it will cause conflict. This > > > patch will be > > > accepted in 5.15[1]. > > > > > > 2: The definition of decoder clocks are in mt8192-clk.h, this > > > patch > > > already in clk tree[2]. > > > > > > [1] > > > https://patchwork.linuxtv.org/project/linux-media/list/?series=5826 > > > [2] > > > https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=f35f1a23e0e12e3173e9e9dedbc150d139027189 > > > ---- > > > Changes compared with v5: > > > -Add decoder hardware block diagram for patch 13/15 > > > > > > > > > The discussion on v5 was still on-going, so sending this v6 > > is not helpful. The context for v5's discussion is now harder to > > find. > > > > Please avoid sending a new version without properly > > discussing all the feedback, and without reaching consensus. > > This is very important, please keep it in mind. > > > > Thanks for your remind, I will keep this patch until get the > solution. > > > Specifically, the feedback on v5 was NAK, with the request to avoid > > using any async framework, and instead try to find a simpler > > solution. > > > > For instance, you can model things with a bus-like pattern, > > which ties all the devices together, under a parent node. > > This pattern is common in the kernel, the parent > > node can use of_platform_populate or similar > > (git grep of_platform_populate, you will see plenty of examples). > > > > You will still have to do some work to have the proper > > regs resources, but this is doable. Each child is a device, > > so it can have its own resources (clocks, interrupts, iommus). > > > > You don't need any async framework. > > > Thanks for your suggestion very much, and there are several actions need to check. 1: The iommu register like this: ret = bus_set_iommu(&platform_bus_type, &mtk_iommu_ops); It expect the consumer is a standard platform device. otherwise it could not enter to the iommu of_xlate.) So if putting the iommus property in the child node, all the child device need to registered as platform device. 2: For the interrupt in each child node, but the logical processing in parent part. Child and parent need to send message for each other. In order to control clk/power/irq for multi instance, need send message to child to separate different hardware; child also need send message to parent when get interrupt. 3: About Chen-Yu's mail, do you have any advice? Do you have any suggestion about these two scenarios? I'm very happy to get your reply. Thanks Yunfei Dong > > vcodec_dec: vcodec_dec@16000000 { > > compatible = "mediatek,mt8192-vcodec-dec"; > > reg = <something>; > > mediatek,scp = <&scp>; > > iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>; > > dma-ranges = <0x1 0x0 0x0 0x40000000 0x0 0xfff00000>; > > > > vcodec_lat@0x10000 { > > compatible = "mediatek,mtk-vcodec-lat"; > > reg = <0x10000 0x800>; /* VDEC_MISC */ > > interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH 0>; > > // etc > > }; > > > > vcodec_core@0x25000 { > > compatible = "mediatek,mtk-vcodec-core"; > > reg = <0x25000 0x1000>; /* VDEC_CORE_MISC */ > > interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH 0>; > > // etc > > }; > > }; > > > > Thanks, > > Ezequiel
Hi Ezequiel, Could you please help to give some feedback when you are free for iommu limitation? According to google's suggestion, it's better not to use v4l2 async also. If there are no further comments, I don't have other choice for this architecture. Thanks, Yunfei Dong On Tue, 2021-09-14 at 20:16 +0800, yunfei.dong@mediatek.com wrote: > Hi Ezequiel, > > On Fri, 2021-09-03 at 11:08 +0800, yunfei.dong@mediatek.com wrote: > > Hi Ezequiel, > > > > Thanks for your suggestion. > > On Thu, 2021-09-02 at 13:30 -0300, Ezequiel Garcia wrote: > > > On Wed, 1 Sept 2021 at 05:32, Yunfei Dong < > > > yunfei.dong@mediatek.com > > > > > > > > > > wrote: > > > > > > > > This series adds support for multi hardware decode into mtk- > > > > vcodec, > > > > by first > > > > adding component framework to manage each hardware information: > > > > interrupt, > > > > clock, register bases and power. Secondly add core thread to > > > > deal > > > > with core > > > > hardware message, at the same time, add msg queue for different > > > > hardware > > > > share messages. Lastly, the architecture of different specs are > > > > not > > > > the same, > > > > using specs type to separate them. > > > > > > > > This series has been tested with both MT8183 and MT8173. > > > > Decoding > > > > was working > > > > for both chips. > > > > > > > > Patches 1~3 rewrite get register bases and power on/off > > > > interface. > > > > > > > > Patch 4 add component framework to support multi hardware. > > > > > > > > Patch 5 separate video encoder and decoder document > > > > > > > > Patches 6-15 add interfaces to support core hardware. > > > > ---- > > > > This patch dependents on : "media: mtk-vcodec: support for > > > > MT8183 > > > > decoder"[1] and > > > > "Mediatek MT8192 clock support"[2]. > > > > > > > > 1: Multi hardware decode is based on stateless decoder, MT8183 > > > > is > > > > the first time > > > > to add stateless decoder. Otherwise it will cause conflict. > > > > This > > > > patch will be > > > > accepted in 5.15[1]. > > > > > > > > 2: The definition of decoder clocks are in mt8192-clk.h, this > > > > patch > > > > already in clk tree[2]. > > > > > > > > [1] > > > > > > https://patchwork.linuxtv.org/project/linux-media/list/?series=5826 > > > > [2] > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=f35f1a23e0e12e3173e9e9dedbc150d139027189 > > > > ---- > > > > Changes compared with v5: > > > > -Add decoder hardware block diagram for patch 13/15 > > > > > > > > > > > > > The discussion on v5 was still on-going, so sending this v6 > > > is not helpful. The context for v5's discussion is now harder to > > > find. > > > > > > Please avoid sending a new version without properly > > > discussing all the feedback, and without reaching consensus. > > > This is very important, please keep it in mind. > > > > > > > Thanks for your remind, I will keep this patch until get the > > solution. > > > > > Specifically, the feedback on v5 was NAK, with the request to > > > avoid > > > using any async framework, and instead try to find a simpler > > > solution. > > > > > > For instance, you can model things with a bus-like pattern, > > > which ties all the devices together, under a parent node. > > > This pattern is common in the kernel, the parent > > > node can use of_platform_populate or similar > > > (git grep of_platform_populate, you will see plenty of examples). > > > > > > You will still have to do some work to have the proper > > > regs resources, but this is doable. Each child is a device, > > > so it can have its own resources (clocks, interrupts, iommus). > > > > > > You don't need any async framework. > > > > > Thanks for your suggestion very much, and there are several actions > need to check. > > 1: The iommu register like this: > ret = bus_set_iommu(&platform_bus_type, > &mtk_iommu_ops); > It expect the consumer is a standard platform device. > otherwise it > could not enter to the iommu of_xlate.) > > So if putting the iommus property in the child node, all the child > device need to registered as platform device. > > 2: For the interrupt in each child node, but the logical processing > in > parent part. Child and parent need to send message for each other. In > order to control clk/power/irq for multi instance, need send message > to > child to separate different hardware; child also need send message to > parent when get interrupt. > > 3: About Chen-Yu's mail, do you have any advice? > > Do you have any suggestion about these two scenarios? > I'm very happy to get your reply. > > Thanks > Yunfei Dong > > > > vcodec_dec: vcodec_dec@16000000 { > > > compatible = "mediatek,mt8192-vcodec-dec"; > > > reg = <something>; > > > mediatek,scp = <&scp>; > > > iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>; > > > dma-ranges = <0x1 0x0 0x0 0x40000000 0x0 0xfff00000>; > > > > > > vcodec_lat@0x10000 { > > > compatible = "mediatek,mtk-vcodec-lat"; > > > reg = <0x10000 0x800>; /* VDEC_MISC */ > > > interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH 0>; > > > // etc > > > }; > > > > > > vcodec_core@0x25000 { > > > compatible = "mediatek,mtk-vcodec-core"; > > > reg = <0x25000 0x1000>; /* VDEC_CORE_MISC */ > > > interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH 0>; > > > // etc > > > }; > > > }; > > > > > > Thanks, > > > Ezequiel
On Sun, 26 Sept 2021 at 05:27, yunfei.dong@mediatek.com <yunfei.dong@mediatek.com> wrote: > > Hi Ezequiel, > > Could you please help to give some feedback when you are free for iommu > limitation? > How about you work on the architecture I originally suggested? As the saying goes, talk is cheap, show us the code. So let's see the code and let's discuss the limitations with the code. > According to google's suggestion, it's better not to use v4l2 async > also. Hum? I haven't seen such objection on the mailing list. Thanks, Ezequiel
Hi Yunfei, > This patch dependents on : "media: mtk-vcodec: support for MT8183 decoder"[1] and > "Mediatek MT8192 clock support"[2]. > > 1: Multi hardware decode is based on stateless decoder, MT8183 is the first time > to add stateless decoder. Otherwise it will cause conflict. This patch will be > accepted in 5.15[1]. Just a few basic questions. What kind of "conflict" are you expecting here? Are you referring to kernel "5.15" here? Probably not. If yes, then that sounds strange to me considering our current kernel uprev plans and current kernel used for MT8183. > 2: The definition of decoder clocks are in mt8192-clk.h, this patch already in clk tree[2]. > > [1]https://patchwork.linuxtv.org/project/linux-media/list/?series=5826 This link seems to be no longer available. > [2]https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=f35f1a23e0e12e3173e9e9dedbc150d139027189
Hi Ezequiel, Thank you for reviewing these series from Yunfei! This series is one of the main obstacles for us at the moment for MTK so please continue to help & support reviewing this series. > > According to google's suggestion, it's better not to use v4l2 async > > also. > > Hum? I haven't seen such objection on the mailing list. Maybe coming from Tzung-Bi? Yunfei, please let us know. Steve
> > [1]https://patchwork.linuxtv.org/project/linux-media/list/?series=5826 > This link seems to be no longer available. It is probably because the default state is "Action Required", and this series was accepted recently afterwards. I can see the series with the below link. https://patchwork.linuxtv.org/project/linux-media/list/?series=5826&state=* Sorry for the confusion. Steve
On Tue, Sep 28, 2021 at 2:02 AM Steve Cho <stevecho@chromium.org> wrote: > > Hi Ezequiel, > > Thank you for reviewing these series from Yunfei! > This series is one of the main obstacles for us at the moment for MTK > so please continue to help & support reviewing this series. > > > > According to google's suggestion, it's better not to use v4l2 async > > > also. > > > > Hum? I haven't seen such objection on the mailing list. > Maybe coming from Tzung-Bi? > Yunfei, please let us know. I do object to using V4L2 async. It's designed for independent components of media pipelines, handled by multiple different drivers and also modelled as V4L2 subdevices. We don't have anything like that here. How about just open coding something trivial that only fits the needs of this specific driver? I think it would be as simple as a linked list and registering the V4L2 devices only after all the nodes probe. Best regards, Tomasz
Hi Ezequiel, Thanks for your feedback, The driver can work well now according to your advice with of_platform_populate interface. In order to separate parent node with children node, parent node is master device, children node is component device. The master and component are registered platform device. Could you please help to review the patch again when you are free: https://patchwork.linuxtv.org/project/linux-media/cover/20211011070247.792-1-yunfei.dong@mediatek.com/ Best Regards, Yunfei Dong On Sun, 2021-09-26 at 11:51 -0300, Ezequiel Garcia wrote: > On Sun, 26 Sept 2021 at 05:27, yunfei.dong@mediatek.com > <yunfei.dong@mediatek.com> wrote: > > > > Hi Ezequiel, > > > > Could you please help to give some feedback when you are free for > > iommu > > limitation? > > > > How about you work on the architecture I originally suggested? > > As the saying goes, talk is cheap, show us the code. > So let's see the code and let's discuss the limitations > with the code. > > > According to google's suggestion, it's better not to use v4l2 async > > also. > > Hum? I haven't seen such objection on the mailing list. > > Thanks, > Ezequiel
Hi Yunfei, On Tue, 12 Oct 2021 at 22:17, yunfei.dong@mediatek.com <yunfei.dong@mediatek.com> wrote: > > Hi Ezequiel, > > Thanks for your feedback, > > The driver can work well now according to your advice with > of_platform_populate interface. > > In order to separate parent node with children node, parent node is > master device, children node is component device. > > The master and component are registered platform device. > > > Could you please help to review the patch again when you are free: > > https://patchwork.linuxtv.org/project/linux-media/cover/20211011070247.792-1-yunfei.dong@mediatek.com/ > I'm glad you managed to simplify the driver. I tried applying the patches but they don't apply on media master. Please push a branch to gitlab or github or somewhere public. Keep in mind that when you need people to review your code, it's generally good practice to try to make it easy on them. The harder you make it, the less inclined people will be to spend time on your work. Thanks, Ezequiel