| Message ID | 20210928192338.1987872-1-nathan@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/kmb: Remove set_test_mode_src_osc_freq_target_{hi, low}_bits() | expand |
Thanks for the patch. Looks good. Acked-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com> > -----Original Message----- > From: Nathan Chancellor <nathan@kernel.org> > Sent: Tuesday, September 28, 2021 12:24 PM > To: Chrisanthus, Anitha <anitha.chrisanthus@intel.com>; Dea, Edmund J > <edmund.j.dea@intel.com> > Cc: Geert Uytterhoeven <geert@linux-m68k.org>; Nick Desaulniers > <ndesaulniers@google.com>; dri-devel@lists.freedesktop.org; linux- > kernel@vger.kernel.org; llvm@lists.linux.dev; Nathan Chancellor > <nathan@kernel.org>; lkp <lkp@intel.com> > Subject: [PATCH] drm/kmb: Remove > set_test_mode_src_osc_freq_target_{hi,low}_bits() > > clang with W=1 warns: > > drivers/gpu/drm/kmb/kmb_dsi.c:812:2: error: unused function > 'set_test_mode_src_osc_freq_target_low_bits' [-Werror,-Wunused-function] > set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi, > ^ > drivers/gpu/drm/kmb/kmb_dsi.c:824:2: error: unused function > 'set_test_mode_src_osc_freq_target_hi_bits' [-Werror,-Wunused-function] > set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi, > ^ > 2 errors generated. > > Remove them, as they have been unused since the driver's introduction in > commit 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver"). > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/gpu/drm/kmb/kmb_dsi.c | 28 ---------------------------- > 1 file changed, 28 deletions(-) > > diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c > b/drivers/gpu/drm/kmb/kmb_dsi.c > index 1793cd31b117..ae24c5fc35a5 100644 > --- a/drivers/gpu/drm/kmb/kmb_dsi.c > +++ b/drivers/gpu/drm/kmb/kmb_dsi.c > @@ -808,34 +808,6 @@ static void test_mode_send(struct kmb_dsi > *kmb_dsi, u32 dphy_no, > } > } > > -static inline void > - set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi > *kmb_dsi, > - u32 dphy_no, > - u32 freq) > -{ > - /* Typical rise/fall time=166, refer Table 1207 databook, > - * sr_osc_freq_target[7:0] > - */ > - test_mode_send(kmb_dsi, dphy_no, > TEST_CODE_SLEW_RATE_DDL_CYCLES, > - (freq & 0x7f)); > -} > - > -static inline void > - set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi, > - u32 dphy_no, > - u32 freq) > -{ > - u32 data; > - > - /* Flag this as high nibble */ > - data = ((freq >> 6) & 0x1f) | (1 << 7); > - > - /* Typical rise/fall time=166, refer Table 1207 databook, > - * sr_osc_freq_target[11:7] > - */ > - test_mode_send(kmb_dsi, dphy_no, > TEST_CODE_SLEW_RATE_DDL_CYCLES, data); > -} > - > static void mipi_tx_get_vco_params(struct vco_params *vco) > { > int i; > > base-commit: 93ee1a2c0f08345ab17c51198f725d4c95984f4c > -- > 2.33.0.591.gddb1055343
diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c index 1793cd31b117..ae24c5fc35a5 100644 --- a/drivers/gpu/drm/kmb/kmb_dsi.c +++ b/drivers/gpu/drm/kmb/kmb_dsi.c @@ -808,34 +808,6 @@ static void test_mode_send(struct kmb_dsi *kmb_dsi, u32 dphy_no, } } -static inline void - set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi, - u32 dphy_no, - u32 freq) -{ - /* Typical rise/fall time=166, refer Table 1207 databook, - * sr_osc_freq_target[7:0] - */ - test_mode_send(kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES, - (freq & 0x7f)); -} - -static inline void - set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi, - u32 dphy_no, - u32 freq) -{ - u32 data; - - /* Flag this as high nibble */ - data = ((freq >> 6) & 0x1f) | (1 << 7); - - /* Typical rise/fall time=166, refer Table 1207 databook, - * sr_osc_freq_target[11:7] - */ - test_mode_send(kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES, data); -} - static void mipi_tx_get_vco_params(struct vco_params *vco) { int i;
clang with W=1 warns: drivers/gpu/drm/kmb/kmb_dsi.c:812:2: error: unused function 'set_test_mode_src_osc_freq_target_low_bits' [-Werror,-Wunused-function] set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi, ^ drivers/gpu/drm/kmb/kmb_dsi.c:824:2: error: unused function 'set_test_mode_src_osc_freq_target_hi_bits' [-Werror,-Wunused-function] set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi, ^ 2 errors generated. Remove them, as they have been unused since the driver's introduction in commit 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver"). Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- drivers/gpu/drm/kmb/kmb_dsi.c | 28 ---------------------------- 1 file changed, 28 deletions(-) base-commit: 93ee1a2c0f08345ab17c51198f725d4c95984f4c