| Message ID | 20210929132753.216068-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 75f81afb27c366fa5a85bd2b75d0e9fd00097a50 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next] octeontx2-af: Remove redundant initialization of variable pin | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 29 Sep 2021 14:27:53 +0100 you wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable pin is being initialized with a value that is never > read, it is being updated later on in only one case of a switch > statement. The assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > [...] Here is the summary with links: - [next] octeontx2-af: Remove redundant initialization of variable pin https://git.kernel.org/netdev/net-next/c/75f81afb27c3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c index 5e3056a89ee0..bc29ec834967 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c @@ -194,7 +194,7 @@ static int otx2_ptp_enable(struct ptp_clock_info *ptp_info, { struct otx2_ptp *ptp = container_of(ptp_info, struct otx2_ptp, ptp_info); - int pin = -1; + int pin; if (!ptp->nic) return -ENODEV;