diff mbox series

sx8: fix an error code in carm_init_one()

Message ID 20211001122722.GC2283@kili (mailing list archive)
State New, archived
Headers show
Series sx8: fix an error code in carm_init_one() | expand

Commit Message

Dan Carpenter Oct. 1, 2021, 12:27 p.m. UTC 
Return a negative error code here on this error path instead of
returning success.

Fixes: 1683818a4f1a ("block/sx8: add error handling support for add_disk()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/block/sx8.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Jens Axboe Oct. 1, 2021, 7:34 p.m. UTC | #1 
On 10/1/21 6:27 AM, Dan Carpenter wrote:
> Return a negative error code here on this error path instead of
> returning success.

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c
index 1c79248c4826..d1676fe0da1a 100644
--- a/drivers/block/sx8.c
+++ b/drivers/block/sx8.c
@@ -1511,8 +1511,10 @@  static int carm_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
 	DPRINTK("waiting for probe_comp\n");
 	host->probe_err = -ENODEV;
 	wait_for_completion(&host->probe_comp);
-	if (host->probe_err)
+	if (host->probe_err) {
+		rc = host->probe_err;
 		goto err_out_free_irq;
+	}
 
 	printk(KERN_INFO "%s: pci %s, ports %d, io %llx, irq %u, major %d\n",
 	       host->name, pci_name(pdev), (int) CARM_MAX_PORTS,