mbox series

[net,0/2] DSA bridge TX forwarding offload fixes - part 1

Message ID 20211003222312.284175-1-vladimir.oltean@nxp.com (mailing list archive)
Headers show
Series DSA bridge TX forwarding offload fixes - part 1 | expand

Message

Vladimir Oltean Oct. 3, 2021, 10:23 p.m. UTC
This is part 1 of a series of fixes to the bridge TX forwarding offload
feature introduced for v5.15. Sadly, the other fixes are so intrusive
that they cannot be reasonably be sent to the "net" tree, as they also
include API changes. So they are left as part 2 for net-next.

Vladimir Oltean (2):
  net: dsa: tag_dsa: send packets with TX fwd offload from VLAN-unaware
    bridges using VID 0
  net: dsa: fix bridge_num not getting cleared after ports leaving the
    bridge

 net/dsa/dsa2.c    |  2 +-
 net/dsa/tag_dsa.c | 20 ++------------------
 2 files changed, 3 insertions(+), 19 deletions(-)

Comments

Tobias Waldekranz Oct. 4, 2021, 6:38 a.m. UTC | #1
On Mon, Oct 04, 2021 at 01:23, Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> This is part 1 of a series of fixes to the bridge TX forwarding offload
> feature introduced for v5.15. Sadly, the other fixes are so intrusive
> that they cannot be reasonably be sent to the "net" tree, as they also
> include API changes. So they are left as part 2 for net-next.

Please give me some time to test this before merging. My spider sense is
tingling.

Have you tried this (1) on a multi-chip system and (2) in a multi-bridge
setup?

--
Tobias
Vladimir Oltean Oct. 4, 2021, 9:38 a.m. UTC | #2
On Mon, Oct 04, 2021 at 08:38:44AM +0200, Tobias Waldekranz wrote:
> On Mon, Oct 04, 2021 at 01:23, Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> > This is part 1 of a series of fixes to the bridge TX forwarding offload
> > feature introduced for v5.15. Sadly, the other fixes are so intrusive
> > that they cannot be reasonably be sent to the "net" tree, as they also
> > include API changes. So they are left as part 2 for net-next.
> 
> Please give me some time to test this before merging. My spider sense is
> tingling.
> 
> Have you tried this (1) on a multi-chip system and (2) in a multi-bridge
> setup?

Hey, nice hearing from you :) more testing and feedback is always welcome.

When you say "this", which patch are you talking about specifically?