| Message ID | 20211004091236.82010-1-contact@emersion.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/connector: refer to CTA-861-G in the "content type" prop docs | expand |
On Mon, Oct 04, 2021 at 09:12:50AM +0000, Simon Ser wrote: > The KMS documentation doesn't say much about the meaning of each > content type. Add a reference to the specification defining them. > > Signed-off-by: Simon Ser <contact@emersion.fr> > Cc: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Pekka Paalanen <ppaalanen@gmail.com> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > --- > drivers/gpu/drm/drm_connector.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 3bc782b630b9..79d8163686cd 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -1397,6 +1397,8 @@ EXPORT_SYMBOL(drm_connector_attach_dp_subconnector_property); > * Game: > * Content type is game > * > + * The meaning of each content type is defined in CTA-861-G table 15. > + * A bit annoying to have to refer to an external spec, but copy pasting the whole thing here seems a bit questionable. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > * Drivers can set up this property by calling > * drm_connector_attach_content_type_property(). Decoding to > * infoframe values is done through drm_hdmi_avi_infoframe_content_type(). > -- > 2.33.0 >
On Monday, October 4th, 2021 at 11:22, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > A bit annoying to have to refer to an external spec, but copy pasting > the whole thing here seems a bit questionable. Yeah, I'm mostly worried about copyright. We could also invent our own descriptions (Is that even possible without infringing copyright? The person inventing the new descriptions needs to read the original spec to know what to write…), but I think referring to the original spec is desirable regardless.
On Mon, 04 Oct 2021 09:12:50 +0000 Simon Ser <contact@emersion.fr> wrote: > The KMS documentation doesn't say much about the meaning of each > content type. Add a reference to the specification defining them. > > Signed-off-by: Simon Ser <contact@emersion.fr> > Cc: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Pekka Paalanen <ppaalanen@gmail.com> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > --- > drivers/gpu/drm/drm_connector.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 3bc782b630b9..79d8163686cd 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -1397,6 +1397,8 @@ EXPORT_SYMBOL(drm_connector_attach_dp_subconnector_property); > * Game: > * Content type is game > * > + * The meaning of each content type is defined in CTA-861-G table 15. > + * > * Drivers can set up this property by calling > * drm_connector_attach_content_type_property(). Decoding to > * infoframe values is done through drm_hdmi_avi_infoframe_content_type(). Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.com> Thanks! pq
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 3bc782b630b9..79d8163686cd 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -1397,6 +1397,8 @@ EXPORT_SYMBOL(drm_connector_attach_dp_subconnector_property); * Game: * Content type is game * + * The meaning of each content type is defined in CTA-861-G table 15. + * * Drivers can set up this property by calling * drm_connector_attach_content_type_property(). Decoding to * infoframe values is done through drm_hdmi_avi_infoframe_content_type().
The KMS documentation doesn't say much about the meaning of each content type. Add a reference to the specification defining them. Signed-off-by: Simon Ser <contact@emersion.fr> Cc: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Pekka Paalanen <ppaalanen@gmail.com> Cc: Ville Syrjala <ville.syrjala@linux.intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> --- drivers/gpu/drm/drm_connector.c | 2 ++ 1 file changed, 2 insertions(+)