mbox series

[0/2] scsi: ufs: Do not exit reset of error functions unless operational

Message ID 20211002154550.128511-1-adrian.hunter@intel.com (mailing list archive)
Headers show
Series scsi: ufs: Do not exit reset of error functions unless operational | expand

Message

Adrian Hunter Oct. 2, 2021, 3:45 p.m. UTC
Hi

Callers of ufshcd_reset_and_restore() and ufshcd_err_handler() expect them
to return in an operational state. However, the code does not check the
state before exiting.  Here are a couple of patches to correct that.


Adrian Hunter (2):
      scsi: ufs: Do not exit ufshcd_reset_and_restore() unless operational or dead
      scsi: ufs: Do not exit ufshcd_err_handler() unless operational or dead

 drivers/scsi/ufs/ufshcd.c | 66 ++++++++++++++++++++++++++++++++++-------------
 1 file changed, 48 insertions(+), 18 deletions(-)


Regards
Adrian

Comments

Martin K. Petersen Oct. 5, 2021, 2:21 a.m. UTC | #1
Adrian,

> Callers of ufshcd_reset_and_restore() and ufshcd_err_handler() expect
> them to return in an operational state. However, the code does not
> check the state before exiting.  Here are a couple of patches to
> correct that.

Applied to 5.16/scsi-staging, thanks!
Martin K. Petersen Oct. 12, 2021, 8:35 p.m. UTC | #2
On Sat, 2 Oct 2021 18:45:48 +0300, Adrian Hunter wrote:

> Callers of ufshcd_reset_and_restore() and ufshcd_err_handler() expect them
> to return in an operational state. However, the code does not check the
> state before exiting.  Here are a couple of patches to correct that.
> 
> 
> Adrian Hunter (2):
>       scsi: ufs: Do not exit ufshcd_reset_and_restore() unless operational or dead
>       scsi: ufs: Do not exit ufshcd_err_handler() unless operational or dead
> 
> [...]

Applied to 5.16/scsi-queue, thanks!

[1/2] scsi: ufs: Do not exit ufshcd_reset_and_restore() unless operational or dead
      https://git.kernel.org/mkp/scsi/c/54a4045342a8
[2/2] scsi: ufs: Do not exit ufshcd_err_handler() unless operational or dead
      https://git.kernel.org/mkp/scsi/c/87bf6a6bbe8b