diff mbox series

scsi: efct: Delete stray unlock statement

Message ID 20211004103851.GE25015@kili (mailing list archive)
State Accepted
Commit a013c71c6315d6e9d6364d12251b98c75c9a2861
Headers show
Series scsi: efct: Delete stray unlock statement | expand

Commit Message

Dan Carpenter Oct. 4, 2021, 10:38 a.m. UTC 
It's not holding the lock at this stage and the IRQ "flags" are not
correct so it would restore something bogus.  Delete the unlock
statement.

Fixes: 3e6414003bf9 ("scsi: elx: efct: SCSI I/O handling routines")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/scsi/elx/efct/efct_scsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Martin K. Petersen Oct. 5, 2021, 4:33 a.m. UTC | #1 
On Mon, 4 Oct 2021 13:38:51 +0300, Dan Carpenter wrote:

> It's not holding the lock at this stage and the IRQ "flags" are not
> correct so it would restore something bogus.  Delete the unlock
> statement.
> 
> 

Applied to 5.15/scsi-fixes, thanks!

[1/1] scsi: efct: Delete stray unlock statement
      https://git.kernel.org/mkp/scsi/c/a013c71c6315
diff mbox series

Patch

diff --git a/drivers/scsi/elx/efct/efct_scsi.c b/drivers/scsi/elx/efct/efct_scsi.c
index 8535bb7eabd8..afb154992053 100644
--- a/drivers/scsi/elx/efct/efct_scsi.c
+++ b/drivers/scsi/elx/efct/efct_scsi.c
@@ -32,7 +32,7 @@  efct_scsi_io_alloc(struct efct_node *node)
 	struct efct *efct;
 	struct efct_xport *xport;
 	struct efct_io *io;
-	unsigned long flags = 0;
+	unsigned long flags;
 
 	efct = node->efct;
 
@@ -42,7 +42,6 @@  efct_scsi_io_alloc(struct efct_node *node)
 	if (!io) {
 		efc_log_err(efct, "IO alloc Failed\n");
 		atomic_add_return(1, &xport->io_alloc_failed_count);
-		spin_unlock_irqrestore(&node->active_ios_lock, flags);
 		return NULL;
 	}