diff mbox series

[v1,3/6] arm64: dts: imx8mq-librem5: wire up the wifi regulator

Message ID 20210913135706.309685-4-martin.kepplinger@puri.sm (mailing list archive)
State New, archived
Headers show
Series arm64: dts: imx8mq-librem5: wifi updates and minor fixes | expand

Commit Message

Martin Kepplinger Sept. 13, 2021, 1:57 p.m. UTC 
From: Guido Günther <agx@sigxcpu.org>

Connect the wifi power regulator to the corresponding GPIO.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Shawn Guo Oct. 4, 2021, noon UTC | #1 
On Mon, Sep 13, 2021 at 03:57:03PM +0200, Martin Kepplinger wrote:
> From: Guido Günther <agx@sigxcpu.org>
> 
> Connect the wifi power regulator to the corresponding GPIO.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index ba26c6ee98a0..b5562c8f9a3c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -138,9 +138,15 @@ reg_vsys_3v4: regulator-vsys-3v4 {
>  
>  	reg_wifi_3v3: regulator-wifi-3v3 {
>  		compatible = "regulator-fixed";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_wifi_pwr>;
>  		regulator-name = "3V3_WIFI";
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio3 10 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +		vin-supply = <&reg_vdd_3v3>;
> +		regulator-always-on;

Any reason you need to have this always-on?

Shawn

>  	};
>  
>  	sound {
> @@ -638,6 +644,13 @@ MX8MQ_IOMUXC_SD2_RESET_B_USDHC2_RESET_B 0xc1
>  		>;
>  	};
>  
> +	pinctrl_wifi_pwr: wifipwrgrp {
> +		fsl,pins = <
> +			/* WIFI3V3_EN */
> +			MX8MQ_IOMUXC_NAND_DATA04_GPIO3_IO10	0x83
> +		>;
> +	};
> +
>  	pinctrl_wdog: wdoggrp {
>  		fsl,pins = <
>  			/* nWDOG */
> -- 
> 2.30.2
>
Guido Günther Oct. 5, 2021, 12:12 p.m. UTC | #2 
Hi Shawn,
On Mon, Oct 04, 2021 at 08:00:57PM +0800, Shawn Guo wrote:
> On Mon, Sep 13, 2021 at 03:57:03PM +0200, Martin Kepplinger wrote:
> > From: Guido Günther <agx@sigxcpu.org>
> > 
> > Connect the wifi power regulator to the corresponding GPIO.
> > 
> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> > index ba26c6ee98a0..b5562c8f9a3c 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> > @@ -138,9 +138,15 @@ reg_vsys_3v4: regulator-vsys-3v4 {
> >  
> >  	reg_wifi_3v3: regulator-wifi-3v3 {
> >  		compatible = "regulator-fixed";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_wifi_pwr>;
> >  		regulator-name = "3V3_WIFI";
> >  		regulator-min-microvolt = <3300000>;
> >  		regulator-max-microvolt = <3300000>;
> > +		gpio = <&gpio3 10 GPIO_ACTIVE_HIGH>;
> > +		enable-active-high;
> > +		vin-supply = <&reg_vdd_3v3>;
> > +		regulator-always-on;
> 
> Any reason you need to have this always-on?

I think we can drop the `regulator-always-on` nowadays - it's wired up
correctly as `vmmc-supply` so turned on accordingly. Will drop for
the next revision.
Cheers,
 -- Guido

> 
> Shawn
> 
> >  	};
> >  
> >  	sound {
> > @@ -638,6 +644,13 @@ MX8MQ_IOMUXC_SD2_RESET_B_USDHC2_RESET_B 0xc1
> >  		>;
> >  	};
> >  
> > +	pinctrl_wifi_pwr: wifipwrgrp {
> > +		fsl,pins = <
> > +			/* WIFI3V3_EN */
> > +			MX8MQ_IOMUXC_NAND_DATA04_GPIO3_IO10	0x83
> > +		>;
> > +	};
> > +
> >  	pinctrl_wdog: wdoggrp {
> >  		fsl,pins = <
> >  			/* nWDOG */
> > -- 
> > 2.30.2
> > 
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index ba26c6ee98a0..b5562c8f9a3c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -138,9 +138,15 @@  reg_vsys_3v4: regulator-vsys-3v4 {
 
 	reg_wifi_3v3: regulator-wifi-3v3 {
 		compatible = "regulator-fixed";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_wifi_pwr>;
 		regulator-name = "3V3_WIFI";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio3 10 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+		vin-supply = <&reg_vdd_3v3>;
+		regulator-always-on;
 	};
 
 	sound {
@@ -638,6 +644,13 @@  MX8MQ_IOMUXC_SD2_RESET_B_USDHC2_RESET_B 0xc1
 		>;
 	};
 
+	pinctrl_wifi_pwr: wifipwrgrp {
+		fsl,pins = <
+			/* WIFI3V3_EN */
+			MX8MQ_IOMUXC_NAND_DATA04_GPIO3_IO10	0x83
+		>;
+	};
+
 	pinctrl_wdog: wdoggrp {
 		fsl,pins = <
 			/* nWDOG */