[0/2] failover: don't allow to migrate a paused VM that needs PCI unplug

Message

Laurent Vivier Sept. 29, 2021, 2:43 p.m. UTC

As the guest OS is paused, we will never receive the unplug event
from the kernel and the migration cannot continue.

The first patch is optional, it provides the error message to display
to migration_cancel() rather than to have to call migrate_set_error()
from the caller.

Laurent Vivier (2):
  migration: provide an error message to migration_cancel()
  failover: don't allow to migrate a paused VM that needs PCI unplug

 migration/migration.h |  2 +-
 hw/net/virtio-net.c   | 10 +++++++++-
 migration/migration.c |  9 ++++++---
 migration/ram.c       |  3 +--
 4 files changed, 17 insertions(+), 7 deletions(-)

Comments

Laurent Vivier Oct. 6, 2021, 9:22 a.m. UTC | #1

On 29/09/2021 16:43, Laurent Vivier wrote:
> As the guest OS is paused, we will never receive the unplug event
> from the kernel and the migration cannot continue.
> 
> The first patch is optional, it provides the error message to display
> to migration_cancel() rather than to have to call migrate_set_error()
> from the caller.
> 
> Laurent Vivier (2):
>    migration: provide an error message to migration_cancel()
>    failover: don't allow to migrate a paused VM that needs PCI unplug
> 
>   migration/migration.h |  2 +-
>   hw/net/virtio-net.c   | 10 +++++++++-
>   migration/migration.c |  9 ++++++---
>   migration/ram.c       |  3 +--
>   4 files changed, 17 insertions(+), 7 deletions(-)
> 

Any comment?

Thanks,
Laurent

Laurent Vivier Oct. 21, 2021, 8:49 a.m. UTC | #2

On 29/09/2021 16:43, Laurent Vivier wrote:
> As the guest OS is paused, we will never receive the unplug event
> from the kernel and the migration cannot continue.
> 
> The first patch is optional, it provides the error message to display
> to migration_cancel() rather than to have to call migrate_set_error()
> from the caller.
> 
> Laurent Vivier (2):
>    migration: provide an error message to migration_cancel()
>    failover: don't allow to migrate a paused VM that needs PCI unplug
> 
>   migration/migration.h |  2 +-
>   hw/net/virtio-net.c   | 10 +++++++++-
>   migration/migration.c |  9 ++++++---
>   migration/ram.c       |  3 +--
>   4 files changed, 17 insertions(+), 7 deletions(-)
> 

ping...