diff mbox series

[net] gve: report 64bit tx_bytes counter from gve_handle_report_stats()

Message ID 20211006010138.3215494-1-eric.dumazet@gmail.com (mailing list archive)
State Accepted
Commit 17c37d748f2b122a95b6d0524d410302ff89a2b1
Delegated to: Netdev Maintainers
Headers show
Series [net] gve: report 64bit tx_bytes counter from gve_handle_report_stats() | expand

Checks

Context Check Description
netdev/cover_letter success Single patches do not need cover letters
netdev/fixes_present success Fixes tag present in non-next series
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for net
netdev/subject_prefix success Link
netdev/cc_maintainers warning 5 maintainers not CCed: csully@google.com jeroendb@google.com bcf@google.com willemb@google.com christophe.jaillet@wanadoo.fr
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Fixes tag looks correct
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 12 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success No static functions without inline keyword in header files

Commit Message

Eric Dumazet Oct. 6, 2021, 1:01 a.m. UTC 
From: Eric Dumazet <edumazet@google.com>

Each tx queue maintains a 64bit counter for bytes, there is
no reason to truncate this to 32bit (or this has not been
documented)

Fixes: 24aeb56f2d38 ("gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Yangchun Fu <yangchun@google.com>
Cc: Kuo Zhao <kuozhao@google.com>
Cc: David Awogbemila <awogbemila@google.com>
---
 drivers/net/ethernet/google/gve/gve_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 6, 2021, 2:20 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue,  5 Oct 2021 18:01:38 -0700 you wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> Each tx queue maintains a 64bit counter for bytes, there is
> no reason to truncate this to 32bit (or this has not been
> documented)
> 
> Fixes: 24aeb56f2d38 ("gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags.")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Yangchun Fu <yangchun@google.com>
> Cc: Kuo Zhao <kuozhao@google.com>
> Cc: David Awogbemila <awogbemila@google.com>
> 
> [...]

Here is the summary with links:
  - [net] gve: report 64bit tx_bytes counter from gve_handle_report_stats()
    https://git.kernel.org/netdev/net/c/17c37d748f2b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
index 99837c9d2cba698ada900229330cb10bc1606a6b..fc7cdf934ddc6cb336a86ef05b1a4fcdf73cb69a 100644
--- a/drivers/net/ethernet/google/gve/gve_main.c
+++ b/drivers/net/ethernet/google/gve/gve_main.c
@@ -1190,9 +1190,10 @@  static void gve_handle_reset(struct gve_priv *priv)
 
 void gve_handle_report_stats(struct gve_priv *priv)
 {
-	int idx, stats_idx = 0, tx_bytes;
-	unsigned int start = 0;
 	struct stats *stats = priv->stats_report->stats;
+	int idx, stats_idx = 0;
+	unsigned int start = 0;
+	u64 tx_bytes;
 
 	if (!gve_get_report_stats(priv))
 		return;