[01/11] selftests: net/fcnal: Fix {ipv4,ipv6}_bind not run by default

Commit Message

Leonard Crestez Oct. 6, 2021, 11:47 a.m. UTC

Inside the TESTS_IPV{4,6} array these are listed as ipv{4,6}_addr_bind
but test running loop only checks for ipv{4,6}_bind and bind{,6} and
ignores everything else.

As a consequence these tests were not run by default, only with an
explicit -t.

Fix inside TESTS_IPV{4,6}.

Signed-off-by: Leonard Crestez <[e-mail]>
---
 tools/testing/selftests/net/fcnal-test.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Ahern Oct. 6, 2021, 2:37 p.m. UTC | #1

On 10/6/21 5:47 AM, Leonard Crestez wrote:
> Inside the TESTS_IPV{4,6} array these are listed as ipv{4,6}_addr_bind
> but test running loop only checks for ipv{4,6}_bind and bind{,6} and
> ignores everything else.
> 
> As a consequence these tests were not run by default, only with an
> explicit -t.
> 
> Fix inside TESTS_IPV{4,6}.
> 
> Signed-off-by: Leonard Crestez <[e-mail]>
> ---
>  tools/testing/selftests/net/fcnal-test.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Good catch.

Reviewed-by: David Ahern <[e-mail]>

Patch

diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
index 13350cd5c8ac..2839bed91afa 100755
--- a/tools/testing/selftests/net/fcnal-test.sh
+++ b/tools/testing/selftests/net/fcnal-test.sh
@@ -3937,12 +3937,12 @@  EOF
 }
 
 ################################################################################
 # main
 
-TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_addr_bind ipv4_runtime ipv4_netfilter"
-TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_addr_bind ipv6_runtime ipv6_netfilter"
+TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter"
+TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter"
 TESTS_OTHER="use_cases"
 
 PAUSE_ON_FAIL=no
 PAUSE=no