diff mbox series

[bpf-next,v3,08/10] samples/bpf: update .gitignore

Message ID 20211003192208.6297-9-quentin@isovalent.com (mailing list archive)
State Superseded
Delegated to: BPF
Headers show
Series install libbpf headers when using the library | expand

Checks

Context Check Description
bpf/vmtest-bpf-next-PR success PR summary
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for bpf-next
netdev/subject_prefix success Link
netdev/cc_maintainers warning 5 maintainers not CCed: kafai@fb.com john.fastabend@gmail.com songliubraving@fb.com yhs@fb.com kpsingh@kernel.org
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link
bpf/vmtest-bpf-next success VM_Test

Commit Message

Quentin Monnet Oct. 3, 2021, 7:22 p.m. UTC
Update samples/bpf/.gitignore to ignore files generated when building
the samples. Add:

  - vmlinux.h
  - the generated skeleton files (*.skel.h)
  - the samples/bpf/libbpf/ and .../bpftool/ directories, recently
    introduced as an output directory for building libbpf and bpftool.

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
---
 samples/bpf/.gitignore | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Andrii Nakryiko Oct. 6, 2021, 6:24 p.m. UTC | #1
On Sun, Oct 3, 2021 at 12:22 PM Quentin Monnet <quentin@isovalent.com> wrote:
>
> Update samples/bpf/.gitignore to ignore files generated when building
> the samples. Add:
>
>   - vmlinux.h
>   - the generated skeleton files (*.skel.h)
>   - the samples/bpf/libbpf/ and .../bpftool/ directories, recently
>     introduced as an output directory for building libbpf and bpftool.
>
> Signed-off-by: Quentin Monnet <quentin@isovalent.com>
> ---
>  samples/bpf/.gitignore | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore
> index fcba217f0ae2..09a091b8a4f3 100644
> --- a/samples/bpf/.gitignore
> +++ b/samples/bpf/.gitignore
> @@ -57,3 +57,7 @@ testfile.img
>  hbm_out.log
>  iperf.*
>  *.out
> +*.skel.h
> +vmlinux.h
> +bpftool/
> +libbpf/

this will match files and directories in any subdir as well, maybe
let's add / in front to be explicit about doing this only on current
directly level (*.skel.h is fine)?

> --
> 2.30.2
>
Andrii Nakryiko Oct. 6, 2021, 6:25 p.m. UTC | #2
On Wed, Oct 6, 2021 at 11:24 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Sun, Oct 3, 2021 at 12:22 PM Quentin Monnet <quentin@isovalent.com> wrote:
> >
> > Update samples/bpf/.gitignore to ignore files generated when building
> > the samples. Add:
> >
> >   - vmlinux.h
> >   - the generated skeleton files (*.skel.h)
> >   - the samples/bpf/libbpf/ and .../bpftool/ directories, recently
> >     introduced as an output directory for building libbpf and bpftool.
> >
> > Signed-off-by: Quentin Monnet <quentin@isovalent.com>
> > ---
> >  samples/bpf/.gitignore | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore
> > index fcba217f0ae2..09a091b8a4f3 100644
> > --- a/samples/bpf/.gitignore
> > +++ b/samples/bpf/.gitignore
> > @@ -57,3 +57,7 @@ testfile.img
> >  hbm_out.log
> >  iperf.*
> >  *.out
> > +*.skel.h
> > +vmlinux.h
> > +bpftool/
> > +libbpf/
>
> this will match files and directories in any subdir as well, maybe
> let's add / in front to be explicit about doing this only on current
> directly level (*.skel.h is fine)?

Oh, let's also move this patch before the samples/bpf changes, so that
there is no intermediate state between commits where we have these
files not ignored


>
> > --
> > 2.30.2
> >
diff mbox series

Patch

diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore
index fcba217f0ae2..09a091b8a4f3 100644
--- a/samples/bpf/.gitignore
+++ b/samples/bpf/.gitignore
@@ -57,3 +57,7 @@  testfile.img
 hbm_out.log
 iperf.*
 *.out
+*.skel.h
+vmlinux.h
+bpftool/
+libbpf/