| Message ID | 20211006140259.12689-1-tim.gardner@canonical.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next,RFC] qed: Initialize debug string array | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 8 of 8 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | fail | Problems with Fixes tag: 1 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | No static functions without inline keyword in header files |
Hi Tim, > -----Original Message----- > From: Tim Gardner <tim.gardner@canonical.com> > Sent: Wednesday, October 6, 2021 7:33 PM > To: Ariel Elior <aelior@marvell.com> > Cc: tim.gardner@canonical.com; GR-everest-linux-l2 <GR-everest-linux- > l2@marvell.com>; David S. Miller <davem@davemloft.net>; Jakub Kicinski > <kuba@kernel.org>; Shai Malin <smalin@marvell.com>; Omkar Kulkarni > <okulkarni@marvell.com>; Prabhakar Kushwaha <pkushwaha@marvell.com>; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [EXT] [PATCH][next][RFC] qed: Initialize debug string array > > External Email > > ---------------------------------------------------------------------- > Coverity complains of an uninitialized variable. > > CID 120847 (#1 of 1): Uninitialized scalar variable (UNINIT) > 3. uninit_use_in_call: Using uninitialized value *sw_platform_str when calling > qed_dump_str_param. [show details] > 1344 offset += qed_dump_str_param(dump_buf + offset, > 1345 dump, "sw-platform", sw_platform_str); > > Fix this by initializing the string array with '\0'. > > Fixes: 6c95dd8f0aa1d ("qed: Update debug related changes") > > Cc: Ariel Elior <aelior@marvell.com> > Cc: GR-everest-linux-l2@marvell.com > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Shai Malin <smalin@marvell.com> > Cc: Omkar Kulkarni <okulkarni@marvell.com> > Cc: Prabhakar Kushwaha <pkushwaha@marvell.com> > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org (open list) > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > --- > > I'm not sure what the value of sw_platform_str should be, but this patch is > clearly a bandaid and not a proper solution. > > --- > drivers/net/ethernet/qlogic/qed/qed_debug.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c > b/drivers/net/ethernet/qlogic/qed/qed_debug.c > index 6d693ee380f1..a393b786c5dc 100644 > --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c > +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c > @@ -1319,6 +1319,8 @@ static u32 qed_dump_common_global_params(struct > qed_hwfn *p_hwfn, > u32 offset = 0; > u8 num_params; > > + sw_platform_str[0] = '\0'; > + Thanks for pointing out. It is leftover code which I missed to remove. Proper solution will be below. Please let me know if you are planning to send this fix else I will post. diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic/qed/qed_debug.c index 6d693ee380f1..f6198b9a1b02 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c @@ -1315,7 +1315,6 @@ static u32 qed_dump_common_global_params(struct qed_hwfn *p_hwfn, u8 num_specific_global_params) { struct dbg_tools_data *dev_data = &p_hwfn->dbg_info; - char sw_platform_str[MAX_SW_PLTAFORM_STR_SIZE]; u32 offset = 0; u8 num_params; @@ -1341,8 +1340,6 @@ static u32 qed_dump_common_global_params(struct qed_hwfn *p_hwfn, dump, "platform", s_hw_type_defs[dev_data->hw_type].name); - offset += qed_dump_str_param(dump_buf + offset, - dump, "sw-platform", sw_platform_str); offset += qed_dump_num_param(dump_buf + offset, dump, "pci-func", p_hwfn->abs_pf_id); offset += qed_dump_num_param(dump_buf + offset, --pk
diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic/qed/qed_debug.c index 6d693ee380f1..a393b786c5dc 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c @@ -1319,6 +1319,8 @@ static u32 qed_dump_common_global_params(struct qed_hwfn *p_hwfn, u32 offset = 0; u8 num_params; + sw_platform_str[0] = '\0'; + /* Dump global params section header */ num_params = NUM_COMMON_GLOBAL_PARAMS + num_specific_global_params + (dev_data->chip_id == CHIP_BB ? 1 : 0);
Coverity complains of an uninitialized variable. CID 120847 (#1 of 1): Uninitialized scalar variable (UNINIT) 3. uninit_use_in_call: Using uninitialized value *sw_platform_str when calling qed_dump_str_param. [show details] 1344 offset += qed_dump_str_param(dump_buf + offset, 1345 dump, "sw-platform", sw_platform_str); Fix this by initializing the string array with '\0'. Fixes: 6c95dd8f0aa1d ("qed: Update debug related changes") Cc: Ariel Elior <aelior@marvell.com> Cc: GR-everest-linux-l2@marvell.com Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Shai Malin <smalin@marvell.com> Cc: Omkar Kulkarni <okulkarni@marvell.com> Cc: Prabhakar Kushwaha <pkushwaha@marvell.com> Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org (open list) Signed-off-by: Tim Gardner <tim.gardner@canonical.com> --- I'm not sure what the value of sw_platform_str should be, but this patch is clearly a bandaid and not a proper solution. --- drivers/net/ethernet/qlogic/qed/qed_debug.c | 2 ++ 1 file changed, 2 insertions(+)