| Message ID | 20210913132035.242870-13-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | nfc: minor printk cleanup | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 9 maintainers not CCed: kpsingh@kernel.org john.fastabend@gmail.com yhs@fb.com daniel@iogearbox.net bpf@vger.kernel.org andrii@kernel.org songliubraving@fb.com ast@kernel.org kafai@fb.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 32 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Mon, Sep 13, 2021 at 03:20:32PM +0200, Krzysztof Kozlowski wrote: > ftrace is a preferred and standard way to debug entering and exiting > functions so drop useless debug prints. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > drivers/nfc/trf7970a.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c > index 8890fcd59c39..29ca9c328df2 100644 > --- a/drivers/nfc/trf7970a.c > +++ b/drivers/nfc/trf7970a.c > @@ -2170,8 +2170,6 @@ static int trf7970a_suspend(struct device *dev) > struct spi_device *spi = to_spi_device(dev); > struct trf7970a *trf = spi_get_drvdata(spi); > > - dev_dbg(dev, "Suspend\n"); > - > mutex_lock(&trf->lock); > > trf7970a_shutdown(trf); > @@ -2187,8 +2185,6 @@ static int trf7970a_resume(struct device *dev) > struct trf7970a *trf = spi_get_drvdata(spi); > int ret; > > - dev_dbg(dev, "Resume\n"); > - > mutex_lock(&trf->lock); > > ret = trf7970a_startup(trf); > @@ -2206,8 +2202,6 @@ static int trf7970a_pm_runtime_suspend(struct device *dev) > struct trf7970a *trf = spi_get_drvdata(spi); > int ret; > > - dev_dbg(dev, "Runtime suspend\n"); > - > mutex_lock(&trf->lock); > > ret = trf7970a_power_down(trf); > @@ -2223,8 +2217,6 @@ static int trf7970a_pm_runtime_resume(struct device *dev) > struct trf7970a *trf = spi_get_drvdata(spi); > int ret; > > - dev_dbg(dev, "Runtime resume\n"); > - > ret = trf7970a_power_up(trf); > if (!ret) > pm_runtime_mark_last_busy(dev); > -- > 2.30.2 Acked-by: Mark Greer <mgreer@animalcreek.com>
On 13/09/2021 18:57, Mark Greer wrote: > On Mon, Sep 13, 2021 at 03:20:32PM +0200, Krzysztof Kozlowski wrote: >> ftrace is a preferred and standard way to debug entering and exiting >> functions so drop useless debug prints. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> --- >> drivers/nfc/trf7970a.c | 8 -------- >> 1 file changed, 8 deletions(-) >> Hi Jakub and David, Some patches from this set were applied, but rest was not. All of them are however marked as accepted: https://patchwork.kernel.org/project/netdevbpf/list/?series=545829&state=* I think something got lost. Could you apply missing ones or maybe I should rebase and resend? Best regards, Krzysztof
On Thu, 7 Oct 2021 15:01:25 +0200 Krzysztof Kozlowski wrote: > I think something got lost. Could you apply missing ones or maybe I > should rebase and resend? Sorry about that, rebase & resend would you perfect.
diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c index 8890fcd59c39..29ca9c328df2 100644 --- a/drivers/nfc/trf7970a.c +++ b/drivers/nfc/trf7970a.c @@ -2170,8 +2170,6 @@ static int trf7970a_suspend(struct device *dev) struct spi_device *spi = to_spi_device(dev); struct trf7970a *trf = spi_get_drvdata(spi); - dev_dbg(dev, "Suspend\n"); - mutex_lock(&trf->lock); trf7970a_shutdown(trf); @@ -2187,8 +2185,6 @@ static int trf7970a_resume(struct device *dev) struct trf7970a *trf = spi_get_drvdata(spi); int ret; - dev_dbg(dev, "Resume\n"); - mutex_lock(&trf->lock); ret = trf7970a_startup(trf); @@ -2206,8 +2202,6 @@ static int trf7970a_pm_runtime_suspend(struct device *dev) struct trf7970a *trf = spi_get_drvdata(spi); int ret; - dev_dbg(dev, "Runtime suspend\n"); - mutex_lock(&trf->lock); ret = trf7970a_power_down(trf); @@ -2223,8 +2217,6 @@ static int trf7970a_pm_runtime_resume(struct device *dev) struct trf7970a *trf = spi_get_drvdata(spi); int ret; - dev_dbg(dev, "Runtime resume\n"); - ret = trf7970a_power_up(trf); if (!ret) pm_runtime_mark_last_busy(dev);
ftrace is a preferred and standard way to debug entering and exiting functions so drop useless debug prints. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- drivers/nfc/trf7970a.c | 8 -------- 1 file changed, 8 deletions(-)