| Message ID | 20211008002225.2426-14-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Multiple improvement for qca8337 switch | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Series has a cover letter |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 9 of 9 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 17 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | No static functions without inline keyword in header files |
On Fri, Oct 08, 2021 at 02:22:23AM +0200, Ansuel Smith wrote: > Document new binding qca,power_on_sel used to enable Power-on-strapping > select reg and qca,led_open_drain to set led to open drain mode. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > index b9cccb657373..9fb4db65907e 100644 > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > @@ -13,6 +13,17 @@ Required properties: > Optional properties: > > - reset-gpios: GPIO to be used to reset the whole device > +- qca,ignore-power-on-sel: Ignore power on pin strapping to configure led open > + drain or eeprom presence. So strapping is only used for LEDs and EEPROM presence? Nothing else? Seems link MAC0/MAC6 swap would be a good candidate for strapping? I just want to make it clear that if you select this option, you need to take care of X, Y and Z in DT. Andrew
On Sat, Oct 09, 2021 at 07:20:49PM +0200, Andrew Lunn wrote: > On Fri, Oct 08, 2021 at 02:22:23AM +0200, Ansuel Smith wrote: > > Document new binding qca,power_on_sel used to enable Power-on-strapping > > select reg and qca,led_open_drain to set led to open drain mode. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > --- > > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > index b9cccb657373..9fb4db65907e 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > @@ -13,6 +13,17 @@ Required properties: > > Optional properties: > > > > - reset-gpios: GPIO to be used to reset the whole device > > +- qca,ignore-power-on-sel: Ignore power on pin strapping to configure led open > > + drain or eeprom presence. > > So strapping is only used for LEDs and EEPROM presence? Nothing else? > Seems link MAC0/MAC6 swap would be a good candidate for strapping? > > I just want to make it clear that if you select this option, you need > to take care of X, Y and Z in DT. > > Andrew Sorry I missed this. Yes strapping is used only for LEDs and EEPROM. No reference in Documentation about mac swap. Other strapping are related to voltage selection and other hardware stuff. Thing that can't be set from sw.
diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt index b9cccb657373..9fb4db65907e 100644 --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt @@ -13,6 +13,17 @@ Required properties: Optional properties: - reset-gpios: GPIO to be used to reset the whole device +- qca,ignore-power-on-sel: Ignore power on pin strapping to configure led open + drain or eeprom presence. This is needed for broken + device that have wrong configuration or when the oem + decided to not use pin strapping and fallback to sw + regs. +- qca,led-open-drain: Set leds to open-drain mode. This require the + qca,ignore-power-on-sel to be set or the driver will fail + to probe. This is needed if the oem doesn't use pin + strapping to set this mode and prefer to set it using sw + regs. The pin strapping related to led open drain mode is + the pin B68 for QCA832x and B49 for QCA833x - qca,mac6-exchange: Internally swap MAC0 with MAC6. - qca,sgmii-rxclk-falling-edge: Set the receive clock phase to falling edge. Mostly used in qca8327 with CPU port 0 set to
Document new binding qca,power_on_sel used to enable Power-on-strapping select reg and qca,led_open_drain to set led to open drain mode. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> --- Documentation/devicetree/bindings/net/dsa/qca8k.txt | 11 +++++++++++ 1 file changed, 11 insertions(+)