| Message ID | 20211012084443.GA31472@kili (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block/rnbd-clt-sysfs: fix a couple uninitialized variable bugs | expand |
On Tue, Oct 12, 2021 at 10:45 AM Dan Carpenter <dan.carpenter@oracle.com> wrote: > > These variables are printed on the error path if match_int() fails so > they have to be initialized. > > Fixes: 2958a995edc9 ("block/rnbd-clt: Support polling mode for IO latency optimization") > Fixes: 1eb54f8f5dd8 ("block/rnbd: client: sysfs interface functions") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/block/rnbd/rnbd-clt-sysfs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/rnbd/rnbd-clt-sysfs.c b/drivers/block/rnbd/rnbd-clt-sysfs.c > index 4b93fd83bf79..44e45af00e83 100644 > --- a/drivers/block/rnbd/rnbd-clt-sysfs.c > +++ b/drivers/block/rnbd/rnbd-clt-sysfs.c > @@ -71,8 +71,10 @@ static int rnbd_clt_parse_map_options(const char *buf, size_t max_path_cnt, > int opt_mask = 0; > int token; > int ret = -EINVAL; > - int i, dest_port, nr_poll_queues; > + int nr_poll_queues = 0; > + int dest_port = 0; > int p_cnt = 0; > + int i; > > options = kstrdup(buf, GFP_KERNEL); > if (!options) > -- > 2.20.1 > Thank you. Acked-by: Gioh Kim <gi-oh.kim@ionos.com>
On 10/12/21 2:44 AM, Dan Carpenter wrote: > These variables are printed on the error path if match_int() fails so > they have to be initialized. Applied, thanks.
diff --git a/drivers/block/rnbd/rnbd-clt-sysfs.c b/drivers/block/rnbd/rnbd-clt-sysfs.c index 4b93fd83bf79..44e45af00e83 100644 --- a/drivers/block/rnbd/rnbd-clt-sysfs.c +++ b/drivers/block/rnbd/rnbd-clt-sysfs.c @@ -71,8 +71,10 @@ static int rnbd_clt_parse_map_options(const char *buf, size_t max_path_cnt, int opt_mask = 0; int token; int ret = -EINVAL; - int i, dest_port, nr_poll_queues; + int nr_poll_queues = 0; + int dest_port = 0; int p_cnt = 0; + int i; options = kstrdup(buf, GFP_KERNEL); if (!options)
These variables are printed on the error path if match_int() fails so they have to be initialized. Fixes: 2958a995edc9 ("block/rnbd-clt: Support polling mode for IO latency optimization") Fixes: 1eb54f8f5dd8 ("block/rnbd: client: sysfs interface functions") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/block/rnbd/rnbd-clt-sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)